diff --git a/hadrian/src/Settings/Builders/RunTest.hs b/hadrian/src/Settings/Builders/RunTest.hs index 07991656d9fd0209c6e8836c93e8a46cd0908caa..2ce79da05a6a4e9ff7987c0c34adb2013554f971 100644 --- a/hadrian/src/Settings/Builders/RunTest.hs +++ b/hadrian/src/Settings/Builders/RunTest.hs @@ -280,7 +280,7 @@ runTestBuilderArgs = builder Testsuite ? do , arg "-e", arg $ asBool "ghc_with_dynamic_rts=" (hasDynamicRts) , arg "-e", arg $ asBool "config.ghc_with_threaded_rts=" (hasThreadedRts) , arg "-e", arg $ asBool "config.have_fast_bignum=" (bignumBackend /= "native" && not bignumCheck) - , arg "-e", arg $ asBool "target_with_smp=" targetWithSMP + , arg "-e", arg $ asBool "config.target_has_smp=" targetWithSMP , arg "-e", arg $ "config.ghc_dynamic=" ++ show hasDynamic , arg "-e", arg $ "config.leading_underscore=" ++ show leadingUnderscore diff --git a/testsuite/config/ghc b/testsuite/config/ghc index f22fb392e9f932951f9a3789a0b7e2db75263188..01d1fcf14e9dba0e66c92e2dc01871c18f973aad 100644 --- a/testsuite/config/ghc +++ b/testsuite/config/ghc @@ -48,8 +48,7 @@ if config.have_interp: # whether the target supports smp if config.ghc_with_threaded_rts: config.run_ways.append('threaded1') - if target_with_smp: - config.target_has_smp = True + if config.target_has_smp: config.run_ways.append('threaded2') if config.speed == 0: config.run_ways.append('nonmoving_thr') diff --git a/testsuite/driver/testglobals.py b/testsuite/driver/testglobals.py index c1748f0b9f5d9debac4c4b738ab0c053b5894539..e709ad9738e1bdda3054898721684f5ba9af81c1 100644 --- a/testsuite/driver/testglobals.py +++ b/testsuite/driver/testglobals.py @@ -163,7 +163,7 @@ class TestConfig: self.ghc_has_smp = True # Does the target have SMP support? - self.target_has_smp = True + self.target_has_smp = False # Is gdb available? self.have_gdb = False diff --git a/testsuite/driver/testlib.py b/testsuite/driver/testlib.py index 8eed26529d13bb3255c0b57bd0edc6d8a6248c75..7d41384ea66fbbead6de5bcbb0f88ba3de0ec0e3 100644 --- a/testsuite/driver/testlib.py +++ b/testsuite/driver/testlib.py @@ -346,11 +346,11 @@ def req_ghc_smp( name, opts ): def req_target_smp( name, opts ): """ Mark a test as requiring smp when run on the target. If the target does - not support smp, then mark the test as an expected fail. Use this when the + not support smp, then skip the test. Use this when the test needs to run with smp support. """ if not config.target_has_smp: - opts.expect = 'fail' + opts.skip = True def req_ghc_with_threaded_rts( name, opts ): if not config.ghc_with_threaded_rts: diff --git a/testsuite/mk/test.mk b/testsuite/mk/test.mk index 7b346376aa783686bdc3719a65e8b85211d0cc99..d2cda3d3d902bfd7a48b259935aafde3cdee6516 100644 --- a/testsuite/mk/test.mk +++ b/testsuite/mk/test.mk @@ -164,9 +164,9 @@ CABAL_PLUGIN_BUILD = --enable-library-vanilla --disable-shared endif ifeq "$(GhcWithSMP)" "YES" -RUNTEST_OPTS += -e target_with_smp=True +RUNTEST_OPTS += -e config.target_has_smp=True else -RUNTEST_OPTS += -e target_with_smp=False +RUNTEST_OPTS += -e config.target_has_smp=False endif ifeq "$(GhcWithRtsLinker)" "YES"