diff --git a/hadrian/src/Settings/Builders/RunTest.hs b/hadrian/src/Settings/Builders/RunTest.hs index 4a18f676eb58ee904fe412508c93ad2a2ce89693..26feb2b0667542a2022d3e3e5b5c9bc407bdd34c 100644 --- a/hadrian/src/Settings/Builders/RunTest.hs +++ b/hadrian/src/Settings/Builders/RunTest.hs @@ -263,7 +263,7 @@ runTestBuilderArgs = builder Testsuite ? do , arg "-e", arg $ asBool "ghc_with_dynamic_rts=" (hasDynamicRts) , arg "-e", arg $ asBool "ghc_with_threaded_rts=" (hasThreadedRts) , arg "-e", arg $ asBool "config.have_fast_bignum=" (bignumBackend /= "native" && not bignumCheck) - , arg "-e", arg $ asBool "target_with_smp=" targetWithSMP + , arg "-e", arg $ asBool "config.target_has_smp=" targetWithSMP , arg "-e", arg $ "config.ghc_dynamic=" ++ show hasDynamic , arg "-e", arg $ "config.leading_underscore=" ++ show leadingUnderscore diff --git a/testsuite/config/ghc b/testsuite/config/ghc index ccd89a2348ec86be249cb8ade0c3e5c41f99093f..8ac07a24f7741dabb143d2805b66be3fbdfec8a3 100644 --- a/testsuite/config/ghc +++ b/testsuite/config/ghc @@ -47,8 +47,7 @@ if config.have_interp: # whether the target supports smp if ghc_with_threaded_rts: config.run_ways.append('threaded1') - if target_with_smp: - config.target_has_smp = True + if config.target_has_smp: config.run_ways.append('threaded2') if config.speed == 0: config.run_ways.append('nonmoving_thr') diff --git a/testsuite/driver/testglobals.py b/testsuite/driver/testglobals.py index 76532b4b884cafcb7c531a4c2ffbd05240491852..16251d14247cca02c377b229295b48a7b00c2622 100644 --- a/testsuite/driver/testglobals.py +++ b/testsuite/driver/testglobals.py @@ -157,7 +157,7 @@ class TestConfig: self.ghc_has_smp = True # Does the target have SMP support? - self.target_has_smp = True + self.target_has_smp = False # Is gdb available? self.have_gdb = False diff --git a/testsuite/driver/testlib.py b/testsuite/driver/testlib.py index 6dc10f5988e7fab9fa0e87bab573deb34d6a100c..3708c1658782d6770f8f5373f140c6c65a32ed7e 100644 --- a/testsuite/driver/testlib.py +++ b/testsuite/driver/testlib.py @@ -304,11 +304,11 @@ def req_ghc_smp( name, opts ): def req_target_smp( name, opts ): """ Mark a test as requiring smp when run on the target. If the target does - not support smp, then mark the test as an expected fail. Use this when the + not support smp, then skip the test. Use this when the test needs to run with smp support. """ if not config.target_has_smp: - opts.expect = 'fail' + opts.skip = True def req_process( name, opts ): if not config.have_process: diff --git a/testsuite/mk/test.mk b/testsuite/mk/test.mk index 7c654df9ae7bdfa4ef4a59783eaba5c073d63d05..64dd78ecb26e8a22c24c60c0e5546fe41c7c61fa 100644 --- a/testsuite/mk/test.mk +++ b/testsuite/mk/test.mk @@ -164,9 +164,9 @@ CABAL_PLUGIN_BUILD = --enable-library-vanilla --disable-shared endif ifeq "$(GhcWithSMP)" "YES" -RUNTEST_OPTS += -e target_with_smp=True +RUNTEST_OPTS += -e config.target_has_smp=True else -RUNTEST_OPTS += -e target_with_smp=False +RUNTEST_OPTS += -e config.target_has_smp=False endif ifeq "$(GhcWithRtsLinker)" "YES"