Skip to content
Snippets Groups Projects
  1. Dec 09, 2024
    • Cheng Shao's avatar
      ci: multi-project pipeline for wasm · 9ba84552
      Cheng Shao authored
      (cherry picked from commit 3655c3fd)
      (cherry picked from commit b6d5cce5)
      (cherry picked from commit 48eeb1fa)
      9ba84552
    • Cheng Shao's avatar
      ci: avoid depending on stack job for test-bootstrap jobs · 763e92b8
      Cheng Shao authored
      This patch makes test-bootstrap related ci jobs only depend on
      hadrian-ghc-in-ghci job to finish, consistent with other jobs in the
      full-build stage generated by gen_ci.hs. This allows the jobs to be
      spawned earlier and improve overall pipeline parallelism.
      
      (cherry picked from commit e684c406)
      (cherry picked from commit 4884eb08)
      (cherry picked from commit f3a9d4ec)
      (cherry picked from commit 90253985)
      763e92b8
    • Cheng Shao's avatar
      hadrian: fix bindist makefile for wasm32-wasi target · 1e51e32f
      Cheng Shao authored
      This patch fixes one incoherent place between bindist makefile and
      hadrian logic: I forgot to include wasi/wasm32 in
      OsSupportsGHCi/ArchSupportsGHCi as well. And this results in incorrect
      settings file generated after installing the bindist, and "Use
      interpreter"/"Have interpreter" fields incorrectly have "NO" values
      where they should be "YES" like --info output of in-tree version.
      
      (cherry picked from commit 75a2eae4)
      (cherry picked from commit 735f3f9a)
      (cherry picked from commit aa2e63a1)
      (cherry picked from commit 58c0349a)
      1e51e32f
  2. Nov 15, 2024
    • Cheng Shao's avatar
      Remove obsolete cross-port script · 868e7d4e
      Cheng Shao authored
      This patch removes the obsolete cross-port script in the tree. The
      script was based on the legacy Make build system which has been pruned
      from the tree long ago. For hadrian, proper support for two-stage
      bootstrapping onto a new unsupported platform is a work in progress in
      !11444.
      
      (cherry picked from commit 00d551bf)
      (cherry picked from commit 329a26da)
      (cherry picked from commit 3f3be277)
      (cherry picked from commit be75c80b)
      868e7d4e
  3. Nov 08, 2024
  4. Nov 05, 2024
    • Cheng Shao's avatar
      compiler: remove unused hscDecls/hscDeclsWithLocation · e3148d62
      Cheng Shao authored
      This patch removes unused `hscDecls`/`hscDeclsWithLocation` functions
      from the compiler, to reduce maintenance burden when doing
      refactorings related to ghci.
      
      (cherry picked from commit e3496ef6)
      (cherry picked from commit 85b61354)
      e3148d62
    • Cheng Shao's avatar
      hadrian: fix bindist executable wrapper logic for cross targets · 18ddbd4f
      Cheng Shao authored
      This commit fixes an oversight of hadrian wrapper generation logic:
      when doing cross compilation, `wrapper` is called on executable names
      with cross prefix, therefore we must use `isSuffixOf` when matching to
      take the cross prefix into account. Also add missing cross prefix to
      ghci wrapper content and fix hsc2hs wrapper logic.
      
      (cherry picked from commit b57c2174cf8b4804d400c7db774565b2be4ff493)
      18ddbd4f
    • Cheng Shao's avatar
    • Cheng Shao's avatar
      testsuite: rest of ghc-9.6 fixes for wasm · de7c3acd
      Cheng Shao authored
      de7c3acd
    • Josh Meredith's avatar
      JS generated refs: update testsuite conditions · 926dd355
      Josh Meredith authored and Cheng Shao's avatar Cheng Shao committed
      (cherry picked from commit d69ecac2)
      926dd355
    • Cheng Shao's avatar
      testsuite: skip bkpfail tests that fail on wasm · 1a2a5b86
      Cheng Shao authored
      (cherry picked from commit 1fad5bf1)
      1a2a5b86
    • Cheng Shao's avatar
      testsuite: workaround mysterious framework error · d91933bf
      Cheng Shao authored
      (cherry picked from commit 280c49af)
      d91933bf
    • Cheng Shao's avatar
      rts: fix pointer overflow undefined behavior in bytecode interpreter · 1d6b4ce9
      Cheng Shao authored
      This patch fixes an unnoticed undefined behavior in the bytecode
      interpreter. It can be caught by building `rts/Interpreter.c` with
      `-fsanitize=pointer-overflow`, the warning message is something like:
      
      ```
      rts/Interpreter.c:1369:13: runtime error: addition of unsigned offset to 0x004200197660 overflowed to 0x004200197658
      SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior rts/Interpreter.c:1369:13
      rts/Interpreter.c:1265:13: runtime error: addition of unsigned offset to 0x004200197660 overflowed to 0x004200197658
      SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior rts/Interpreter.c:1265:13
      rts/Interpreter.c:1645:13: runtime error: addition of unsigned offset to 0x0042000b22f8 overflowed to 0x0042000b22f0
      SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior rts/Interpreter.c:1645:13
      ```
      
      Whenever we do something like `SpW(-1)`, the negative argument is
      implicitly converted to an unsigned integer type and causes pointer
      arithmetic overflow. It happens to be harmless for most targets since
      overflowing would wrap the result to desired value, but it's still
      coincidental and undefined behavior. Furthermore, it causes real
      damage to the wasm backend, given clang-20 will emit invalid wasm code
      that crashes at run-time for this kind of C code! (see
      https://github.com/llvm/llvm-project/issues/108770)
      
      The fix here is adding some explicit casts to ensure we always use the
      signed `ptrdiff_t` type as right hand operand of pointer arithmetic.
      
      (cherry picked from commit 5bcfefd5)
      (cherry picked from commit 990d79a0)
      (cherry picked from commit 213428e4)
      1d6b4ce9
    • Cheng Shao's avatar
      testsuite: bump T17572 timeout · c4eda540
      Cheng Shao authored
      (cherry picked from commit 94673d41)
      (cherry picked from commit f13a2942)
      (cherry picked from commit 97551107)
      c4eda540
    • Cheng Shao's avatar
      ci: update wasm jobs configuration · 12eecca5
      Cheng Shao authored
      This commit bumps ci-image revision to use updated wasm toolchain, and
      use host_fully_static instead of fully_static for wasm jobs so to
      ensure wasm shared libraries can be properly built.
      
      (cherry picked from commit 5043507c)
      (cherry picked from commit 0ae9f0d5)
      (cherry picked from commit 91fe5d97)
      12eecca5
    • Cheng Shao's avatar
      hadrian: add the host_fully_static flavour transformer · b107205e
      Cheng Shao authored
      This commit adds the host_fully_static flavour transformer to hadrian,
      which ensures stage0 is fully statically linked while still permitting
      stage1 libdir to contain shared libraries. This is intended to be used
      by the wasm backend to build portable linux bindists that contain wasm
      shared libraries.
      
      (cherry picked from commit b45080a3)
      (cherry picked from commit 91c0dbd4)
      (cherry picked from commit e077d581)
      b107205e
    • Cheng Shao's avatar
      hadrian: disable internal-interpreter of ghc library when cross compiling · 49d64e92
      Cheng Shao authored
      This commit disable the internal-interpreter flag of ghc library when
      cross compiling, only external interpreter works in such cases.
      
      (cherry picked from commit f232c872)
      (cherry picked from commit 4e7d0cee)
      (cherry picked from commit 624335b2)
      49d64e92
    • Cheng Shao's avatar
      rts: fix conflicting StgRun definitions on wasm · b5bec595
      Cheng Shao authored
      This commit fixes conflicting StgRun definition when building dynamic
      ways of RTS for wasm in unregisterised mode.
      
      (cherry picked from commit bef94bde)
      (cherry picked from commit 6f844296)
      (cherry picked from commit e7806b12)
      b5bec595
    • Cheng Shao's avatar
      rts: don't build predefined GloblRegs for wasm PIC mode · 977986d9
      Cheng Shao authored
      This commit wraps the predefined GlobalRegs in Wasm.S under a CPP
      guard to prevent building for PIC mode. When building dynamic ways of
      RTS, the wasm globals that represent STG GlobalRegs will be created
      and supplied by dyld.mjs. The current wasm dylink convention doesn't
      properly support exporting relocatable wasm globals at all, any wasm
      global exported by a .so is assumed to be a GOT.mem entry.
      
      (cherry picked from commit 98a32ec5)
      (cherry picked from commit cc67ef51)
      (cherry picked from commit 49d340a6)
      977986d9
    • Cheng Shao's avatar
      rts: drop interpretBCO support from non-dyn ways on wasm · 4c765f92
      Cheng Shao authored
      This commit drops interpretBCO support from non dynamic rts ways on
      wasm. The bytecode interpreter is only useful when the RTS linker also
      works, and on wasm it only works for dynamic ways anyway. An
      additional benefit of dropping interpretBCO is reduction in code size
      of linked wasm modules, especially since interpretBCO references
      ffi_call which is an auto-generated large function in libffi-wasm and
      unused by most user applications.
      
      (cherry picked from commit 90a35c41)
      (cherry picked from commit 7a16cf7c)
      (cherry picked from commit 5fcee705)
      4c765f92
    • Cheng Shao's avatar
      ghci: use plain malloc for mkConInfoTable on non-TNTC platforms · 9adf1a0e
      Cheng Shao authored
      This patch avoids using mmap() to allocate executable memory for
      mkConInfoTable on platforms without tables-next-to-code, see added
      comment for explanation.
      
      (cherry picked from commit 839ac52e)
      (cherry picked from commit e54e3335)
      (cherry picked from commit 23cab8a1)
      9adf1a0e
    • Cheng Shao's avatar
      Drop obsolete libffi Makefile · 0868f1d5
      Cheng Shao authored
      This patch drops obsolete libffi Makefile from the tree, given it's
      completely unused since removal of make build system in !7094.
      
      (cherry picked from commit 3fe843c7)
      (cherry picked from commit 81ddb1e7)
      (cherry picked from commit cde02d8d)
      0868f1d5
    • Cheng Shao's avatar
      hadrian: remove unused ghciWithDebugger field from flavour config · 530c5f5c
      Cheng Shao authored
      This patch removes the ghciWithDebugger field from flavour config
      since it's actually not used anywhere.
      
      (cherry picked from commit c6e5fd3d)
      (cherry picked from commit 022d7565)
      (cherry picked from commit f8c17232)
      530c5f5c
    • Cheng Shao's avatar
      git: remove a.out and include it in .gitignore · 0be6abc7
      Cheng Shao authored
      a.out is a configure script byproduct. It was mistakenly checked into
      the tree in !13118. This patch removes it, and include it in
      .gitignore to prevent a similar error in the future.
      
      (cherry picked from commit f0408eeb)
      (cherry picked from commit 8abb0f19)
      (cherry picked from commit 1e852126)
      0be6abc7
    • Cheng Shao's avatar
      ghci: fix isMinTTY.h casing for Windows targets · 0a1f180e
      Cheng Shao authored
      This commit fixes isMinTTY.h casing in isMinTTY.c that's compiled for
      Windows targets. While this looks harmless given Windows filesystems
      are case-insensitive by default, it does cause a compilation warning
      with recent versions of clang, so we might as well fix the casing:
      
      ```
      driver\ghci\isMinTTY.c:10:10: error:
           warning: non-portable path to file '"isMinTTY.h"'; specified path differs in case from file name on disk [-Wnonportable-include-path]
         |
      10 | #include "isMINTTY.h"
         |          ^
      
       #include "isMINTTY.h"
               ^~~~~~~~~~~~
               "isMinTTY.h"
      1 warning generated.
      ```
      
      (cherry picked from commit 3a145315)
      (cherry picked from commit 7bcc3dc6)
      (cherry picked from commit 244fa5a2)
      0a1f180e
    • Cheng Shao's avatar
      testsuite: remove undesired -fasm flag from test ways · 882b6d16
      Cheng Shao authored
      This patch removes the -fasm flag from test ways, except ways like
      optasm that explicitly state they are meant to be compiled with NCG
      backend. Most test ways should use the default codegen backend, and
      the precense of -fasm can cause stderr mismatches like this when GHC
      is configured with the unregisterised backend:
      
      ```
      --- /dev/null
      +++ /tmp/ghctest-3hydwldj/test   spaces/testsuite/tests/profiling/should_compile/prof-late-cc.run/prof-late-cc.comp.stderr.normalised
      @@ -0,0 +1,2 @@
      +when making flags consistent: warning: [GHC-74335] [-Winconsistent-flags (in -Wdefault)]
      +    Target platform uses unregisterised ABI, so compiling via C
      *** unexpected failure for prof-late-cc(prof_no_auto)
      ```
      
      This has been breaking the wasm unreg nightly job since !12595 landed.
      
      (cherry picked from commit 88488847)
      (cherry picked from commit f603ac9c)
      (cherry picked from commit 4977e2a6)
      882b6d16
    • Cheng Shao's avatar
      testsuite: bump T17572 timeout on wasm32 · 895eec84
      Cheng Shao authored
      (cherry picked from commit 64fba310)
      (cherry picked from commit b35707a9)
      (cherry picked from commit ead1c3cc)
      895eec84
    • Cheng Shao's avatar
      rts: use page sized mblocks on wasm · a553126f
      Cheng Shao authored
      This patch changes mblock size to page size on wasm. It allows us to
      simplify our wasi-libc fork, makes it much easier to test third party
      libc allocators like emmalloc/mimalloc, as well as experimenting with
      threaded RTS in wasm.
      
      (cherry picked from commit 558353f4)
      (cherry picked from commit f3ea9fb8)
      (cherry picked from commit f747805f)
      a553126f
    • Cheng Shao's avatar
      rts: cleanup inlining logic · b770dd4b
      Cheng Shao authored
      This patch removes pre-C11 legacy code paths related to
      INLINE_HEADER/STATIC_INLINE/EXTERN_INLINE macros, ensure EXTERN_INLINE
      is treated as static inline in most cases (fixes #24945), and also
      corrects the comments accordingly.
      
      (cherry picked from commit 35a64220)
      (cherry picked from commit 241f401d)
      (cherry picked from commit 562d9ad7)
      b770dd4b
    • Cheng Shao's avatar
      testsuite: skip objc-hi/objcxx-hi when cross compiling · f2b3336c
      Cheng Shao authored
      objc-hi/objcxx-hi should be skipped when cross compiling. The existing
      opsys('darwin') predicate only asserts the host system is darwin but
      tells us nothing about the target, hence the oversight.
      
      (cherry picked from commit 595c0894)
      (cherry picked from commit 5273d3d0)
      (cherry picked from commit 6babf56f)
      f2b3336c
    • Cheng Shao's avatar
      testsuite: bump T7653 timeout for wasm · 4ff8137a
      Cheng Shao authored
      (cherry picked from commit 2eee65e1)
      (cherry picked from commit 3f7b718f)
      (cherry picked from commit 77cc78eb)
      4ff8137a
    • Cheng Shao's avatar
      testsuite: mark T7773 as fragile on wasm · b53727b2
      Cheng Shao authored
      (cherry picked from commit ae50a8eb)
      (cherry picked from commit b7e93bc9)
      (cherry picked from commit f2388ebc)
      b53727b2
    • Cheng Shao's avatar
      hadrian: build in-tree GMP with malloc-notreentrant on wasm32 · 35446535
      Cheng Shao authored
      This patch makes hadrian build in-tree GMP with the
      --enable-alloca=malloc-notreentrant configure option. We will only
      need malloc-reentrant when we have threaded RTS and SMP support on
      wasm32, which will take some time to happen, before which we should
      use malloc-notreentrant to avoid undesired runtime overhead.
      
      (cherry picked from commit 06277d56)
      (cherry picked from commit 0f9a8aaf)
      (cherry picked from commit 3c4f945a)
      35446535
    • Cheng Shao's avatar
      hadrian: disable in-tree gmp fft code path for wasm32 · d003eaa5
      Cheng Shao authored
      This patch disables in-tree GMP FFT code paths for wasm32 target in
      order to give up some performance of multiplying very large operands
      in exchange for reduced code size.
      
      (cherry picked from commit 1a32f828)
      (cherry picked from commit 097ea6e2)
      (cherry picked from commit 0dac58e1)
      d003eaa5
    • Cheng Shao's avatar
      hadrian: disable PIC for in-tree GMP on wasm32 · 1a5e5db5
      Cheng Shao authored
      This patch disables PIC for in-tree GMP on wasm32 target. Enabling PIC
      unconditionally adds undesired code size and runtime overhead for
      wasm32.
      
      (cherry picked from commit f9c1ae12)
      (cherry picked from commit 5f728fc4)
      (cherry picked from commit f45b02a8)
      1a5e5db5
    • Cheng Shao's avatar
      compiler: fix -ddump-cmm-raw when compiling .cmm · 7062add8
      Cheng Shao authored
      This patch fixes missing -ddump-cmm-raw output when compiling .cmm,
      which is useful for debugging cmm related codegen issues.
      
      (cherry picked from commit 6346c669)
      (cherry picked from commit e5a1dd43)
      (cherry picked from commit 0ddc87c4)
      7062add8
    • Cheng Shao's avatar
      hadrian: handle findExecutable "" gracefully · 5dc618db
      Cheng Shao authored
      hadrian may invoke findExecutable "" at run-time due to a certain
      program is not found by configure script. Which is fine and
      findExecutable is supposed to return Nothing in this case. However, on
      Windows there's a directory bug that throws an exception (see
      https://github.com/haskell/directory/issues/180), so we might as well
      use a wrapper for findExecutable and handle exceptions gracefully.
      
      (cherry picked from commit 1e5752f6)
      (cherry picked from commit 78150bfc)
      (cherry picked from commit 10a74dcd)
      5dc618db
    • Cheng Shao's avatar
      utils: add hie.yaml config file for ghc-config · 3f4b6818
      Cheng Shao authored
      Add hie.yaml to ghc-config project directory so it can be edited using
      HLS.
      
      (cherry picked from commit 7eda4bd2)
      (cherry picked from commit ed81a875)
      (cherry picked from commit 9108734a)
      3f4b6818
    • Cheng Shao's avatar
      compiler: remove ArchWasm32 special case in cmmDoCmmSwitchPlans · ba99db26
      Cheng Shao authored
      This patch removes special consideration for ArchWasm32 in
      cmmDoCmmSwitchPlans, which means the compiler will now disable
      cmmImplementSwitchPlans for wasm unreg backend, just like unreg
      backend of other targets. We enabled it in the past to workaround some
      compile-time panic in older versions of LLVM, but those panics are no
      longer present, hence no need to keep this workaround.
      
      (cherry picked from commit bf0737c0)
      (cherry picked from commit 8bd28cf2)
      (cherry picked from commit 2e15c41c)
      ba99db26
    • Cheng Shao's avatar
      driver: build C/C++ with -ffunction-sections -fdata-sections when split sections is enabled · 13a2b529
      Cheng Shao authored
      When -fsplit-sections is passed to GHC, pass -ffunction-sections
      -fdata-sections to gcc/clang when building C/C++. Previously,
      -fsplit-sections was only respected by the NCG/LLVM backends, but not
      the unregisterised backend; the GHC driver did not pass
      -fdata-sections and -ffunction-sections to the C compiler, which
      resulted in excessive executable sizes.
      
      Fixes #23381.
      
      -------------------------
      Metric Decrease:
          size_hello_artifact
          size_hello_unicode
      -------------------------
      
      (cherry picked from commit 02b1f91e)
      (cherry picked from commit 74cdf564)
      (cherry picked from commit 03da9015)
      13a2b529
Loading