From da403dff1f0db0ab09c10863fd075204bc8e1f08 Mon Sep 17 00:00:00 2001
From: Edsko de Vries <edsko@well-typed.com>
Date: Mon, 2 May 2016 16:46:59 +0800
Subject: [PATCH] Don't ignore 206 response in plain-http transport
The plainHttpTransport implementation saved the resulting file only when the
server responded with 200 OK, thus ignoring the payload from the server when
the server responded with a 206 Partial Content. This was causing incremental
updates through hackage-security to fail (it wouldn't fail fatally;
hackage-security would notice the invalid timestamp and download the whole
thing instead, but of course this means we're not actually getting any
incremental behaviour).
---
cabal-install/Distribution/Client/HttpUtils.hs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cabal-install/Distribution/Client/HttpUtils.hs b/cabal-install/Distribution/Client/HttpUtils.hs
index 5e116343d8..092d8164f9 100644
--- a/cabal-install/Distribution/Client/HttpUtils.hs
+++ b/cabal-install/Distribution/Client/HttpUtils.hs
@@ -635,7 +635,7 @@ plainHttpTransport =
(_, resp) <- cabalBrowse verbosity Nothing (request req)
let code = convertRspCode (rspCode resp)
etag' = lookupHeader HdrETag (rspHeaders resp)
- when (code==200) $
+ when (code==200 || code==206) $
writeFileAtomic destPath $ rspBody resp
return (code, etag')
--
GitLab