Skip to content
Snippets Groups Projects

Improve information regarding what the scripts do

Merged Julian Ospald requested to merge www-improve into master
1 unresolved thread

Alternative to !191 (closed)

@rae

This puts a link to the bootstrap script that opens in a new tab when clicked. The bootstrap script will then have a descriptive comment.


Screenshot_2021-09-29_11-38-39

Screenshot_2021-09-29_11-38-59

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • This looks great -- much better than my !191 (closed), which I will close. Thank you.

      I haven't used Windows in some time, but why is the Windows installation non-interactive by default while the other installations are interactive by default? Perhaps it's the right choice, but it surprises me to see a difference here, and I'm not sure that Windows users will know how to run it with 'Interactive $true' to get the interactive behavior. That said, all this patch does it document what's happening, which is unquestionably an improvement.

    • The command-line you copy paste from ghcup website is interactive for both linux and windows. Just the script itself isn't by default. This is a legacy leftover of the Haskell Foundation complaining about "too many questions". Since the arguments are effectively API, changing it will break CI (including the official Github action images). So we're stuck with it.

      Edited by Julian Ospald
    • Please register or sign in to reply
  • I was going to click Approve, but the button isn't there. In any case, I henceforth Approve this MR.

    :tada:

  • Richard Eisenberg mentioned in merge request !191 (closed)

    mentioned in merge request !191 (closed)

  • It really looks great (and that not being a UX expert! :wink:)

  • merged

Please register or sign in to reply
Loading