Skip to content
Snippets Groups Projects

Darwin xz flag fix

Merged toonn requested to merge toonn/ghcup:darwin-xz into master
1 unresolved thread

The gzip flag z was being passed to tar on Mac OS for decompression of xz archives. This fixes #119 (closed).

I took the liberty to include a commit that drops dashes from the flags passed to tar for other cases, rationale being it only increases compatibility. If anyone objects I can easily drop or revert that commit.

Edited by toonn

Merge request reports

Pipeline #10729 passed

Pipeline passed for d2892396 on toonn:darwin-xz

Merged by Julian OspaldJulian Ospald 5 years ago (Oct 3, 2019 8:37am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
1041 debug_message "tar xf \"${filename}\""
1042 ( tar xf "${filename}" ) || die "unpacking failed!"
1043 1043 else
1044 1044 debug_message "xz -cd \"${filename}\" | tar -xf -"
1045 ( xz -cd "${filename}" | tar -xf - ; ) || die "unpacking failed!"
1045 ( xz -cd "${filename}" | tar xf - ; ) || die "unpacking failed!"
1046 1046 fi
1047 1047 ;;
1048 1048 gz)
1049 1049 debug_message "gzip -cd \"${filename}\" | tar -xf -"
1050 ( gzip -cd "${filename}" | tar -xf - ; ) || die "unpacking failed!"
1050 ( gzip -cd "${filename}" | tar xf - ; ) || die "unpacking failed!"
1051 1051 ;;
1052 1052 tar)
1053 edo tar -xf "${filename}"
1053 edo tar xf "${filename}"
  • toonn mentioned in issue #119 (closed)

    mentioned in issue #119 (closed)

  • merged

  • Please register or sign in to reply
    Loading