1. 26 Feb, 2020 18 commits
  2. 25 Feb, 2020 3 commits
  3. 24 Feb, 2020 4 commits
    • Ben Gamari's avatar
      Bump directory submodule to 1.3.6.0 · 84dd9610
      Ben Gamari authored and  Marge Bot's avatar Marge Bot committed
      84dd9610
    • Ben Gamari's avatar
      users-guide: Drop old release notes · e3f17413
      Ben Gamari authored and  Marge Bot's avatar Marge Bot committed
      e3f17413
    • Ben Gamari's avatar
      users-guide: Shuffle text · 5aa6c188
      Ben Gamari authored and  Marge Bot's avatar Marge Bot committed
      5aa6c188
    • Vladislav Zavialov's avatar
      Remove Ord SrcLoc, Ord SrcSpan · 26e8fff3
      Vladislav Zavialov authored and  Marge Bot's avatar Marge Bot committed
      Before this patch, GHC relied on Ord SrcSpan to identify source elements, by
      using SrcSpan as Map keys:
      
      	blackList :: Map SrcSpan ()      -- compiler/GHC/HsToCore/Coverage.hs
      	instanceMap :: Map SrcSpan Name  -- compiler/GHC/HsToCore/Docs.hs
      
      Firstly, this design is not valid in presence of UnhelpfulSpan, as it
      distinguishes between  UnhelpfulSpan "X"  and  UnhelpfulSpan "Y", but those
      strings are messages for the user, unfit to serve as identifiers for source
      elements.
      
      Secondly, this design made it hard to extend SrcSpan with additional data.
      Recall that the definition of SrcSpan is:
      
      	data SrcSpan =
      	    RealSrcSpan !RealSrcSpan
      	  | UnhelpfulSpan !FastString
      
      Say we want to extend the RealSrcSpan constructor with additional information:
      
      	data SrcSpan =
      	    RealSrcSpan !RealSrcSpan !AdditionalInformation
      	  | UnhelpfulSpan !FastString
      
      	getAdditionalInformation :: SrcSpan -> AdditionalInformation
      	getAdditionalInformation (RealSrcSpan _ a) = a
      
      Now, in order for  Map S...
      26e8fff3
  4. 23 Feb, 2020 4 commits
  5. 22 Feb, 2020 5 commits
    • Sylvain Henry's avatar
      Hadrian: `docs` rule needs `configure` (#17840) · 9d094111
      Sylvain Henry authored and  Marge Bot's avatar Marge Bot committed
      9d094111
    • Sylvain Henry's avatar
      Modules: Driver (#13009) · 240f5bf6
      Sylvain Henry authored and  Marge Bot's avatar Marge Bot committed
      submodule updates: nofib, haddock
      240f5bf6
    • Vladislav Zavialov's avatar
      Parser API annotations: RealSrcLoc · be7068a6
      Vladislav Zavialov authored and  Marge Bot's avatar Marge Bot committed
      During parsing, GHC collects lexical information about AST nodes and
      stores it in a map. It is needed to faithfully restore original source
      code, e.g. compare these expressions:
      
      	a =  b
      	a  = b
      
      The position of the equality sign is not recorded in the AST, so it must
      be stored elsewhere.
      
      This system is described in Note [Api annotations].
      
      Before this patch, the mapping was represented by:
      
      	Map (SrcSpan, AnnKeywordId) SrcSpan
      
      After this patch, the mapping is represented by:
      
      	Map (RealSrcSpan, AnnKeywordId) RealSrcSpan
      
      The motivation behind this change is to avoid using the Ord SrcSpan
      instance (required by Map here), as it interferes with #17632 (see the
      discussion there).
      
      SrcSpan is isomorphic to  Either String RealSrcSpan,  but we shouldn't
      use those strings as Map keys. Those strings are intended as hints to
      the user, e.g. "<interactive>" or "<compiler-generated code>", so they
      are not a valid way to identify nodes in the source code.
      be7068a6
    • Matthew Pickering's avatar
      TH: wrapGenSyns, don't split the element type too much · 0482f58a
      Matthew Pickering authored and  Marge Bot's avatar Marge Bot committed
      The invariant which allowed the pervious method of splitting the type of
      the body to find the type of the elements didn't work in the new
      overloaded quotation world as the type can be something like
      `WriterT () m a` rather than `Q a` like before.
      
      Fixes #17839
      0482f58a
    • Matthew Pickering's avatar
      Special case `mkTyConApp liftedTypeKind []` · 0a4c89b2
      Matthew Pickering authored and  Marge Bot's avatar Marge Bot committed
      We really need to make sure that these are shared because otherwise GHC
      will allocate thousands of identical `TyConApp` nodes.
      
      See #17292
      
      -------------------------
      Metric Decrease:
          haddock.Cabal
          T14683
      -------------------------
      0a4c89b2
  6. 21 Feb, 2020 6 commits