1. 09 Jan, 2019 2 commits
    • Matt Renaud's avatar
      Add tests exercising new -Werror behaviour with DEPRECATED symbols. · 37d56f58
      Matt Renaud authored
      - When only -Werror is specified, use of DEPRECATED symbols will still
        successfully compile, but with warnings.
      - Use of -Werror=deprecations will cause a compile failure when
        DEPRECATED symbols are used.
      37d56f58
    • Matt Renaud's avatar
      Fix failing unit tests. · 71b73094
      Matt Renaud authored
      Some fixes due to reported flag changes in stderr output from -Wdeprecations to
      -Wwarnings-deprecations (expected).
      
      Other changes were due to incorrectly including deprecations warnings when
      -fno-warn-deprecations were set because in RsEnv and RnName it checked for
      any of the flags being, regardless of if the warning came from use of
      WARNING or DEPRECATED. A new function has been added to DynFlags.hs which
      verifies that the "deprecation type" matches the set of enabled warning
      flags (deprecationTypeMatchesFlag).
      
      - overloadedrecflds/should_fail/overloadedrecfldsfail11.run  overloadedrecfldsfail11 [stderr mismatch] (normal)
          FIXED: Use of a overloaded record field marked with WARNING should trigger
          -Wwarnings-deprecations instead of -Wdeprecations.
      
      - overloadedrecflds/should_fail/overloadedrecfldsfail12.run  overloadedrecfldsfail12 [stderr mismatch] (normal)
          FIXED: Use of a symbol with WARNING should trigger -Wwarnings-deprecations instead of -Wdeprecations.
      
      - rename/should_compile/rn066.run                            rn066 [stderr mismatch] (normal)
          FIXED: Use of a symbol with WARNING should trigger -Wwarnings-deprecations instead of -Wdeprecations.
      
      - safeHaskell/unsafeLibs/GoodImport03.run                    GoodImport03 [stderr mismatch] (normal)
          FIXED: Check for WARNING/DEPRECATION when adding warnings and match with flags.
      
      - typecheck/should_compile/tc223.run                         tc223 [stderr mismatch] (normal)
          FIXED: Check for WARNING/DEPRECATION when adding warnings and match with flags.
      71b73094
  2. 08 Jan, 2019 1 commit
    • Matt Renaud's avatar
      Don't treat use of DEPRECATED APIs as errors under -Werror. · 02bdf026
      Matt Renaud authored
      - Differentiates between WARNING and DEPRECATED pragmas at the
        warning flag level (DynFlags.hs > WarningFlag.Opt_WarnDeprecations).
      - The -Wdeprecations flag uses the new Opt_WarnDeprecations flag
        value instead of the Opt_WarnWarningsDeprecations value used by
        the -Wwarnings-deprecations flag.
      - The Opt_WarnDeprecations flag is removed from the set of flags
        that are treated as fatal errors by default under -Werror.
      02bdf026
  3. 06 Jan, 2019 10 commits
    • Zejun Wu's avatar
      Hadrian: merge sections in profiling _p.a to .p_o for ghci · 9ea8dcea
      Zejun Wu authored
      This is the hadrain version of {D5169}
      
      * We build squashed .o and .p_o for ghci when `dynamicGhcPrograms` is
      `False`
      * We no longer build them for rts as ghci never loads it
      
      we need https://github.com/haskell/cabal/pull/5592 for cabal to copy
      the built `.p_o` file.
      
      Test Plan:
      ```
      $ grep dynamicGhc hadrian/UserSettings.hs
        , dynamicGhcPrograms = return False
      $ touch ...
      $ hadrian/build.sh --flavour=user -j --digest-or
      $ find _build/stage1/libraries/ -name 'HS*-*.*o' | wc
           62      62    3664
      ```
      
      ```
      $ grep -C3 dynamicGhc hadrian/UserSettings.hs
      userFlavour :: Flavour
      userFlavour = performanceFlavour
        { name = "user"
        , dynamicGhcPrograms = return False
        }
      $ hadrian/build.sh -j --flavour=user test --verbose
      Unexpected results from:
      TEST="T3807 T9208 T9293 annth_make ghci057 haddock.Cabal haddock.base
      haddock.compiler"
      
      SUMMARY for test run started at Wed Dec  5 17:45:39 2018 PST
       0:03:16 spent to go through
          6708 total tests, which gave rise to
         26015 test cases, of which
         19290 were skipped
      
            29 had missing libraries
          6600 expected passes
            88 expected failures
      
             3 caused framework failures
             0 caused framework warnings
             1 unexpected passes
             7 unexpected failures
             0 unexpected stat failures
      $ find _build -name 'HSbase*.*o'
      _build/stage1/lib/x86_64-linux-ghc-8.7.20181204/base-4.12.0.0/HSbase-4.1
      2.0.0.o
      _build/stage1/lib/x86_64-linux-ghc-8.7.20181204/base-4.12.0.0/HSbase-4.1
      2.0.0.p_o
      _build/stage1/libraries/base/build/HSbase-4.12.0.0.o
      _build/stage1/libraries/base/build/HSbase-4.12.0.0.p_o
      ```
      
      Reviewers: bgamari, simonmar, snowleopard
      
      Reviewed By: snowleopard
      
      Subscribers: alpmestan, rwbarton, carter
      
      GHC Trac Issues: #15779
      
      Differential Revision: https://phabricator.haskell.org/D5270
      9ea8dcea
    • Ryan Scott's avatar
      bbd58fb5
    • Zejun Wu's avatar
      Fix bindist for ghci library · 3fb726d0
      Zejun Wu authored
      Summary:
      https://phabricator.haskell.org/D5169 built libghci for both vanilla way
      and profiling way. We need to include both in the bindist list so they
      will be installed.
      
      Test Plan:
      ```
      $ grep '^BuildFlavour' mk/build.mk
      BuildFlavour=perf
      $ make test_bindist
      $ grep HSghc-prim bindist-list.uniq
      ghc-8.7.20190101/libraries/ghc-prim/dist-install/build/HSghc-prim-0.5.3.o
      ghc-8.7.20190101/libraries/ghc-prim/dist-install/build/HSghc-prim-0.5.3.p_o
      ghc-8.7.20190101/libraries/ghc-prim/dist-install/build/libHSghc-prim-0.5.3.a
      ghc-8.7.20190101/libraries/ghc-prim/dist-install/build/libHSghc-prim-0.5.3-ghc8.7.20190101.so
      ghc-8.7.20190101/libraries/ghc-prim/dist-install/build/libHSghc-prim-0.5.3_p.a
      ```
      3fb726d0
    • Ben Gamari's avatar
      make: Silence some xelatex output · 3a509d29
      Ben Gamari authored
      Currently build logs from GitLab CI around around 7 megabytes each. Of this,
      around 2 megabytes is latex output. This is quite silly as essentially all of
      this output is unresolved references in the early latex iterations.
      Here we silence this output.
      
      However, to make sure that we don't silence errors we allow each xelatex
      invocation besides the last to fail.
      3a509d29
    • Adam Sandberg Eriksson's avatar
      Remove OPTIONS_HADDOCK hide in favour for not-home · 24b39ce5
      Adam Sandberg Eriksson authored
      GHC Trac Issues: #15447
      24b39ce5
    • Ben Gamari's avatar
      gitlab-ci: Try reenabling PDF documentation on Darwin · 66b88ddd
      Ben Gamari authored
      Carter says that the builder issues have now been sorted.
      66b88ddd
    • Sven Tennie's avatar
      Add entry for #16031 to base/changelog.md · 0ff42f3f
      Sven Tennie authored
      0ff42f3f
    • Sven Tennie's avatar
      Fix precedence handling for Data.Fixed's Show instance (#16031) · 01b60b0e
      Sven Tennie authored
      Use `showsPrec` instead of `show` to respect the precedence of the surrounding
      context.
      01b60b0e
    • chessai's avatar
      Add -Wmissing-deriving-strategies · c121e33f
      chessai authored
      Warn users when -XDerivingStrategies is enabled but not used, at each
      potential use site.
      
      add -Wmissing-deriving-strategies
      
      Reviewers: bgamari, RyanGlScott
      
      Subscribers: andrewthad, rwbarton, carter
      
      GHC Trac Issues: #15798
      
      Differential Revision: https://phabricator.haskell.org/D5451
      c121e33f
    • Zejun Wu's avatar
      Respect prompt in GhciSettings · 08b8ea2f
      Zejun Wu authored
      Summary:
      This was broken when PromptFunction was introduced that the settings are
      ignored and default values are always used.
      
      Test Plan: ./validate
      08b8ea2f
  4. 05 Jan, 2019 2 commits
  5. 04 Jan, 2019 2 commits
  6. 03 Jan, 2019 3 commits
    • My Nguyen's avatar
      Visible kind application · 17bd1635
      My Nguyen authored
      Summary:
      This patch implements visible kind application (GHC Proposal 15/#12045), as well as #15360 and #15362.
      It also refactors unnamed wildcard handling, and requires that type equations in type families in Template Haskell be
      written with full type on lhs. PartialTypeSignatures are on and warnings are off automatically with visible kind
      application, just like in term-level.
      
      There are a few remaining issues with this patch, as documented in
      ticket #16082.
      
      Includes a submodule update for Haddock.
      
      Test Plan: Tests T12045a/b/c/TH1/TH2, T15362, T15592a
      
      Reviewers: simonpj, goldfire, bgamari, alanz, RyanGlScott, Iceland_jack
      
      Subscribers: ningning, Iceland_jack, RyanGlScott, int-index, rwbarton, mpickering, carter
      
      GHC Trac Issues: `#12045`, `#15362`, `#15592`, `#15788`, `#15793`, `#15795`, `#15797`, `#15799`, `#15801`, `#15807`, `#15816`
      
      Differential Revision: https://phabricator.haskell.org/D5229
      17bd1635
    • Ömer Sinan Ağacan's avatar
    • Takenobu Tani's avatar
      stg-spec: Modify `.lhs` to `.hs` · 05cd2319
      Takenobu Tani authored
      Modify old filename `.lhs` to `.hs` in the following file:
      
        * docs/stg-spec/StgSyn.ott
      
      Since PDF has not been registered in the past, I have not committed generated PDF(`stg-spec.pdf`).
      
      [ci skip]
      05cd2319
  7. 02 Jan, 2019 2 commits
  8. 01 Jan, 2019 2 commits
  9. 30 Dec, 2018 2 commits
  10. 29 Dec, 2018 3 commits
  11. 28 Dec, 2018 1 commit
  12. 27 Dec, 2018 2 commits
  13. 26 Dec, 2018 2 commits
    • Sergei Trofimovich's avatar
      aclocal.m4: drop obsolete -fno-stack-protector · 29ecb520
      Sergei Trofimovich authored
      Summary:
      Initially -fno-stack-protector was added for openbsd specifically for ghc-6.5:
          changeset:f638fdfe (2006)
      and later it was extended to cover osx:
          changeset:c2cd83e7 (2009)
      
      None of the reports hint at exact breakage. I guess both happened
      in -fvia-C mode where GHC's Evil Mangler had a chance to mangle
      stack canaries generated by fstack-protector.
      
      ghc has no evil mangler anymore and the change is not needed
      at least for C codegen.
      
      validated the patch on OpenBSD-6.4. No new failures compared to
      clean master branch.
      Signed-off-by: default avatarSergei Trofimovich <slyfox@gentoo.org>
      
      Test Plan: validated on OpenBSD
      
      Reviewers: bgamari
      
      Subscribers: rwbarton, erikd, carter
      
      GHC Trac Issues: #16046
      
      Differential Revision: https://phabricator.haskell.org/D5465
      29ecb520
    • Ben Gamari's avatar
      gitlab-ci: Try only building Windows in the quick flavour · 942b5019
      Ben Gamari authored
      It seems no matter how many machines I throw at Windows it's constantly behind.
      Perhaps the quick build flavour will be fast enough to allow us to keep until
      while we sort out our toolchain issues (#16084).
      942b5019
  14. 25 Dec, 2018 6 commits