1. 06 Mar, 2018 8 commits
  2. 05 Mar, 2018 5 commits
    • Herbert Valerio Riedel's avatar
      Fixup include of gmp/config.mk to use new location · df7ac37d
      Herbert Valerio Riedel authored
      This wasn't spotted rightaway in
      because the include-site deliberately ignored include-errors as
      a Hack with the justification below:
      > Hack. The file gmp/config.mk doesn't exist yet after running ./configure in
      > the toplevel (ghc) directory. To let some toplevel make commands such as
      > sdist go through, right after ./configure, don't consider this an error.
      This may have contributed to #14891.
    • Simon Peyton Jones's avatar
      Simplify rnLHsInstType · 1c062b79
      Simon Peyton Jones authored
      This patch is preparatory for the main fix for Trac #13324
      Here, we simplify rnLHsInstType so that it does not try
      to figure out the class name.  This turns out to have a good
      (rather than bad) effect on error messages, and it prepares
      the way for the main event.
      Plus, less code!
    • Ryan Scott's avatar
      Fix #14888 by adding more special cases for ArrowT · 6ee831f2
      Ryan Scott authored
      There were previously some situations where `(->)` would
      not be desugared or reified as `ArrowT`, leading to various oddities
      such as those observed in #14888. We now uniformly treat `(->)` as
      `ArrowT` in Template Haskell–world by checking for any tycon that
      has the same name as `(->)`, and converting that to `ArrowT`.
      Test Plan: make test TEST=T14888
      Reviewers: goldfire, bgamari, simonpj
      Reviewed By: goldfire, simonpj
      Subscribers: simonpj, rwbarton, thomie, carter
      GHC Trac Issues: #14888
      Differential Revision: https://phabricator.haskell.org/D4466
    • Simon Peyton Jones's avatar
      Respect Note [The tcType invariant] · 3d252037
      Simon Peyton Jones authored
      I tried to do this with
          commit 0a12d92a
          Author: Simon Peyton Jones <simonpj@microsoft.com>
          Date:   Wed Dec 13 12:53:26 2017 +0000
          Further improvements to well-kinded types
          The typechecker has the invariant that every type should be well-kinded
          as it stands, without zonking.  See Note [The well-kinded type invariant]
          in TcType.
          That invariant was not being upheld, which led to Trac #14174.  I fixed
          part of it, but T14174a showed that there was more.  This patch finishes
          the job.
      But I didn't get it quite right as Trac #14873 showed.
      This patch fixes the problem; although I am still a bit unhappy.
      (See "A worry" in the HsApp case of tc_infer_hs_type.)
    • Simon Peyton Jones's avatar
      Wombling around in Trac #14808 · e7653bc3
      Simon Peyton Jones authored
      Comment:4 in Trac #14808 explains why I'm unhappy with the current
      state of affairs -- at least the lack of documentation.
      This smallpatch does nothing major:
      * adds comments
      * uses existing type synonyms more (notably FreeKiTyVarsWithDups)
      * adds another test case to T14808
  3. 04 Mar, 2018 3 commits
  4. 03 Mar, 2018 1 commit
    • Ryan Scott's avatar
      Parenthesize (() :: Constraint) in argument position · 99c556d2
      Ryan Scott authored
      A simple oversight in the pretty-printer lead to a special
      case for `() :: Constraint` not being parenthesized correctly when
      used in an argument position. Easily fixed with a `maybeParen`.
      Test Plan: make test TEST=T14796
      Reviewers: alanz, goldfire, bgamari, simonpj
      Reviewed By: bgamari, simonpj
      Subscribers: simonpj, rwbarton, thomie, carter
      GHC Trac Issues: #14796
      Differential Revision: https://phabricator.haskell.org/D4408
  5. 02 Mar, 2018 23 commits