Skip to content
  • Tamar Christina's avatar
    Fix ExtraSymbols jump table on Windows. · 2f1017b9
    Tamar Christina authored and Ben Gamari's avatar Ben Gamari committed
    This corrects the `jump islands` calculations for Windows.  The code was
    incorrectly creating a new entry for every `usage` of a symbol instead
    of every used symbol. e.g. if a symbol is used 5 times it used to create
    5 jump islands. This is incorrect and not in line with what the `ELF`
    and `Mach-O` linkers do. Also since we allocate `n` spaces where `n` is
    number of symbols, we would quickly run out of space and abort.
    
    Test Plan: ./validate
    
    Reviewers: simonmar, hvr, erikd, bgamari, austin
    
    Reviewed By: bgamari
    
    Subscribers: thomie, #ghc_windows_task_force
    
    Differential Revision: https://phabricator.haskell.org/D3026
    2f1017b9