• Edward Z. Yang's avatar
    Record full FieldLabel in ifConFields. · 9d17028f
    Edward Z. Yang authored
    Summary:
    The previous implementation tried to be "efficient" by
    storing field names once in IfaceConDecls, and only just
    enough information for us to reconstruct the FieldLabel.
    But this came at a bit of code complexity cost.
    
    This patch undos the optimization, instead storing a full
    FieldLabel at each data constructor.  Consequently, this fixes
    bugs #12699 and #13250.
    Signed-off-by: default avatarEdward Z. Yang <ezyang@cs.stanford.edu>
    
    Test Plan: validate
    
    Reviewers: adamgundry, bgamari, austin
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D3174
    9d17028f
IfaceSyn.hs 77.8 KB