Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
GHC
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Locked Files
Issues
0
Issues
0
List
Boards
Labels
Service Desk
Milestones
Iterations
Merge Requests
0
Merge Requests
0
Requirements
Requirements
List
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Security & Compliance
Security & Compliance
Dependency List
License Compliance
Operations
Operations
Incidents
Environments
Packages & Registries
Packages & Registries
Package Registry
Container Registry
Analytics
Analytics
CI / CD
Code Review
Insights
Issue
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex D
GHC
Commits
7301404d
Commit
7301404d
authored
Jun 21, 2016
by
Gabor Greif
💬
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Typos in comments
parent
ee3bde79
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
5 additions
and
5 deletions
+5
-5
compiler/typecheck/TcBinds.hs
compiler/typecheck/TcBinds.hs
+1
-1
compiler/typecheck/TcPat.hs
compiler/typecheck/TcPat.hs
+1
-1
compiler/typecheck/TcSigs.hs
compiler/typecheck/TcSigs.hs
+1
-1
testsuite/tests/typecheck/should_compile/ExPat.hs
testsuite/tests/typecheck/should_compile/ExPat.hs
+1
-1
testsuite/tests/typecheck/should_compile/ExPatFail.hs
testsuite/tests/typecheck/should_compile/ExPatFail.hs
+1
-1
No files found.
compiler/typecheck/TcBinds.hs
View file @
7301404d
...
...
@@ -1468,7 +1468,7 @@ and suppose t :: T. Which of these pattern bindings are ok?
E3. let { MkT (toInteger -> r) _ = t } in <body>
Well (E1) is clearly wrong bec
ua
se the existential 'a' escapes.
Well (E1) is clearly wrong bec
au
se the existential 'a' escapes.
What type could 'p' possibly have?
But (E2) is fine, despite the existential pattern, because
...
...
compiler/typecheck/TcPat.hs
View file @
7301404d
...
...
@@ -330,7 +330,7 @@ tc_pat penv lpat@(LazyPat pat) pat_ty thing_inside
-- see Note [Hopping the LIE in lazy patterns]
-- Check there are no unlifted types under the lazy pattern
-- This is a very unsatisfactory test. We have to zonk bec
ua
se
-- This is a very unsatisfactory test. We have to zonk bec
au
se
-- the binder-tys are typically just a unification variable,
-- which should by now have been unified... but it might be
-- deferred for the constraint solver...Ugh! Also
...
...
compiler/typecheck/TcSigs.hs
View file @
7301404d
...
...
@@ -90,7 +90,7 @@ especially on value bindings. Here's an overview.
The instantiation does the obvious thing for complete signatures,
but for /partial/ signatures it starts from the HsSyn, so it
has to kind-check it etc: tcHsPartialSigType. It's convenient
to do this at the same time as instantiation, bec
ua
se we can
to do this at the same time as instantiation, bec
au
se we can
make the wildcards into unification variables right away, raather
than somehow quantifying over them. And the "TcLevel" of those
unification variables is correct because we are in tcMonoBinds.
...
...
testsuite/tests/typecheck/should_compile/ExPat.hs
View file @
7301404d
...
...
@@ -7,7 +7,7 @@ data T where
-- c.f. T11700
-- Succeeds bec
ua
se y::Int
-- Succeeds bec
au
se y::Int
f
x
=
let
MkT
_
y
=
x
in
y
...
...
testsuite/tests/typecheck/should_compile/ExPatFail.hs
View file @
7301404d
...
...
@@ -5,7 +5,7 @@ module ExPatFail where
data
T
where
MkT
::
Integral
a
=>
a
->
Int
->
T
-- Fails bec
ua
se y is bound to an existential type
-- Fails bec
au
se y is bound to an existential type
-- Mind you, the error message is pretty terrible
-- c.f. T11700
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment