Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
10
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Open sidebar
Alex D
GHC
Commits
98db754a
Commit
98db754a
authored
Jan 16, 2014
by
Krzysztof Gogolewski
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Typos in comments
parent
59f491a9
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
8 additions
and
8 deletions
+8
-8
compiler/stranal/WwLib.lhs
compiler/stranal/WwLib.lhs
+2
-2
compiler/typecheck/TcDeriv.lhs
compiler/typecheck/TcDeriv.lhs
+1
-1
compiler/typecheck/TcInteract.lhs
compiler/typecheck/TcInteract.lhs
+2
-2
compiler/typecheck/TcRnTypes.lhs
compiler/typecheck/TcRnTypes.lhs
+2
-2
testsuite/tests/indexed-types/should_compile/all.T
testsuite/tests/indexed-types/should_compile/all.T
+1
-1
No files found.
compiler/stranal/WwLib.lhs
View file @
98db754a
...
...
@@ -465,7 +465,7 @@ mkWWstr_one dflags arg
, Just (data_con, inst_tys, inst_con_arg_tys, co)
<- deepSplitProductType_maybe (idType arg)
, cs `equalLength` inst_con_arg_tys
-- See Note [mkWWstr and unsafeCo
r
e]
-- See Note [mkWWstr and unsafeCo
erc
e]
= do { (uniq1:uniqs) <- getUniquesM
; let unpk_args = zipWith mk_ww_local uniqs inst_con_arg_tys
unpk_args_w_ds = zipWithEqual "mkWWstr" set_worker_arg_info unpk_args cs
...
...
@@ -625,7 +625,7 @@ Here CPR will tell you that `foo` returns a () constructor for sure, but trying
to create a worker/wrapper for type `a` obviously fails.
(This was a real example until ee8e792 in libraries/base.)
It does not seem feasi
l
be to avoid all such cases already in the analyser (and
It does not seem feasib
l
e to avoid all such cases already in the analyser (and
after all, the analysis is not really wrong), so we simply do nothing here in
mkWWcpr. But we still want to emit warning with -DDEBUG, to hopefully catch
other cases where something went avoidably wrong.
...
...
compiler/typecheck/TcDeriv.lhs
View file @
98db754a
...
...
@@ -1620,7 +1620,7 @@ Note [Recursive newtypes]
Newtype deriving works fine, even if the newtype is recursive.
e.g. newtype S1 = S1 [T1 ()]
newtype T1 a = T1 (StateT S1 IO a ) deriving( Monad )
Remember, too, that type families are curretly (conservatively) given
Remember, too, that type families are curre
n
tly (conservatively) given
a recursive flag, so this also allows newtype deriving to work
for type famillies.
...
...
compiler/typecheck/TcInteract.lhs
View file @
98db754a
...
...
@@ -1979,7 +1979,7 @@ getCoercibleInst loc ty1 ty2 = do
-- Coercible NT a (see case 4 in [Coercible Instances])
| Just (tc,tyArgs) <- splitTyConApp_maybe ty1,
Just (concTy, ntCo) <- instNewTyConTF_maybe famenv tc tyArgs,
dataConsInScope rdr_env tc -- Do no
o
t look at all tyConsOfTyCon
dataConsInScope rdr_env tc -- Do not look at all tyConsOfTyCon
= do markDataConsAsUsed rdr_env tc
ct_ev <- requestCoercible loc concTy ty2
local_var <- mkSysLocalM (fsLit "coev") $ mkCoerciblePred concTy ty2
...
...
@@ -1991,7 +1991,7 @@ getCoercibleInst loc ty1 ty2 = do
-- Coercible a NT (see case 4 in [Coercible Instances])
| Just (tc,tyArgs) <- splitTyConApp_maybe ty2,
Just (concTy, ntCo) <- instNewTyConTF_maybe famenv tc tyArgs,
dataConsInScope rdr_env tc -- Do no
o
t look at all tyConsOfTyCon
dataConsInScope rdr_env tc -- Do not look at all tyConsOfTyCon
= do markDataConsAsUsed rdr_env tc
ct_ev <- requestCoercible loc ty1 concTy
local_var <- mkSysLocalM (fsLit "coev") $ mkCoerciblePred ty1 concTy
...
...
compiler/typecheck/TcRnTypes.lhs
View file @
98db754a
...
...
@@ -656,7 +656,7 @@ data PromotionErr
| FamDataConPE -- Data constructor for a data family
-- See Note [AFamDataCon: not promoting data family constructors] in TcRnDriver
| RecDataConPE -- Data constructor in a re
u
ursive loop
| RecDataConPE -- Data constructor in a re
c
ursive loop
-- See Note [ARecDataCon: recusion and promoting data constructors] in TcTyClsDecls
| NoDataKinds -- -XDataKinds not enabled
...
...
@@ -781,7 +781,7 @@ data ImportAvails
-- Used
--
-- (a) to help construct the usage information in the interface
-- file; if we import somethi
g
n we need to recompile if the
-- file; if we import somethin
g
we need to recompile if the
-- export version changes
--
-- (b) to specify what child modules to initialise
...
...
testsuite/tests/indexed-types/should_compile/all.T
View file @
98db754a
...
...
@@ -226,7 +226,7 @@ test('T8011',
run_command
,
['
$MAKE -s --no-print-directory T8011
'])
# Marshalling of assoc
at
iated types
# Marshalling of associated types
test
('
T8500
',
normal
,
run_command
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment