Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
GHC
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Locked Files
Issues
0
Issues
0
List
Boards
Labels
Service Desk
Milestones
Iterations
Merge Requests
0
Merge Requests
0
Requirements
Requirements
List
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Security & Compliance
Security & Compliance
Dependency List
License Compliance
Operations
Operations
Incidents
Environments
Packages & Registries
Packages & Registries
Package Registry
Container Registry
Analytics
Analytics
CI / CD
Code Review
Insights
Issue
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex D
GHC
Commits
a8a714ea
Commit
a8a714ea
authored
Jan 05, 2017
by
Gabor Greif
💬
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Typos in comments (and in a test)
parent
7d2e5da6
Changes
14
Hide whitespace changes
Inline
Side-by-side
Showing
14 changed files
with
18 additions
and
18 deletions
+18
-18
compiler/coreSyn/CorePrep.hs
compiler/coreSyn/CorePrep.hs
+1
-1
compiler/simplCore/CallArity.hs
compiler/simplCore/CallArity.hs
+3
-3
compiler/simplCore/SimplUtils.hs
compiler/simplCore/SimplUtils.hs
+1
-1
compiler/simplStg/StgCse.hs
compiler/simplStg/StgCse.hs
+1
-1
compiler/typecheck/TcGenDeriv.hs
compiler/typecheck/TcGenDeriv.hs
+1
-1
compiler/utils/Digraph.hs
compiler/utils/Digraph.hs
+3
-3
libraries/base/Data/Traversable.hs
libraries/base/Data/Traversable.hs
+1
-1
libraries/base/GHC/Event/PSQ.hs
libraries/base/GHC/Event/PSQ.hs
+1
-1
libraries/compact/Data/Compact.hs
libraries/compact/Data/Compact.hs
+1
-1
testsuite/tests/programs/andy_cherry/andy_cherry.stdout
testsuite/tests/programs/andy_cherry/andy_cherry.stdout
+1
-1
testsuite/tests/programs/andy_cherry/mygames.pgn
testsuite/tests/programs/andy_cherry/mygames.pgn
+1
-1
testsuite/tests/simplCore/should_compile/spec-inline.hs
testsuite/tests/simplCore/should_compile/spec-inline.hs
+1
-1
testsuite/tests/stranal/sigs/StrAnalExample.hs
testsuite/tests/stranal/sigs/StrAnalExample.hs
+1
-1
testsuite/tests/typecheck/should_compile/T12734a.hs
testsuite/tests/typecheck/should_compile/T12734a.hs
+1
-1
No files found.
compiler/coreSyn/CorePrep.hs
View file @
a8a714ea
...
...
@@ -563,7 +563,7 @@ cpeRhsE env (Case scrut bndr ty alts)
cvtLitInteger
::
DynFlags
->
Id
->
Maybe
DataCon
->
Integer
->
CoreExpr
-- Here we convert a literal Integer to the low-level
-- represenation. Exactly how we do this depends on the
-- represen
t
ation. Exactly how we do this depends on the
-- library that implements Integer. If it's GMP we
-- use the S# data constructor for small literals.
-- See Note [Integer literals] in Literal
...
...
compiler/simplCore/CallArity.hs
View file @
a8a714ea
...
...
@@ -342,7 +342,7 @@ For a mutually recursive let, we begin by
4. For each variable, we find out the incoming arity and whether it is called
once, based on the the current analysis result. If this differs from the
memoized results, we re-analyse the rhs and update the memoized table.
5. If nothing had to be reanal
i
zed, we are done.
5. If nothing had to be reanal
y
zed, we are done.
Otherwise, repeat from step 3.
...
...
@@ -609,11 +609,11 @@ callArityBind boring_vars ae_body int b@(Rec binds)
|
Just
(
old_called_once
,
old_arity
,
_
)
<-
mbLastRun
,
called_once
==
old_called_once
,
new_arity
==
old_arity
-- No change, no need to re-anal
i
ze
-- No change, no need to re-anal
y
ze
=
(
False
,
(
i
,
mbLastRun
,
rhs
))
|
otherwise
-- We previously anal
i
zed this with a different arity (or not at all)
-- We previously anal
y
zed this with a different arity (or not at all)
=
let
is_thunk
=
not
(
exprIsCheap
rhs
)
-- see note [What is a thunk]
safe_arity
|
is_thunk
=
0
-- See Note [Thunks in recursive groups]
...
...
compiler/simplCore/SimplUtils.hs
View file @
a8a714ea
...
...
@@ -1249,7 +1249,7 @@ ones that are trivial):
* The inliner should inline trivial things at call sites anyway.
* The Id might be exported. We could check for that separately,
but since we aren't going to postInlineUnconditi
no
ally /any/
but since we aren't going to postInlineUnconditi
on
ally /any/
top-level bindings, we don't need to test.
Note [Stable unfoldings and postInlineUnconditionally]
...
...
compiler/simplStg/StgCse.hs
View file @
a8a714ea
...
...
@@ -86,7 +86,7 @@ import Control.Monad( (>=>) )
-- The Trie --
--------------
-- A lookup trie for data constructor appliations, i.e.
-- A lookup trie for data constructor appli
c
ations, i.e.
-- keys of type `(DataCon, [StgArg])`, following the patterns in TrieMap.
data
StgArgMap
a
=
SAM
...
...
compiler/typecheck/TcGenDeriv.hs
View file @
a8a714ea
...
...
@@ -1494,7 +1494,7 @@ Example:
Note that (mkNameG_d "package-name" "ModuleName" "Foo") is equivalent to what
'Foo would be when using the -XTemplateHaskell extension. To make sure that
-XDeriveLift can be used on stage-1 compilers, however, we expli
tic
ly invoke
-XDeriveLift can be used on stage-1 compilers, however, we expli
cit
ly invoke
makeG_d.
-}
...
...
compiler/utils/Digraph.hs
View file @
a8a714ea
...
...
@@ -103,7 +103,7 @@ emptyGraph = Graph (array (1, 0) []) (error "emptyGraph") (const Nothing)
graphFromEdgedVertices
::
ReduceFn
key
payload
->
[
Node
key
payload
]
-- The graph; its ok for the
-- out-list to contain keys which arent
-- out-list to contain keys which aren
'
t
-- a vertex key, they are ignored
->
Graph
(
Node
key
payload
)
graphFromEdgedVertices
_reduceFn
[]
=
emptyGraph
...
...
@@ -122,7 +122,7 @@ graphFromEdgedVertices reduceFn edged_vertices =
graphFromEdgedVerticesOrd
::
Ord
key
=>
[
Node
key
payload
]
-- The graph; its ok for the
-- out-list to contain keys which arent
-- out-list to contain keys which aren
'
t
-- a vertex key, they are ignored
->
Graph
(
Node
key
payload
)
graphFromEdgedVerticesOrd
=
graphFromEdgedVertices
reduceNodesIntoVerticesOrd
...
...
@@ -132,7 +132,7 @@ graphFromEdgedVerticesOrd = graphFromEdgedVertices reduceNodesIntoVerticesOrd
graphFromEdgedVerticesUniq
::
Uniquable
key
=>
[
Node
key
payload
]
-- The graph; its ok for the
-- out-list to contain keys which arent
-- out-list to contain keys which aren
'
t
-- a vertex key, they are ignored
->
Graph
(
Node
key
payload
)
graphFromEdgedVerticesUniq
=
graphFromEdgedVertices
reduceNodesIntoVerticesUniq
...
...
libraries/base/Data/Traversable.hs
View file @
a8a714ea
...
...
@@ -208,7 +208,7 @@ that's all! We get
$fTraversable[]_$cmapM = ...code for traverse on lists...
with NO INLINE pragma! This happens even though 'traverse' had an
INLINE pragma bec
ua
se the author knew it should be inlined pretty
INLINE pragma bec
au
se the author knew it should be inlined pretty
vigorously.
Indeed, it turned out that the rhs of $cmapM was just too big to
...
...
libraries/base/GHC/Event/PSQ.hs
View file @
a8a714ea
...
...
@@ -89,7 +89,7 @@ module GHC.Event.PSQ
)
where
import
GHC.Base
hiding
(
empty
)
import
GHC.Float
()
-- for Show Double insta
s
nce
import
GHC.Float
()
-- for Show Double instance
import
GHC.Num
(
Num
(
..
))
import
GHC.Show
(
Show
(
showsPrec
))
import
GHC.Event.Unique
(
Unique
)
...
...
libraries/compact/Data/Compact.hs
View file @
a8a714ea
...
...
@@ -55,7 +55,7 @@ getCompact (Compact _ obj _) = obj
--
-- If the structure contains any internal sharing, the shared data
-- will be duplicated during the compaction process. Loops if the
-- structure con
s
tains cycles.
-- structure contains cycles.
--
-- The NFData constraint is just to ensure that the object contains no
-- functions, 'compact' does not actually use it. If your object
...
...
testsuite/tests/programs/andy_cherry/andy_cherry.stdout
View file @
a8a714ea
...
...
@@ -7196,7 +7196,7 @@ $$\showboard$$
25
&
Qf3
&
\\
\end{tabular}
}
|
\end{center}
Crude plan of exchanging queens to avoid `acidents`.
Crude plan of exchanging queens to avoid `ac
c
idents`.
|25.~Bb3|
\begin{center}
|
{
\bf
\begin{tabular}
{
rp
{
50pt
}
p
{
50pt
}}
...
...
testsuite/tests/programs/andy_cherry/mygames.pgn
View file @
a8a714ea
...
...
@@ -1313,7 +1313,7 @@ is starting to push home his advantage.}) 19. Kxg2 Bh3+ 20. Kh1 Qg4 (
21. Ne1 Qg5 22. Qe2 Be6 23. Rg3 Qf6 24. Nxe6 {} (24. Nf3 Ne7 25. Nxe6
Qxe6 26. Bb3 Qf6 27. Rag1 {<waw>}) 24... Rxe6 (24... Qxe6 25. Bb3 Qe7
26. Bd5 Rad8 27. Nf3 R8d7 28. Rd1) 25. Qf3 {Crude plan of exchanging
queens to avoid `acidents`.} (25. Bb3) 25... Qe7 26. Bb3 Rf6 27. Qe3 (27.
queens to avoid `ac
c
idents`.} (25. Bb3) 25... Qe7 26. Bb3 Rf6 27. Qe3 (27.
Qg2) 27... Rd8 28. Nc2 Kh7 29. Rag1 g6 30. Rf3 {} 30... Rxf3 (30... Rfd6 {
??} 31. Rxf7+ {Trying to avoid the exchance, but black loses his Queen!
Black actually moved his rook to d6, but before letting it go, spotted
...
...
testsuite/tests/simplCore/should_compile/spec-inline.hs
View file @
a8a714ea
{- This test checks that specialiations can apply inside
{- This test checks that speciali
s
ations can apply inside
wrappers. In particular, the wrapper for 'foo' should
look like
...
...
testsuite/tests/stranal/sigs/StrAnalExample.hs
View file @
a8a714ea
-- Just an example on how to create tests that test the strictness anal
i
zer
-- Just an example on how to create tests that test the strictness anal
y
zer
module
StrAnalExample
where
...
...
testsuite/tests/typecheck/should_compile/T12734a.hs
View file @
a8a714ea
...
...
@@ -93,7 +93,7 @@ test_ghc_err = test_gr @(KT A '[Type] IO)
= Con m (Stack lrs (Layer4 bind))
--> inline lrs
[W] Con m (Stack '[Type] (Layer4 bind))
--> i
sn
tance
--> i
ns
tance
[W] Con m (Stack '[] bind)
--> Monad m
+
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment