Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
GHC
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Locked Files
Issues
0
Issues
0
List
Boards
Labels
Service Desk
Milestones
Iterations
Merge Requests
0
Merge Requests
0
Requirements
Requirements
List
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Security & Compliance
Security & Compliance
Dependency List
License Compliance
Operations
Operations
Incidents
Environments
Packages & Registries
Packages & Registries
Package Registry
Container Registry
Analytics
Analytics
CI / CD
Code Review
Insights
Issue
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex D
GHC
Commits
c65104e1
Commit
c65104e1
authored
Jan 17, 2018
by
Gabor Greif
💬
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Typos in comments
parent
cf2c029c
Changes
12
Hide whitespace changes
Inline
Side-by-side
Showing
12 changed files
with
14 additions
and
14 deletions
+14
-14
compiler/basicTypes/RdrName.hs
compiler/basicTypes/RdrName.hs
+1
-1
compiler/codeGen/StgCmmHeap.hs
compiler/codeGen/StgCmmHeap.hs
+1
-1
compiler/coreSyn/MkCore.hs
compiler/coreSyn/MkCore.hs
+1
-1
compiler/deSugar/Desugar.hs
compiler/deSugar/Desugar.hs
+2
-2
compiler/iface/BinIface.hs
compiler/iface/BinIface.hs
+1
-1
compiler/main/TidyPgm.hs
compiler/main/TidyPgm.hs
+1
-1
compiler/simplCore/CallArity.hs
compiler/simplCore/CallArity.hs
+1
-1
compiler/simplCore/OccurAnal.hs
compiler/simplCore/OccurAnal.hs
+1
-1
compiler/typecheck/TcPatSyn.hs
compiler/typecheck/TcPatSyn.hs
+1
-1
compiler/typecheck/TcSMonad.hs
compiler/typecheck/TcSMonad.hs
+1
-1
compiler/typecheck/TcSimplify.hs
compiler/typecheck/TcSimplify.hs
+1
-1
mk/warnings.mk
mk/warnings.mk
+2
-2
No files found.
compiler/basicTypes/RdrName.hs
View file @
c65104e1
...
...
@@ -1040,7 +1040,7 @@ There are two reasons for shadowing:
hence the `mk_fake-imp_spec` in `shadowName`. See also Note
[Interactively-bound Ids in GHCi] in HscTypes
- Data types also have Extenal Names, like Ghci4.T; but we still want
- Data types also have Exte
r
nal Names, like Ghci4.T; but we still want
'T' to mean the newly-declared 'T', not an old one.
* Nested Template Haskell declaration brackets
...
...
compiler/codeGen/StgCmmHeap.hs
View file @
c65104e1
...
...
@@ -149,7 +149,7 @@ emitSetDynHdr base info_ptr ccs
where
header
::
DynFlags
->
[
CmmExpr
]
header
dflags
=
[
info_ptr
]
++
dynProfHdr
dflags
ccs
-- ToDo
f
: Parallel stuff
-- ToDo: Parallel stuff
-- No ticky header
-- Store the item (expr,off) in base[off]
...
...
compiler/coreSyn/MkCore.hs
View file @
c65104e1
...
...
@@ -337,7 +337,7 @@ We could do one of two things:
* Flatten it out, so that
mkCoreTup [e1] = e1
* Buil
t
a one-tuple (see Note [One-tuples] in TysWiredIn)
* Buil
d
a one-tuple (see Note [One-tuples] in TysWiredIn)
mkCoreTup1 [e1] = Unit e1
We use a suffix "1" to indicate this.
...
...
compiler/deSugar/Desugar.hs
View file @
c65104e1
...
...
@@ -247,7 +247,7 @@ Note [Top-level evidence]
~~~~~~~~~~~~~~~~~~~~~~~~~
Top-level evidence bindings may be mutually recursive with the top-level value
bindings, so we must put those in a Rec. But we can't put them *all* in a Rec
because the occurrence analyser doesn't t
e
ke account of type/coercion variables
because the occurrence analyser doesn't t
a
ke account of type/coercion variables
when computing dependencies.
So we pull out the type/coercion variables (which are in dependency order),
...
...
@@ -544,7 +544,7 @@ about this. For example in Control.Arrow we have
and similar, which will elicit exactly these warnings, and risk never
firing. But it's not clear what to do instead. We could make the
class metho
c
d rules inactive in phase 2, but that would delay when
class method rules inactive in phase 2, but that would delay when
subsequent transformations could fire.
...
...
compiler/iface/BinIface.hs
View file @
c65104e1
...
...
@@ -223,7 +223,7 @@ writeBinIface dflags hi_path mod_iface = do
-- NB. write the dictionary after the symbol table, because
-- writing the symbol table may create more dictionary entries.
-- Write the dictionary pointer at the f
or
nt of the file
-- Write the dictionary pointer at the f
ro
nt of the file
dict_p
<-
tellBin
bh
-- This is where the dictionary will start
putAt
bh
dict_p_p
dict_p
-- Fill in the placeholder
seekBin
bh
dict_p
-- Seek back to the end of the file
...
...
compiler/main/TidyPgm.hs
View file @
c65104e1
...
...
@@ -224,7 +224,7 @@ Plan B: include pragmas, make interfaces
* Step 1: Figure out which Ids are externally visible
See Note [Choosing external Ids]
* Step 2: Gather the extenally visible rules, separately from
* Step 2: Gather the exte
r
nally visible rules, separately from
the top-level bindings.
See Note [Finding external rules]
...
...
compiler/simplCore/CallArity.hs
View file @
c65104e1
...
...
@@ -406,7 +406,7 @@ published papers on Call Arity describe it.
In practice, there are thunks that do a just little work, such as
pattern-matching on a variable, and the benefits of eta-expansion likely
ou
gh
tweigh the cost of doing that repeatedly. Therefore, this implementation of
outweigh the cost of doing that repeatedly. Therefore, this implementation of
Call Arity considers everything that is not cheap (`exprIsCheap`) as a thunk.
Note [Call Arity and Join Points]
...
...
compiler/simplCore/OccurAnal.hs
View file @
c65104e1
...
...
@@ -2088,7 +2088,7 @@ type GlobalScruts = IdSet -- See Note [Binder swap on GlobalId scrutinees]
-- x = (p,q) -- Don't inline p or q
-- y = /\a -> (p a, q a) -- Still don't inline p or q
-- z = f (p,q) -- Do inline p,q; it may make a rule fire
-- So OccEncl tells enough
t
about the context to know what to do when
-- So OccEncl tells enough about the context to know what to do when
-- we encounter a constructor application or PAP.
data
OccEncl
...
...
compiler/typecheck/TcPatSyn.hs
View file @
c65104e1
...
...
@@ -360,7 +360,7 @@ Here 'k' is implicitly bound in the signature, but (with
-XScopedTypeVariables) it does still scope over the pattern-synonym
definition. But what about 'kk', which is oexistential? It too is
implicitly bound in the signature; should it too scope? And if so,
what type var
ai
ble is it bound to?
what type var
ia
ble is it bound to?
The trouble is that the type variable to which it is bound is itself
only brought into scope in part the pattern, so it makes no sense for
...
...
compiler/typecheck/TcSMonad.hs
View file @
c65104e1
...
...
@@ -870,7 +870,7 @@ The idea is that
(NB: we could strengten K1) in this way too, but see K3.
- (K2b): If this holds then, by (T2), b is not in t. So applying the
work item does not gene
ne
rate any new opportunities for applying S
work item does not generate any new opportunities for applying S
- (K2c): If this holds, we can't pass through this triple infinitely
often, because if we did then fs>=f, fw>=f, hence by (R2)
...
...
compiler/typecheck/TcSimplify.hs
View file @
c65104e1
...
...
@@ -1098,7 +1098,7 @@ decideQuantifiedTyVars mono_tvs name_taus psigs candidates
;
return
(
qtvs
,
co_vars
)
}
-- Return all the CoVars that (transitively) might be mentioned
-- in the tau_tys etc. We don't need to do a closeOverKinds on
-- co_vars to get the transitive ones, bec
ua
se the grown_tvs
-- co_vars to get the transitive ones, bec
au
se the grown_tvs
-- are already closed over kinds, and hence contain all such
-- co_vars
...
...
mk/warnings.mk
View file @
c65104e1
...
...
@@ -11,8 +11,8 @@ SRC_HC_OPTS += -Wall
SRC_HC_OPTS_STAGE1
+=
$(WERROR)
SRC_HC_OPTS_STAGE2
+=
$(WERROR)
# Enable -Wcpp-undef for GHC components only
as we don't (currently) expect core
# libraries to build in this configuration (see #13636).
# Enable -Wcpp-undef for GHC components only
, as we don't (currently) expect
#
core
libraries to build in this configuration (see #13636).
GhcRtsHcOpts
+=
-Wcpp-undef
GhcStage1HcOpts
+=
-Wcpp-undef
GhcStage2HcOpts
+=
-Wcpp-undef
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment