1. 15 Dec, 2014 3 commits
    • Austin Seipp's avatar
      8afdf274
    • Simon Peyton Jones's avatar
      Make Core Lint check for locally-bound GlobalIds · d59c59f4
      Simon Peyton Jones authored
      There should be no bindings in this module for a GlobalId;
      except after CoreTidy, when top-level bindings are globalised.
      
      To check for this, I had to make the CoreToDo pass part of the
      environment that Core Lint caries.  But CoreToDo is defined in
      CoreMonad, which (before this patch) called CoreLint.
      
      So I had to do quite a bit of refactoring, moving some
      lint-invoking code into CoreLint itself.  Crucially, I also
      more tcLookupImported_maybe, importDecl, and checkwiredInTyCon
      from TcIface (which use CoreLint) to LoadIface (which doesn't).
      This is probably better structure anyway.
      
      So most of this patch is refactoring. The actual check for
      GlobalIds is in CoreLint.lintAndScopeId
      d59c59f4
    • Simon Peyton Jones's avatar
      Pattern-synonym matcher and builder Ids must be *LocalIds* · fbb42b2e
      Simon Peyton Jones authored
      This easy-to-make mistake meant that pattern-synonym matcher and
      builder Ids weren't being treated as locally defined by the simpplier.
      That meant that we never looked up them up in the environment, got an
      out-of-date unfolding, which made the Simplifier fall into an infinite
      loop.  This was the cause of Trac #98587, but it was quite tricky to
      find!
      
      In a separate patch I'll make Lint check for locally-bound GlobalIds,
      since they are always an error.
      fbb42b2e
  2. 14 Dec, 2014 10 commits
  3. 13 Dec, 2014 2 commits
    • Sergei Trofimovich's avatar
      Parser: remove unused rule (copy/paste error) · 288c7c6a
      Sergei Trofimovich authored
      Summary:
      Found out when tracking down conflicts reported by happy.
      It was accidentally introduced in large Api Annotations
      patch: 803fc5db
      
      
      
      Before:
        unused rules: 1
        shift/reduce conflicts:  60
        reduce/reduce conflicts: 16
      After:
        shift/reduce conflicts:  60
        reduce/reduce conflicts: 12
      
      Unused rule is seen in happy's --info= output as:
          rule 180 is unused
          ...
          decl_cls -> 'default' infixexp '::' sigtypedoc     (180)
          decl_cls -> 'default' infixexp '::' sigtypedoc     (181)
      
      While at it removed 'q' typo in parser conflict log :)
      Signed-off-by: default avatarSergei Trofimovich <siarheit@google.com>
      
      Reviewers: simonmar, austin, alanz
      
      Reviewed By: alanz
      
      Subscribers: carter, thomie
      
      Differential Revision: https://phabricator.haskell.org/D569
      288c7c6a
    • eir@cis.upenn.edu's avatar
      reduceTyFamApp_maybe should *not* normalise arguments first. · 3ec93917
      eir@cis.upenn.edu authored
      Doing so made the solver gobble up tons of memory, now that matchFam
      calls reduceTyFamApp_maybe. But, I don't know why, yet! Will
      look more closely at this soon.
      3ec93917
  4. 12 Dec, 2014 2 commits
    • eir@cis.upenn.edu's avatar
      Flat constraint --> Simple constraint · 8a0de692
      eir@cis.upenn.edu authored
      8a0de692
    • eir@cis.upenn.edu's avatar
      Rewrite `Coercible` solver · 0cc47eb9
      eir@cis.upenn.edu authored
      Summary:
      This is a rewrite of the algorithm to solve for Coercible "instances".
      
      A preliminary form of these ideas is at
      https://ghc.haskell.org/trac/ghc/wiki/Design/NewCoercibleSolver
      
      The basic idea here is that the `EqPred` constructor of `PredTree`
      now is parameterised by a new type `EqRel` (where
      `data EqRel = NomEq | ReprEq`). Thus, every equality constraint can
      now talk about nominal equality (the usual case) or representational
      equality (the `Coercible` case).
      
      This is a change from the previous
      behavior where `Coercible` was just considered a regular class with
      a special case in `matchClassInst`.
      
      Because of this change, representational equalities are now
      canonicalized just like nominal ones, allowing more equalities
      to be solved -- in particular, the case at the top of #9117.
      
      A knock-on effect is that the flattener must be aware of the
      choice of equality relation, because the inert set now stores
      both representational inert equalities alongside the nominal
      inert equalities. Of course, we can use representational equalities
      to rewrite only within another representational equality --
      thus the parameterization of the flattener.
      
      A nice side effect of this change is that I've introduced a new
      type `CtFlavour`, which tracks G vs. W vs. D, removing some ugliness
      in the flattener.
      
      This commit includes some refactoring as discussed on D546.
      It also removes the ability of Deriveds to rewrite Deriveds.
      
      This fixes bugs #9117 and #8984.
      
      Reviewers: simonpj, austin, nomeata
      
      Subscribers: carter, thomie
      
      Differential Revision: https://phabricator.haskell.org/D546
      
      GHC Trac Issues: #9117, #8984
      0cc47eb9
  5. 11 Dec, 2014 5 commits
  6. 10 Dec, 2014 17 commits
  7. 09 Dec, 2014 1 commit