1. 16 Jul, 2015 6 commits
  2. 15 Jul, 2015 5 commits
  3. 14 Jul, 2015 2 commits
  4. 13 Jul, 2015 6 commits
  5. 11 Jul, 2015 4 commits
  6. 10 Jul, 2015 3 commits
    • Ben Gamari's avatar
      Fix self-contained handling of ASCII encoding · d69dfba4
      Ben Gamari authored
      D898 was primarily intended to fix hangs in the event that iconv was
      unavailable (namely #10298 and #7695). In addition to this fix, it also
      introduced self-contained handling of ANSI terminals to allow compiled
      executables to run in minimal environments lacking iconv.
      However, the behavior that the patch introduced is highly suspicious.
      Specifically, it gives the user a UTF-8 encoding even if they requested
      This has the potential to break quite a lot of code. At very least it
      breaks GHC's Unicode terminal detection logic, which attempts to catch
      an invalid character when encoding a pair of smart-quotes. Of course,
      this exception will never be thrown if a UTF-8 encoder is used.
      Here we use the `char8` encoding to handle requests for ASCII encodings
      in the event that we find iconv to be non-functional.
      Fixes #10623.
      Test Plan: Validate with T8959a
      Reviewers: rwbarton, hvr, austin, hsyl20
      Subscribers: thomie
      Differential Revision: https://phabricator.haskell.org/D1059
      GHC Trac Issues: #10623
    • Simon Peyton Jones's avatar
      Improve error message for fundeps · 2d06a9f1
      Simon Peyton Jones authored
      Improve error message fundeps, especially when PolyKinds means that
      the un-determined variables are (invisible) kind variables.
      See Trac #10570.
    • Simon Peyton Jones's avatar
      Better type wildcard errors · 9e86bf1b
      Simon Peyton Jones authored
      Adopts sugggestion in Trac #10224, comment:3
  7. 09 Jul, 2015 2 commits
    • Ben Gamari's avatar
      Add testcase for #10602 · a6359f26
      Ben Gamari authored
    • Simon Peyton Jones's avatar
      Infer types with flexible contexts · b5aabfbd
      Simon Peyton Jones authored
      Responding to Trac #10608 and Trac #10351, I've reverted
      to making type inference infer structured constraint like
          f :: C [t] => t -> t
      even if -XFlexibleContexts is not set.  That elicits an
      error message suggesting the flag.  The result is more
      helpful than the error message you get otherwise.
  8. 08 Jul, 2015 1 commit
  9. 07 Jul, 2015 5 commits
    • Edward Z. Yang's avatar
      Fix #10596 by looking up 'Int' not 'Maybe Int' in the map. · 00c8d4d5
      Edward Z. Yang authored
      Test Plan: validate
      Reviewers: goldfire, austin, simonpj, bgamari
      Reviewed By: bgamari
      Subscribers: simonpj, rwbarton, thomie, bgamari
      Differential Revision: https://phabricator.haskell.org/D1026
      GHC Trac Issues: #10596
    • Sergei Trofimovich's avatar
      fix EBADF unqueueing in select backend (Trac #10590) · 5857e0af
      Sergei Trofimovich authored
      Alexander found a interesting case:
      1. We have a queue of two waiters in a blocked_queue
      2. first file descriptor changes state to RUNNABLE,
         second changes to INVALID
      3. awaitEvent function dequeued RUNNABLE thread to a
         run queue and attempted to dequeue INVALID descriptor
         to a run queue.
      Unqueueing INVALID fails thusly:
              #3  0x000000000045cf1c in barf (s=0x4c1cb0 "removeThreadFromDeQueue: not found")
                                     at rts/RtsMessages.c:42
              #4  0x000000000046848b in removeThreadFromDeQueue (...) at rts/Threads.c:249
              #5  0x000000000049a120 in removeFromQueues (...) at rts/RaiseAsync.c:719
              #6  0x0000000000499502 in throwToSingleThreaded__ (...) at rts/RaiseAsync.c:67
              #7  0x0000000000499555 in throwToSingleThreaded (..) at rts/RaiseAsync.c:75
              #8  0x000000000047c27d in awaitEvent (wait=rtsFalse) at rts/posix/Select.c:415
      The problem here is a throwToSingleThreaded function that tries
      to unqueue a TSO from blocked_queue, but awaitEvent function
      leaves blocked_queue in a inconsistent state while traverses
      over blocked_queue:
            case RTS_FD_IS_READY:
                    debugBelch("Waking up blocked thread %lu\n",
                               (unsigned long)tso->id));
                tso->why_blocked = NotBlocked;
                tso->_link = END_TSO_QUEUE;              // Here we break the queue head
      Signed-off-by: default avatarSergei Trofimovich <siarheit@google.com>
      Test Plan: tested on a sample from T10590
      Reviewers: austin, bgamari, simonmar
      Reviewed By: bgamari, simonmar
      Subscribers: qnikst, thomie, bgamari
      Differential Revision: https://phabricator.haskell.org/D1024
      GHC Trac Issues: #10590, #4934
    • kanetw's avatar
      Deferred type errors now throw TypeError (#10284) · 9a3e1657
      kanetw authored
      Depends on D864.
      Previous behaviour was ErrorCall, which might mask issues in tests 
      using -fdefer-type-errors
      Signed-off-by: kanetw's avatarDavid Kraeutmann <kane@kane.cx>
      Test Plan: Test whether the error thrown is indeed TypeError and not 
      Reviewers: hvr, nomeata, austin
      Reviewed By: nomeata, austin
      Subscribers: nomeata, simonpj, thomie
      Differential Revision: https://phabricator.haskell.org/D866
      GHC Trac Issues: #10284
    • kanetw's avatar
      Allow deferred type error warnings to be suppressed · f753cf11
      kanetw authored
      Adds a flag -fwarn-deferred-type-errors similar to -fwarn-typed-holes.
      Changes the boolean flag of -fdefer-type-errors to a 3-state flag 
      similar to the one used by -fdefer-typed-holes/-fwarn-typed-holes.
      Test Plan: Since only the absence of deferred type error warnings when 
      -fno-warn-deferred-type-errors is passed has to be tested, I duplicated 
      a test case checking -fdefer-type-errors and adjusted it accordingly.
      Reviewers: nomeata, simonpj, austin, thomie, bgamari, hvr
      Reviewed By: nomeata, simonpj, austin, thomie, bgamari, hvr
      Subscribers: bgamari, simonpj, nomeata, thomie
      Projects: #ghc
      Differential Revision: https://phabricator.haskell.org/D864
      GHC Trac Issues: #10283
    • rwbarton's avatar
      Don't eagerly blackhole single-entry thunks (#10414) · aaa0cd20
      rwbarton authored
      In a parallel program they can actually be entered more than once,
      leading to deadlock.
      Reviewers: austin, simonmar
      Subscribers: michaelt, thomie, bgamari
      Differential Revision: https://phabricator.haskell.org/D1040
      GHC Trac Issues: #10414
  10. 05 Jul, 2015 3 commits
  11. 04 Jul, 2015 3 commits
    • triple's avatar
      Easy way to defer type errors (implements #8353) · 5d48e67f
      triple authored
      Added load! and reload! commands, effectively setting
      "-fdefer-type-errors" before loading a file and
      unsetting it after loading if it has not been set before.
      Differential Revision: https://phabricator.haskell.org/D960
    • thomie's avatar
      Testsuite: add -ignore-dot-ghci to some tests · 124f3999
      thomie authored
      Since T10408A and T10408B would become the same now, delete T10408A and
      rename T10408B to T10408. The test without -ignore-dot-ghci (T10408A)
      didn't add anything (#10408).
    • Michal Terepeta's avatar
      Support MO_{Add,Sub}IntC and MO_Add2 in the LLVM backend · b1d1c652
      Michal Terepeta authored
      This includes:
      - Adding new LlvmType called LMStructP that represents an unpacked
        struct (this is necessary since LLVM's instructions the
        llvm.sadd.with.overflow.* return an unpacked struct).
      - Modifications to LlvmCodeGen.CodeGen to generate the LLVM
        instructions for the primops.
      - Modifications to StgCmmPrim to actually use those three instructions
        if we use the LLVM backend (so far they were only used for NCG).
      Test Plan: validate
      Reviewers: austin, rwbarton, bgamari
      Reviewed By: bgamari
      Subscribers: thomie, bgamari
      Differential Revision: https://phabricator.haskell.org/D991
      GHC Trac Issues: #9430