GitLab

This is actually an improvement. Yay!

The one non-comment change is a small refactoring/simplification
in TcCanonical that should have no impact: avoiding flattening twice.

This is pursuant to a conversion with SPJ, where we agreed that
the logic behind Note [Instance and Given overlap] in TcInteract
applied to newtype decomposition for representational equality.

There is no bug report or test case, as tickling this kind of thing
is quite hard to do!

Now, a Coercible (T1 ...) (T2 ...) constraint is insoluble only
when both T1 and T2 say "yes" to isDistinctTyCon. Several comments
also updated in this patch.

This change means that the intricate reasoning in TcErrors
around getting messages just right for nominal equalities
is skipped for representational equalities.

Now representational AppTys are just IrredEvCans, as they should be.

Test case: typecheck/should_compile/T10494

Summary:
Alignment needs to be a compile-time constant. Previously the code
generators had to jump through hoops to ensure this was the case as the
alignment was passed as a CmmExpr in the arguments list. Now we take
care of this up front.

This fixes #8131.
Authored-by: Reid Barton <rwbarton@gmail.com>
Dusted-off-by: Ben Gamari <ben@smart-cactus.org>

Tests for T8131

Test Plan: Validate

Reviewers: rwbarton, austin

Reviewed By: rwbarton, austin

Subscribers: bgamari, carter, thomie

Differential Revision: https://phabricator.haskell.org/D624

GHC Trac Issues: #8131

Ben Gamari authored Jun 16, 2015 and Ben Gamari committed Jun 16, 2015

Summary:
Alignment needs to be a compile-time constant. Previously the code
generators had to jump through hoops to ensure this was the case as the
alignment was passed as a CmmExpr in the arguments list. Now we take
care of this up front.

This fixes #8131.
Authored-by: Reid Barton <rwbarton@gmail.com>
Dusted-off-by: Ben Gamari <ben@smart-cactus.org>

Tests for T8131

Test Plan: Validate

Reviewers: rwbarton, austin

Reviewed By: rwbarton, austin

Subscribers: bgamari, carter, thomie

Differential Revision: https://phabricator.haskell.org/D624

GHC Trac Issues: #8131

Summary:
Today when reading through the users manual I noticed a few spelling issues.
This prompted me to run the document through ispell which turned up even more
issues. I've tried to be conservative here; most of the corrections are
misspellings and typos but in a few cases I've moved from American to British
orthography.

Test Plan: Read.

Reviewers: austin

Reviewed By: austin

Subscribers: bgamari, thomie

Differential Revision: https://phabricator.haskell.org/D925

Ben Gamari authored Jun 16, 2015 and Ben Gamari committed Jun 16, 2015

Summary:
Today when reading through the users manual I noticed a few spelling issues.
This prompted me to run the document through ispell which turned up even more
issues. I've tried to be conservative here; most of the corrections are
misspellings and typos but in a few cases I've moved from American to British
orthography.

Test Plan: Read.

Reviewers: austin

Reviewed By: austin

Subscribers: bgamari, thomie

Differential Revision: https://phabricator.haskell.org/D925

Summary:
I've heard numerous fledgling Haskeller's complain about the behavior of
ghci regarding bindings. While most REPLs accept bindings of the form
`x = 42`, GHCi is implicitly a `do` block, meaning that the user must
know to use a `let` to introduce a binding.

Here we suggest to the user that they may need a `let` and give them a
small example in the event that we find an unexpected `=` token.

Reviewers: austin

Reviewed By: austin

Subscribers: thomie, bgamari

Differential Revision: https://phabricator.haskell.org/D980

Ben Gamari authored Jun 16, 2015 and Ben Gamari committed Jun 16, 2015

Summary:
I've heard numerous fledgling Haskeller's complain about the behavior of
ghci regarding bindings. While most REPLs accept bindings of the form
`x = 42`, GHCi is implicitly a `do` block, meaning that the user must
know to use a `let` to introduce a binding.

Here we suggest to the user that they may need a `let` and give them a
small example in the event that we find an unexpected `=` token.

Reviewers: austin

Reviewed By: austin

Subscribers: thomie, bgamari

Differential Revision: https://phabricator.haskell.org/D980

Ben Gamari authored Jun 16, 2015 and Ben Gamari committed Jun 16, 2015

-auto-all is now -fprof-auto.

Reviewed By: austin

Differential Revision: https://phabricator.haskell.org/D989

Test case: typecheck/should_fail/T10534

I forgot to rename this in 5ddd9041.

I have no idea why, but lower is good

This fixes Trac #10520.  See the "Ugh" note about
record selectors in HscTypes.icExtendGblRdrEnv.

See Note [The inert set after solving Givens] in TcSMonad.

This fixes Trac #10507.

So #10348 is only missing the variable case:
  Known{Nat,Symbol} lit => Typeable lit

  * Increase max constraint tuple size to 62
  * Modify test case to reflect change

Reviewed By: austin

Differential Revision: https://phabricator.haskell.org/D986

GHC Trac Issues: #10451

Because sometimes types make more sense than docs.

Reviewed By: austin

Differential Revision: https://phabricator.haskell.org/D983

jakzale on #ghc reported a build failure
when ported GHC on a new target.

The code 'pprHexVal (2^32) W32' emits '0xU'
which is invalid C.

I've introduced bug in
    43f1b2ec


when added literal truncation. That truncation
is a new source of zeros.
Signed-off-by: Sergei Trofimovich <siarheit@google.com>

Test Plan: added test and tested on UNREG ghc

Reviewers: austin

Reviewed By: austin

Subscribers: thomie, bgamari

Differential Revision: https://phabricator.haskell.org/D987

GHC Trac Issues: #10518

And rename timeout_multiplier to run_timeout_multiplier.

timeout_multiplier was added in commit
a0038979. The name suggested that it
would affect any test, but it actually only affected tests that had a
run component, and only that run component (as needed by test T367).

Differential Revision: https://phabricator.haskell.org/D982

On a test failure, we show a diff between the expected and the actual
output. The method of how we do this has changed a couple of times:

* In 2007: 9951189c
  "On failure, diff the normalised test outputs"

* In 2011: 3019b1e4
  "When the output files differ, present the diffs between the *actual*
  output, not the normalised output. The latter may have newlines
  removed, making the diff unreadable."

* In 2015 (now): do something in between.
  - Do apply the normalisers again, to make the diff smaller (only
    showing the actual problem).
  - But don't apply normalise_whitespace, as it indeed makes the diff
    unreadable.

Differential Revision: https://phabricator.haskell.org/D984

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

[skip ci]

[skip ci]

[skip ci]

Summary:
This was reverted in d70b19bf
and is a part of the reason for #10445.

Test Plan: validate

Reviewers: ezyang, simonmar, austin

Reviewed By: simonmar, austin

Subscribers: bgamari, thomie

Differential Revision: https://phabricator.haskell.org/D938

GHC Trac Issues: #8435

Summary:
This commit brings following changes and fixes:

 * Implement parseExpr and compileParsedExpr;
 * Fix compileExpr and dynCompilerExpr, which returned `()` for empty expr;
 * Fix :def and :cmd, which didn't work if `IO` or `String` is not in scope;
 * Use GHCiMonad instead IO in :def and :cmd;
 * Clean PrelInfo: delete dead comment and duplicate entries, add assertion.

See new tests for more details.

Test Plan: ./validate

Reviewers: austin, dterei, simonmar

Reviewed By: simonmar

Subscribers: thomie, bgamari

Differential Revision: https://phabricator.haskell.org/D974

GHC Trac Issues: #10508

The testsuite driver has a little known feature to check which files
each test writes to, whether there are tests that write to same file,
and whether the tests leave any files behind when CLEANUP=1. It uses
strace under the hood.

This commit fixes some bitrot, and filters out some more strace lines
that we're not interested in (and are shown as framework failures
otherwise).

Differential Revision: https://phabricator.haskell.org/D979

Sebastian Reuße authored Jun 12, 2015 and Thomas Miedema committed Jun 12, 2015

The alternatives table gave the wrong glyphs for LEFTWARDS resp.
RIGHTWARDS ARROW-TAIL notation. The listed codepoint was correct,
but the entities corresponded to characters different from those
codepoints.

This also adds the glyphs for LEFTWARDS resp. RIGHTWARDS
DOUBLE ARROW-TAIL, which were formerly missing, and the PROPORTION
glyph, which was formerly given as ASCII.

Berdes authored Jun 12, 2015 and Thomas Miedema committed Jun 12, 2015

Simplify some preprocessor expressions involving `_MSC_VER` because
`_WIN32` is always defined when `_MSC_VER` is.

Differential Revision: https://phabricator.haskell.org/D981

As it turns out, in our new design these changes are no longer
needed. The code is simpler without returning a list of ModIface,
so let's do it!

This reverts commit 8c7d20d8.

This reverts commit a7524eae.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Test Plan: validate

Reviewers: simonpj, austin

Subscribers: bgamari, thomie

Differential Revision: https://phabricator.haskell.org/D947