From 1abaf38a174e07cc9c3f22fb5e05490219219b84 Mon Sep 17 00:00:00 2001 From: Ben Gamari <ben@smart-cactus.org> Date: Wed, 9 Dec 2020 22:06:22 -0500 Subject: [PATCH] nonmoving: Fix small CPP bug Previously an incorrect semicolon meant that we would fail to call busy_wait_nop when spinning. --- rts/sm/NonMovingMark.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/rts/sm/NonMovingMark.c b/rts/sm/NonMovingMark.c index 02d03dc72119..183c366a5626 100644 --- a/rts/sm/NonMovingMark.c +++ b/rts/sm/NonMovingMark.c @@ -737,9 +737,11 @@ void updateRemembSetPushStack(Capability *cap, StgStack *stack) // The concurrent GC has claimed the right to mark the stack. // Wait until it finishes marking before proceeding with // mutation. - while (needs_upd_rem_set_mark((StgClosure *) stack)); + while (needs_upd_rem_set_mark((StgClosure *) stack)) #if defined(PARALLEL_GC) busy_wait_nop(); // TODO: Spinning here is unfortunate +#else + ; #endif return; } -- GitLab