Commit 9cb44598 authored by Ben Gamari's avatar Ben Gamari 🐢 Committed by Ben Gamari
Browse files

testsuite: Work around #12554

It seems that Python 2.7.11 and "recent" msys2 releases are broken,
holding open file locks unexpected. This causes rmtree to intermittently
fail. Even worse, it would fail silently (since we pass
ignore_errors=True), causing makedirs to fail later.

We now explicitly check for the existence of the test directory before
attempting to delete it and disable ignore_errors. Moreover, on Windows
we now try multiple times to rmtree the testdir, working around the
apparently msys bug.

This is all just terrible, but Phyx and I spent several hours trying to
track down the issue to no available. The workaround is better than
parent 3adaacde
......@@ -1850,8 +1850,48 @@ def find_expected_file(name, suff):
return basename
def cleanup():
shutil.rmtree(getTestOpts().testdir, ignore_errors=True)
# Windows seems to exhibit a strange behavior where processes' executables
# remain locked even after the process itself has died. When this happens
# rmtree will fail with either Error 5 or Error 32. It takes some time for this
# to resolve so we try several times to delete the directory, only eventually
# failing if things seem really stuck. See #12554.
if config.msys:
from exceptions import WindowsError
import stat
def cleanup():
def on_error(function, path, excinfo):
# At least one test (T11489) removes the write bit from a file it
# produces. Windows refuses to delete read-only files with a
# permission error. Try setting the write bit and try again.
if excinfo[1].errno == 13:
os.chmod(path, stat.S_IWRITE)
testdir = getTestOpts().testdir
attempts = 0
max_attempts = 10
while attempts < max_attempts and os.path.exists(testdir):
shutil.rmtree(testdir, ignore_errors=False, onerror=on_error)
except WindowsError as e:
#print('failed deleting %s: %s' % (testdir, e))
if e.winerror in [5, 32]:
attempts += 1
if attempts == max_attempts:
raise e
raise e
def cleanup():
testdir = getTestOpts().testdir
if os.path.exists(testdir):
shutil.rmtree(testdir, ignore_errors=False)
# -----------------------------------------------------------------------------
# Return a list of all the files ending in '.T' below directories roots.
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment