1. 25 Feb, 2016 13 commits
    • Thomas Miedema's avatar
      Mark tests for #11643, #11644, #11645 and #9406 expect_broken · 90fa8cf2
      Thomas Miedema authored
      For opt_ways or prof_ways only.
      
      indexed-types/should_compile/all.T called setTestOpts to not run
      the tests with opt_ways. Since I'm finding regressions for opt_ways, I
      removed it. This only makes a difference when running
      `./validate --slow` or `make slowtest`.
      
      Update submodule hpc.
      90fa8cf2
    • Thomas Miedema's avatar
      Testsuite: for tests that use TH, omit *all* prof_ways · e02b8c8d
      Thomas Miedema authored
      Instead of just profasm and profthreaded. And at least until
      -fexternal-interpreter is the default.
      
      Also:
        * WAY=profc doesn't exist anymore.
        * Omit all threaded_ways for conc039, not just a few.
      e02b8c8d
    • Thomas Miedema's avatar
      Testsuite: Introduce config.plugin_way_flags. · 8e6e0222
      Thomas Miedema authored
      Refactoring only.
      8e6e0222
    • Rik Steenkamp's avatar
      Improve pattern synonym error messages (add `PatSynOrigin`) · 116528c8
      Rik Steenkamp authored and Ben Gamari's avatar Ben Gamari committed
      Adds a new data constructor `PatSynOrigin Bool Name` to the `CtOrigin`
      data type. This allows for better error messages when the origin of a
      wanted constraint is a pattern synonym declaration.
      
      Fixes T10873.
      
      Reviewers: mpickering, simonpj, austin, thomie, bgamari
      
      Reviewed By: simonpj, thomie, bgamari
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D1866
      
      GHC Trac Issues: #10873
      116528c8
    • Matthew Pickering's avatar
      Improve accuracy of suggestion to use TypeApplications · e38c07bf
      Matthew Pickering authored and Ben Gamari's avatar Ben Gamari committed
      The suggestion only makes sense when we try
      to use an as pattern in an expression context.
      
      It is misleading in the case of a lazy pattern and
      view pattern.
      
      Reviewers: austin, bgamari
      
      Reviewed By: bgamari
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D1948
      e38c07bf
    • Thomas Miedema's avatar
      Handle multiline named haddock comments properly · 6350eb11
      Thomas Miedema authored and Ben Gamari's avatar Ben Gamari committed
      Fixes #10398 in a different way, thereby also fixing #11579.
      
      I inverted the logic of the Bool argument to "worker", to hopefully make
      it more self-explanatory.
      
      Reviewers: austin, hvr, bgamari
      
      Reviewed By: bgamari
      
      Differential Revision: https://phabricator.haskell.org/D1935
      6350eb11
    • Georgios Karachalias's avatar
      (Alternative way to) address #8710 · 67393977
      Georgios Karachalias authored and Ben Gamari's avatar Ben Gamari committed
      Issue a separate warning per redundant (or inaccessible) clause.
      This way each warning can have more precice location information
      (the location of the clause under consideration and not the whole
      match).
      
      I thought that this could be too much but actually the number of
      such warnings is bound by the number of cases matched against (in
      contrast to the non-exhaustive warnings which may be exponentially
      more).
      
      Test Plan: validate
      
      Reviewers: simonpj, austin, bgamari
      
      Reviewed By: bgamari
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D1920
      
      GHC Trac Issues: #8710
      67393977
    • Ben Gamari's avatar
      Bump haddock.base allocations · ebaa638f
      Ben Gamari authored
      I believe this is probably due to the recent RuntimeRep change.
      ebaa638f
    • Matthew Pickering's avatar
      Reconstruct record expression in bidir pattern synonym · 52879d1f
      Matthew Pickering authored and Ben Gamari's avatar Ben Gamari committed
      Reviewers: austin, rdragon, bgamari
      
      Reviewed By: bgamari
      
      Subscribers: rdragon, thomie
      
      Differential Revision: https://phabricator.haskell.org/D1949
      52879d1f
    • manav's avatar
      Make warning names more consistent · 66584914
      manav authored and Ben Gamari's avatar Ben Gamari committed
      - Replace "Sigs" with "Signatures" in WarningFlag data constructors.
      - Replace "PatSyn" with "PatternSynonym" in WarningFlag data
        constructors.
      - Deprecate "missing-local-sigs" in favor of "missing-local-signatures".
      - Deprecate "missing-exported-sigs" in favor of
        "missing-exported-signatures".
      - Deprecate "missing-pat-syn-signatures" in favor of
        "missing-pattern-synonym-signatures".
      - Replace "ddump-strsigs" with "ddump-str-signatures"
      
      These complete the tasks that were explicitly mentioned in #11583
      
      Test Plan:
      Executed `ghc --show-options` and verified that the flags were changed
      as expected.
      
      Reviewers: svenpanne, austin, bgamari
      
      Reviewed By: austin, bgamari
      
      Subscribers: mpickering, thomie
      
      Differential Revision: https://phabricator.haskell.org/D1939
      
      GHC Trac Issues: #11583
      66584914
    • Ryan Scott's avatar
      Add more type class instances for GHC.Generics · 673efccb
      Ryan Scott authored and Ben Gamari's avatar Ben Gamari committed
      GHC.Generics provides several representation data types that have
      obvious instances of various type classes in base, along with various
      other types of meta-data (such as associativity and fixity).
      Specifically, instances have been added for the following type classes
      (where possible):
      
          - Applicative
          - Data
          - Functor
          - Monad
          - MonadFix
          - MonadPlus
          - MonadZip
          - Foldable
          - Traversable
          - Enum
          - Bounded
          - Ix
          - Generic1
      
      Thanks to ocharles for starting this!
      
      Test Plan: Validate
      
      Reviewers: ekmett, austin, hvr, bgamari
      
      Reviewed By: bgamari
      
      Subscribers: RyanGlScott, thomie
      
      Differential Revision: https://phabricator.haskell.org/D1937
      
      GHC Trac Issues: #9043
      673efccb
    • Ben Gamari's avatar
      ApplicativeDo: Handle terminal `pure` statements · 0c7db61f
      Ben Gamari authored and Ben Gamari's avatar Ben Gamari committed
      ApplicativeDo handled terminal `return` statements properly, but not
      `pure`.
      
      Test Plan: Validate with included testcase
      
      Reviewers: austin, simonmar
      
      Reviewed By: austin, simonmar
      
      Subscribers: simonpj, thomie
      
      Differential Revision: https://phabricator.haskell.org/D1931
      
      GHC Trac Issues: #11607
      0c7db61f
    • Peter Trommler's avatar
      testsuite: mark tests broken on powerpc64 · feb19eae
      Peter Trommler authored and Ben Gamari's avatar Ben Gamari committed
      The following tests fail on powerpc64 and have a ticket.
      Mark those tests as expect_broken.
      
      Here are the details:
      The PowerPC native code generator does not support DWARF debug
      information. This is tracked in ticket #11261. Mark the respective
      tests broken on powerpc64.
      
      testsuite: mark print022 broken on powerpc64
      Ticket #11262 tracks difference in stdout for print022.
      
      testsuite: mark recomp015 broken on powerpc64
      testsuite: mark recomp011 broken on powerpc64
      This is tracked as ticket #11323 and #11260.
      
      testsuite: mark linker tests broken on powerpc64
      Ticket #11259 tracks tests failing because there is no RTS
      linker on powerpc64.
      
      Test Plan: validate
      
      Reviewers: erikd, austin, bgamari
      
      Reviewed By: bgamari
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D1928
      
      GHC Trac Issues: #11259, #11260, #11261, #11262, #11323
      feb19eae
  2. 24 Feb, 2016 1 commit
    • eir@cis.upenn.edu's avatar
      Address #11471 by putting RuntimeRep in kinds. · d8c64e86
      eir@cis.upenn.edu authored
      See Note [TYPE] in TysPrim. There are still some outstanding
      pieces in #11471 though, so this doesn't actually nail the bug.
      
      This commit also contains a few performance improvements:
      
      * Short-cut equality checking of nullary type syns
      
      * Compare types before kinds in eqType
      
      * INLINE coreViewOneStarKind
      
      * Store tycon binders separately from kinds.
      
      This resulted in a ~10% performance improvement in compiling
      the Cabal package. No change in functionality other than
      performance. (This affects the interface file format, though.)
      
      This commit updates the haddock submodule.
      d8c64e86
  3. 23 Feb, 2016 15 commits
  4. 21 Feb, 2016 1 commit
  5. 20 Feb, 2016 5 commits
  6. 19 Feb, 2016 3 commits
    • Thomas Miedema's avatar
      Pass -haddock to tests in should_compile_*flag*_nohaddock · c6007fe6
      Thomas Miedema authored
      should_compile_flag_nohaddock and should_compile_noflag_nohaddock
      contain the exact same tests. By passing `-haddock` to the tests in
      should_compile_**flag**_nohaddock, at least they're now testing
      different things.
      
      Add documentation.
      c6007fe6
    • Thomas Miedema's avatar
      Modifier letter in middle of identifier is ok · d738e664
      Thomas Miedema authored
      Refactoring only. Cleanup some loose ends from #10196.
      
      Initially the idea was to only allow modifier letters at the end of
      identifiers. Since we later decided to allow modifier letters also in
      the middle of identifiers (because not doing so would not fix the
      regression completely), the names `suffix` and `okIdSuffixChar` don't
      seem appropriate anymore.
      
      Remove TODO. Move test from should_fail to should_compile.
      d738e664
    • Gabor Greif's avatar
      A few more typos in non-code · 8b073f6c
      Gabor Greif authored
      8b073f6c
  7. 18 Feb, 2016 2 commits
    • Ben Gamari's avatar
      Unwire Typeable representation types · 206a8bf4
      Ben Gamari authored and Ben Gamari's avatar Ben Gamari committed
      In order to make this work I needed to shuffle around typechecking a bit
      such that `TyCon` and friends are available during compilation of
      GHC.Types.  I also did a bit of refactoring of `TcTypeable`.
      
      Test Plan: Validate
      
      Reviewers: simonpj, austin
      
      Subscribers: simonpj, thomie
      
      Differential Revision: https://phabricator.haskell.org/D1906
      
      GHC Trac Issues: #11120
      206a8bf4
    • Simon Peyton Jones's avatar
      Take type-function arity into account · a008eadf
      Simon Peyton Jones authored
      ...when computing the size of a call on the RHS of a type
      instance declaration.
      
      This came up in Trac #11581.  The change is in
         TcType.tcTyFamInsts
      which now trims the type arguments in a call.  See the
      comments with that function definition.
      a008eadf