Alec Theriault authored 6 years ago and Ryan Scott committed 6 years ago

Summary:
This matches exactly the 'Read (Array i e)' instance defined in base.
Note that the same thing is being done for 'Show (UArray i e)'.

Reviewers: RyanGlScott, bgamari

GHC Trac Issues: #11335

Differential Revision: https://phabricator.haskell.org/D5156

Chaitanya Koparkar authored 7 years ago and Ben Gamari committed 7 years ago

Summary:
The old Travis script still had targets to test against GHC < 8.0,
and wasn't using Cabal `new-build` among other things.

Reviewers: bgamari, RyanGlScott

Reviewed By: RyanGlScott

Differential Revision: https://phabricator.haskell.org/D4681

See https://ghc.haskell.org/trac/ghc/ticket/15018.

David Feuer authored 7 years ago and Ben Gamari committed 7 years ago

Summary: These have shifted out of the support window.

Reviewers: bgamari, hvr, RyanGlScott

Reviewed By: RyanGlScott

Subscribers: RyanGlScott

Differential Revision: https://phabricator.haskell.org/D4499

The fact that this was previously hidden appears to be an oversight and
I've needed it at least once.

The recent overflow check made the code stop working w/ prior versions
of GHC. But there's little benefit in support much older GHCs, so it's
easier to just cut the support window.

The ghc-8.2 and master branches disagree on the order of the instances.
Normalise this difference away.

Previously it failed with,

-T229: Data.Array.Base.safe_scale: Overflow; scale: 4, n: 4611686018427387904
-CallStack (from HasCallStack):
-  error, called at libraries/array/Data/Array/Base.hs ...
+T229: Ix{Int}.index: Index (17) out of range ((0,-1))

No overflow check is necessary in the case of Bool arrays since the array size
is actually smaller than the number of elements it contains. Moreover, we can
use setByteArray# to initialize the array.

As akio points out, the fix to #229 which I authored previously was blatantly
wrong.

Fixes GHC #4505.

Changing InstEnv to UniqDFM changes the order some things get
printed