Alex D authored Jul 13, 2019 and Marge Bot committed Jul 26, 2019

Change behaviour of -ddump-cmm-verbose to dump each Cmm pass output to a separate file and add -ddump-cmm-verbose-by-proc to keep old behaviour (#16930)

Ryan Scott authored Jul 12, 2019 and Marge Bot committed Jul 26, 2019

GHC used to reject programs of this form:

```
newtype Age = MkAge Int
  deriving Eq via Const Int a
```

That's because an earlier implementation of `DerivingVia` would
generate the following instance:

```
instance Eq Age where
  (==) = coerce @(Const Int a -> Const Int a -> Bool)
                @(Age         -> Age         -> Bool)
                (==)
```

Note that the `a` in `Const Int a` is not bound anywhere, which
causes all sorts of issues. I figured that no one would ever want to
write code like this anyway, so I simply banned "floating" `via` type
variables like `a`, checking for their presence in the aptly named
`reportFloatingViaTvs` function.

`reportFloatingViaTvs` ended up being implemented in a subtly
incorrect way, as #15831 demonstrates. Following counsel with the
sage of gold fire, I decided to abandon `reportFloatingViaTvs`
entirely and opt for a different approach that would _accept_
the instance above. This is because GHC now generates this instance
instead:

```
instance forall a. Eq Age where
  (==) = coerce @(Const Int a -> Const Int a -> Bool)
                @(Age         -> Age         -> Bool)
                (==)
```

Notice that we now explicitly quantify the `a` in
`instance forall a. Eq Age`, so everything is peachy scoping-wise.
See `Note [Floating `via` type variables]` in `TcDeriv` for the full
scoop.

A pleasant benefit of this refactoring is that it made it much easier
to catch the problem observed in #16181, so this patch fixes that
issue too.

Fixes #15831. Fixes #16181.

Ömer Sinan Ağacan authored Jul 25, 2019 and Marge Bot committed Jul 25, 2019

Before:

    Rec {
    x2_r10T :: Lib.Bar
    [GblId, Unf=OtherCon []] =
        CCS_DONT_CARE Lib.Bar! [x3_r10U];
    x3_r10U :: Lib.Foo
    [GblId, Unf=OtherCon []] =
        CCS_DONT_CARE Lib.Foo! [x1_r10p x2_r10T];
    end Rec }

After:

    Rec {
    x2_r10T :: Lib.Bar
    [GblId, Unf=OtherCon []] =
        CCS_DONT_CARE Lib.Bar! [x3_r10U];

    x3_r10U :: Lib.Foo
    [GblId, Unf=OtherCon []] =
        CCS_DONT_CARE Lib.Foo! [x1_r10p x2_r10T];
    end Rec }

Ryan Scott authored Jul 23, 2019 and Marge Bot committed Jul 25, 2019

Before, `type DefUses = [DefUse]`. But lists are a terrible choice of
data structure here, as we frequently append to the right of a
`DefUses`, which yields some displeasing asymptotics. Let's instead
use `OrdList`, which has constant-time appending to the right.

This is one step on the way to #10347.

Ben Gamari authored Jul 19, 2019 and Marge Bot committed Jul 24, 2019

* Use show! in source tarball job. Since we aren't actually building
  anything in this job `show` won't
  work.

* Fix Docker image name

* Make `version` file contain only version string

John Ericson authored Apr 07, 2019 and Marge Bot committed Jul 24, 2019

Now that the target macros are not being used, we remove them. This
prevents target hardcoding regressions.

Alp Mestanogullari authored May 27, 2019 and Marge Bot committed Jul 23, 2019

Since MR !1025 fixed the Windows build, allowing us to build a binary
distribution, we can now run the testsuite in that CI job.

This required fixing 'createFileLink': it should not try to create
symlinks on Windows (that requires admin priviledges, which Hadrian can't
assume). We now instead fall back to copying.

This patch also removes some duplicated logic for iserv in the test rules,
where we handle our dependency on the iserv binaries in a special way.

Ömer Sinan Ağacan authored Jul 23, 2019 and Marge Bot committed Jul 23, 2019

Now that we have absolute paths for submodules (since a76b233d) we no
longer need this script.

Ben Gamari authored Jul 19, 2019 and Marge Bot committed Jul 21, 2019

As fromFlag is partial. The only case where we used fromFlag is when
determining whether to strip libraries; we now assume that we shouldn't.

Roland Senn authored Jul 18, 2019 and Marge Bot committed Jul 21, 2019

To display the free variables for a single breakpoint, GHCi pulls out the
information from the fields `modBreaks_breakInfo` and `modBreaks_vars`
of the `ModBreaks` data structure. For a specific breakpoint this gives 2
lists of types 'Id` (`Var`) and `OccName`. They are used to create the Id's
for the free variables and must be kept in sync:
If we remove an element from the Names list, then we also must remove the
corresponding element from the OccNames list.

Ivan Kasatenko authored Jul 20, 2019 and Marge Bot committed Jul 21, 2019

Kqueue/kevent implementation used to ignore events to be unsubscribed
from when events to be subscribed to were provided. This resulted in a
lost notification subscription, when GHC runtime didn't listen for any
events, yet the kernel considered otherwise and kept waking up the IO
manager thread.

This commit fixes this issue by always adding and removing all of the
provided subscriptions.

Andreas Klebinger authored Jul 10, 2019 and Marge Bot committed Jul 21, 2019

This makes it simpler to load Modules importing it
when using ghc-the-package.

-------------------------
Metric Decrease:
    haddock.compiler
-------------------------

Matthew Pickering authored Jul 19, 2019 and Marge Bot committed Jul 20, 2019

This was removed from make in 077b92fa

Alfredo Di Napoli authored Jul 13, 2019 and Marge Bot committed Jul 20, 2019

This commit fixes #16874 by using `fsep` rather than `sep` when pretty
printing long patterns and expressions.

Richard Eisenberg authored Jul 18, 2019 and Marge Bot committed Jul 19, 2019

This was requested in #15650.

Ryan Scott authored Jul 18, 2019 and Marge Bot committed Jul 19, 2019

This makes the `maintainer-clean` rule in `ghc.mk` slightly more
sophisticated so that it does not remove the version-controlled
file `libraries/ghc-boot/ghc.mk`, which was checked into version
control in commit 24782b89.

Fixes #16953.

Vladislav Zavialov authored Jul 16, 2019 and Marge Bot committed Jul 19, 2019

9366e019 introduced a check for orphan roles to fix #8485

6ab5da99 changed the lookup code and made the check redundant.

Now it is removed.

As noted in #16909.

Fixed in #14759.

This requires code loading and therefore can't be run in the profiled
ways when GHC is dynamically linked.

As noted in #11645 and #8862, forking and profiling don't go well
together.

Bumps hpc and unix submodules.

Previously it was not marked as broken in profthreaded