Snippets Groups Projects

Forked from Glasgow Haskell Compiler / GHC

12231 commits behind, 1 commit ahead of the upstream repository.

Introduce isBoxedTupleDataCon and use it to fix #18644

Ryan Scott authored 4 years ago

The code that converts promoted tuple data constructors to
`IfaceType`s in `GHC.CoreToIface` was using `isTupleDataCon`, which
conflates boxed and unboxed tuple data constructors. To avoid this,
this patch introduces `isBoxedTupleDataCon`, which is like
`isTupleDataCon` but only works for _boxed_ tuple data constructors.

While I was in town, I was horribly confused by the fact that there
were separate functions named `isUnboxedTupleCon` and
`isUnboxedTupleTyCon` (similarly, `isUnboxedSumCon` and
`isUnboxedSumTyCon`). It turns out that the former only works for
data constructors, despite its very general name! I opted to rename
`isUnboxedTupleCon` to `isUnboxedTupleDataCon` (similarly, I renamed
`isUnboxedSumCon` to `isUnboxedSumDataCon`) to avoid this potential
confusion, as well as to be more consistent with
the naming convention I used for `isBoxedTupleDataCon`.

Fixes #18644.

04c79049

04c79049 4 years ago

Code owners

Assign users and groups as approvers for specific file changes. Learn more.

Name	Last commit	Last update
..
config
driver
mk
tests
timeout
.gitignore
LICENSE
LICENSE.GPL
Makefile
README.md

GHC Testsuite Readme

For the full testsuite documentation, please see here.

Quick Guide

Commands to run testsuite:

Full testsuite: make
Using more threads: make THREADS=12
Reduced (fast) testsuite: make fast
Run a specific test: make TEST=tc054
Test a specific 'way': make WAY=optllvm
Keeping the run directory after test run: make CLEANUP=0. You will find a directory {test_name}.run in the test's source directory.
Test a specific stage of GHC: make stage=1
Skip performance tests: make SKIP_PERF_TESTS=YES
Set verbosity: make VERBOSE=n where n=0: No per-test output, n=1: Only failures, n=2: Progress output, n=3: Include commands called (default), n=4: Include perf test results unconditionally, n=5: Echo commands in subsidiary make invocations
Pass in extra GHC options: make EXTRA_HC_OPTS=-fvectorize

You can also change directory to a specific test folder to run that individual test or group of tests. For example:

$ cd tests/array
$ make

Testsuite Ways

The testsuite can be run in a variety of 'ways'. This concept refers to different ways that GHC can compile the code. For example, using the native code generator (-fasm) is one way, while using the LLVM code generator (-fllvm) is another way.

The various ways that GHC supports are defined in config/ghc

Adding Tests

Please see the more extensive documentation here.