Skip to content
  • Ömer Sinan Ağacan's avatar
    Add missing opening braces in Cmm dumps · db8e3275
    Ömer Sinan Ağacan authored and Marge Bot's avatar Marge Bot committed
    Previously -ddump-cmm was generating code with unbalanced curly braces:
    
         stg_atomically_entry() //  [R1]
                 { info_tbls: [(cfl,
                                label: stg_atomically_info
                                rep: tag:16 HeapRep 1 ptrs { Thunk }
                                srt: Nothing)]
                   stack_info: arg_space: 8 updfr_space: Just 8
                 }
             {offset
               cfl: // cfk
                   unwind Sp = Just Sp + 0;
                   _cfk::P64 = R1;
                   //tick src<rts/PrimOps.cmm:(1243,1)-(1245,1)>
                   R1 = I64[_cfk::P64 + 8 + 8 + 0 * 8];
                   call stg_atomicallyzh(R1) args: 8, res: 0, upd: 8;
             }
         }, <---- OPENING BRACE MISSING
    
    After this patch:
    
         stg_atomically_entry() { //  [R1] <---- MISSING OPENING BRACE HERE
                 { info_tbls: [(cfl,
                                label: stg_atomically_info
                                rep: tag:16 HeapRep 1 ptrs { Thunk }
                                srt: Nothing)]
                   stack_info: arg_space: 8 updfr_space: Just 8
                 }
             {offset
               cfl: // cfk
                   unwind Sp = Just Sp + 0;
                   _cfk::P64 = R1;
                   //tick src<rts/PrimOps.cmm:(1243,1)-(1245,1)>
                   R1 = I64[_cfk::P64 + 8 + 8 + 0 * 8];
                   call stg_atomicallyzh(R1) args: 8, res: 0, upd: 8;
             }
         },
    db8e3275