Commit 7e340c2b authored by Erik de Castro Lopo's avatar Erik de Castro Lopo Committed by Erik de Castro Lopo
Browse files

Enable new warning for fragile/incorrect CPP #if usage

The C code in the RTS now gets built with `-Wundef` and the Haskell code
(stages 1 and 2 only) with `-Wcpp-undef`. We now get warnings whereever
`#if` is used on undefined identifiers.

Test Plan: Validate on Linux and Windows

Reviewers: austin, angerman, simonmar, bgamari, Phyx

Reviewed By: bgamari

Subscribers: thomie, snowleopard

Differential Revision: https://phabricator.haskell.org/D3278
parent 5e968f92
......@@ -1345,7 +1345,7 @@ type HasCallStack = (() :: Constraint)
#endif
-- | A call stack constraint, but only when 'isDebugOn'.
#if DEBUG
#ifdef DEBUG
type HasDebugCallStack = HasCallStack
#else
type HasDebugCallStack = (() :: Constraint)
......
......@@ -379,7 +379,7 @@ findEditor :: IO String
findEditor = do
getEnv "EDITOR"
`catchIO` \_ -> do
#if mingw32_HOST_OS
#ifdef mingw32_HOST_OS
win <- System.Win32.getWindowsDirectory
return (win </> "notepad.exe")
#else
......
import CmmExpr
#if !(MACHREGS_i386 || MACHREGS_x86_64 || MACHREGS_sparc || MACHREGS_powerpc)
#if !(defined(MACHREGS_i386) || defined(MACHREGS_x86_64) \
|| defined(MACHREGS_sparc) || defined(MACHREGS_powerpc))
import Panic
#endif
import Reg
......@@ -8,9 +9,9 @@ import Reg
#include "ghcautoconf.h"
#include "stg/MachRegs.h"
#if MACHREGS_i386 || MACHREGS_x86_64
#if defined(MACHREGS_i386) || defined(MACHREGS_x86_64)
# if MACHREGS_i386
# if defined(MACHREGS_i386)
# define eax 0
# define ebx 1
# define ecx 2
......@@ -21,7 +22,7 @@ import Reg
# define esp 7
# endif
# if MACHREGS_x86_64
# if defined(MACHREGS_x86_64)
# define rax 0
# define rbx 1
# define rcx 2
......@@ -103,7 +104,8 @@ import Reg
-- I'm not sure if these are the correct numberings.
-- Normally, the register names are just stringified as part of the REG() macro
#elif MACHREGS_powerpc || MACHREGS_arm || MACHREGS_aarch64
#elif defined(MACHREGS_powerpc) || defined(MACHREGS_arm) \
|| defined(MACHREGS_aarch64)
# define r0 0
# define r1 1
......@@ -138,9 +140,10 @@ import Reg
# define r30 30
# define r31 31
-- See note above. These aren't actually used for anything except satisfying the compiler for globalRegMaybe
-- so I'm unsure if they're the correct numberings, should they ever be attempted to be used in the NCG.
#if MACHREGS_aarch64 || MACHREGS_arm
-- See note above. These aren't actually used for anything except satisfying
-- the compiler for globalRegMaybe so I'm unsure if they're the correct
-- numberings, should they ever be attempted to be used in the NCG.
#if defined(MACHREGS_aarch64) || defined(MACHREGS_arm)
# define s0 32
# define s1 33
# define s2 34
......@@ -208,7 +211,7 @@ import Reg
# define d31 63
#endif
# if MACHREGS_darwin
# if defined(MACHREGS_darwin)
# define f0 32
# define f1 33
# define f2 34
......@@ -276,7 +279,7 @@ import Reg
# define fr31 63
# endif
#elif MACHREGS_sparc
#elif defined(MACHREGS_sparc)
# define g0 0
# define g1 1
......@@ -631,7 +634,9 @@ haveRegBase = False
-- in a real machine register, otherwise returns @'Just' reg@, where
-- reg is the machine register it is stored in.
globalRegMaybe :: GlobalReg -> Maybe RealReg
#if MACHREGS_i386 || MACHREGS_x86_64 || MACHREGS_sparc || MACHREGS_powerpc || MACHREGS_arm || MACHREGS_aarch64
#if defined(MACHREGS_i386) || defined(MACHREGS_x86_64) \
|| defined(MACHREGS_sparc) || defined(MACHREGS_powerpc) \
|| defined(MACHREGS_arm) || defined(MACHREGS_aarch64)
# ifdef REG_Base
globalRegMaybe BaseReg = Just (RealRegSingle REG_Base)
# endif
......@@ -685,7 +690,7 @@ globalRegMaybe (FloatReg 6) = Just (RealRegSingle REG_F6)
# endif
# ifdef REG_D1
globalRegMaybe (DoubleReg 1) =
# if MACHREGS_sparc
# if defined(MACHREGS_sparc)
Just (RealRegPair REG_D1 (REG_D1 + 1))
# else
Just (RealRegSingle REG_D1)
......@@ -693,7 +698,7 @@ globalRegMaybe (DoubleReg 1) =
# endif
# ifdef REG_D2
globalRegMaybe (DoubleReg 2) =
# if MACHREGS_sparc
# if defined(MACHREGS_sparc)
Just (RealRegPair REG_D2 (REG_D2 + 1))
# else
Just (RealRegSingle REG_D2)
......@@ -701,7 +706,7 @@ globalRegMaybe (DoubleReg 2) =
# endif
# ifdef REG_D3
globalRegMaybe (DoubleReg 3) =
# if MACHREGS_sparc
# if defined(MACHREGS_sparc)
Just (RealRegPair REG_D3 (REG_D3 + 1))
# else
Just (RealRegSingle REG_D3)
......@@ -709,7 +714,7 @@ globalRegMaybe (DoubleReg 3) =
# endif
# ifdef REG_D4
globalRegMaybe (DoubleReg 4) =
# if MACHREGS_sparc
# if defined(MACHREGS_sparc)
Just (RealRegPair REG_D4 (REG_D4 + 1))
# else
Just (RealRegSingle REG_D4)
......@@ -717,7 +722,7 @@ globalRegMaybe (DoubleReg 4) =
# endif
# ifdef REG_D5
globalRegMaybe (DoubleReg 5) =
# if MACHREGS_sparc
# if defined(MACHREGS_sparc)
Just (RealRegPair REG_D5 (REG_D5 + 1))
# else
Just (RealRegSingle REG_D5)
......@@ -725,7 +730,7 @@ globalRegMaybe (DoubleReg 5) =
# endif
# ifdef REG_D6
globalRegMaybe (DoubleReg 6) =
# if MACHREGS_sparc
# if defined(MACHREGS_sparc)
Just (RealRegPair REG_D6 (REG_D6 + 1))
# else
Just (RealRegSingle REG_D6)
......@@ -751,7 +756,7 @@ globalRegMaybe (XmmReg 5) = Just (RealRegSingle REG_XMM5)
globalRegMaybe (XmmReg 6) = Just (RealRegSingle REG_XMM6)
# endif
# endif
# if MAX_REAL_YMM_REG != 0
# if defined MAX_REAL_YMM_REG && MAX_REAL_YMM_REG != 0
# ifdef REG_YMM1
globalRegMaybe (YmmReg 1) = Just (RealRegSingle REG_YMM1)
# endif
......@@ -771,7 +776,7 @@ globalRegMaybe (YmmReg 5) = Just (RealRegSingle REG_YMM5)
globalRegMaybe (YmmReg 6) = Just (RealRegSingle REG_YMM6)
# endif
# endif
# if MAX_REAL_ZMM_REG != 0
# if defined MAX_REAL_ZMM_REG && MAX_REAL_ZMM_REG != 0
# ifdef REG_ZMM1
globalRegMaybe (ZmmReg 1) = Just (RealRegSingle REG_ZMM1)
# endif
......@@ -819,7 +824,7 @@ globalRegMaybe CurrentNursery = Just (RealRegSingle REG_CurrentNursery
globalRegMaybe MachSp = Just (RealRegSingle REG_MachSp)
# endif
globalRegMaybe _ = Nothing
#elif MACHREGS_NO_REGS
#elif defined MACHREGS_NO_REGS
globalRegMaybe _ = Nothing
#else
globalRegMaybe = panic "globalRegMaybe not defined for this platform"
......@@ -827,14 +832,14 @@ globalRegMaybe = panic "globalRegMaybe not defined for this platform"
freeReg :: RegNo -> Bool
#if MACHREGS_i386 || MACHREGS_x86_64
#if defined(MACHREGS_i386) || defined(MACHREGS_x86_64)
# if MACHREGS_i386
# if defined(MACHREGS_i386)
freeReg esp = False -- %esp is the C stack pointer
freeReg esi = False -- Note [esi/edi not allocatable]
freeReg edi = False
# endif
# if MACHREGS_x86_64
# if defined(MACHREGS_x86_64)
freeReg rsp = False -- %rsp is the C stack pointer
# endif
......@@ -875,14 +880,14 @@ freeRegBase REG_HpLim = False
-- their liveness accurately.
freeRegBase _ = True
#elif MACHREGS_powerpc
#elif defined(MACHREGS_powerpc)
freeReg 0 = False -- Used by code setting the back chain pointer
-- in stack reallocations on Linux
-- r0 is not usable in all insns so also reserved
-- on Darwin.
freeReg 1 = False -- The Stack Pointer
# if !MACHREGS_darwin
# if !defined(MACHREGS_darwin)
-- most non-darwin powerpc OSes use r2 as a TOC pointer or something like that
freeReg 2 = False
freeReg 13 = False -- reserved for system thread ID on 64 bit
......@@ -983,7 +988,7 @@ freeReg REG_HpLim = False
# endif
freeReg _ = True
#elif MACHREGS_sparc
#elif defined(MACHREGS_sparc)
-- SPARC regs used by the OS / ABI
-- %g0(r0) is always zero
......
......@@ -147,7 +147,7 @@
// to force gnu90-style 'external inline' semantics.
#if defined(FORCE_GNU_INLINE)
// disable auto-detection since HAVE_GNU_INLINE has been defined externally
#elif __GNUC_GNU_INLINE__ && __GNUC__ == 4 && __GNUC_MINOR__ == 2
#elif defined(__GNUC_GNU_INLINE__) && __GNUC__ == 4 && __GNUC_MINOR__ == 2
// GCC 4.2.x didn't properly support C99 inline semantics (GCC 4.3 was the first
// release to properly support C99 inline semantics), and therefore warned when
// using 'extern inline' while in C99 mode unless `__attributes__((gnu_inline))`
......@@ -155,14 +155,14 @@
# define FORCE_GNU_INLINE 1
#endif
#if FORCE_GNU_INLINE
#ifdef FORCE_GNU_INLINE
// Force compiler into gnu90 semantics
# if defined(KEEP_INLINES)
# define EXTERN_INLINE inline __attribute__((gnu_inline))
# else
# define EXTERN_INLINE extern inline __attribute__((gnu_inline))
# endif
#elif __GNUC_GNU_INLINE__
#elif defined(__GNUC_GNU_INLINE__)
// we're currently in gnu90 inline mode by default and
// __attribute__((gnu_inline)) may not be supported, so better leave it off
# if defined(KEEP_INLINES)
......
......@@ -17,7 +17,7 @@
#if defined(HAVE_PTHREAD_H) && !defined(mingw32_HOST_OS)
#if CMINUSMINUS
#ifdef CMINUSMINUS
#define OS_ACQUIRE_LOCK(mutex) foreign "C" pthread_mutex_lock(mutex)
#define OS_RELEASE_LOCK(mutex) foreign "C" pthread_mutex_unlock(mutex)
......@@ -76,7 +76,7 @@ EXTERN_INLINE int TRY_ACQUIRE_LOCK(pthread_mutex_t *mutex)
# elif defined(HAVE_WINDOWS_H)
#if CMINUSMINUS
#ifdef CMINUSMINUS
/* We jump through a hoop here to get a CCall EnterCriticalSection
and LeaveCriticalSection, as that's what C-- wants. */
......
......@@ -33,14 +33,34 @@
#define MACHREGS_NO_REGS 0
#define MACHREGS_i386 i386_TARGET_ARCH
#define MACHREGS_x86_64 x86_64_TARGET_ARCH
#define MACHREGS_powerpc (powerpc_TARGET_ARCH || powerpc64_TARGET_ARCH \
|| powerpc64le_TARGET_ARCH || rs6000_TARGET_ARCH)
#define MACHREGS_sparc sparc_TARGET_ARCH
#define MACHREGS_arm arm_TARGET_ARCH
#define MACHREGS_aarch64 aarch64_TARGET_ARCH
#define MACHREGS_darwin darwin_TARGET_OS
#ifdef i386_TARGET_ARCH
#define MACHREGS_i386 1
#endif
#ifdef x86_64_TARGET_ARCH
#define MACHREGS_x86_64 1
#endif
#if defined(powerpc_TARGET_ARCH) || defined(powerpc64_TARGET_ARCH) \
|| defined(powerpc64le_TARGET_ARCH) || defined(rs6000_TARGET_ARCH)
#define MACHREGS_powerpc 1
#endif
#ifdef sparc_TARGET_ARCH
#define MACHREGS_sparc 1
#endif
#ifdef arm_TARGET_ARCH
#define MACHREGS_arm 1
#endif
#ifdef aarch64_TARGET_ARCH
#define MACHREGS_aarch64 1
#endif
#ifdef darwin_TARGET_OS
#define MACHREGS_darwin 1
#endif
#endif
......
......@@ -82,7 +82,7 @@
Leaving SpLim out of the picture.
-------------------------------------------------------------------------- */
#if MACHREGS_i386
#ifdef MACHREGS_i386
#define REG(x) __asm__("%" #x)
......@@ -156,7 +156,7 @@
--------------------------------------------------------------------------- */
#elif MACHREGS_x86_64
#elif defined(MACHREGS_x86_64)
#define REG(x) __asm__("%" #x)
......@@ -303,7 +303,7 @@ the stack. See Note [Overlapping global registers] for implications.
We can do the Whole Business with callee-save registers only!
-------------------------------------------------------------------------- */
#elif MACHREGS_powerpc
#elif defined(MACHREGS_powerpc)
#define REG(x) __asm__(#x)
......@@ -316,7 +316,7 @@ the stack. See Note [Overlapping global registers] for implications.
#define REG_R7 r20
#define REG_R8 r21
#if MACHREGS_darwin
#ifdef MACHREGS_darwin
#define REG_F1 f14
#define REG_F2 f15
......@@ -442,7 +442,7 @@ the stack. See Note [Overlapping global registers] for implications.
-------------------------------------------------------------------------- */
#elif MACHREGS_sparc
#elif defined(MACHREGS_sparc)
#define REG(x) __asm__("%" #x)
......@@ -521,7 +521,7 @@ the stack. See Note [Overlapping global registers] for implications.
d16-d31/q8-q15 Argument / result/ scratch registers
----------------------------------------------------------------------------- */
#elif MACHREGS_arm
#elif defined(MACHREGS_arm)
#define REG(x) __asm__(#x)
......@@ -578,7 +578,7 @@ the stack. See Note [Overlapping global registers] for implications.
----------------------------------------------------------------------------- */
#elif MACHREGS_aarch64
#elif defined(MACHREGS_aarch64)
#define REG(x) __asm__(#x)
......
......@@ -39,14 +39,34 @@
#define MACHREGS_NO_REGS 0
#define MACHREGS_i386 i386_HOST_ARCH
#define MACHREGS_x86_64 x86_64_HOST_ARCH
#define MACHREGS_powerpc (powerpc_HOST_ARCH || powerpc64_HOST_ARCH \
|| powerpc64le_HOST_ARCH || rs6000_HOST_ARCH)
#define MACHREGS_sparc sparc_HOST_ARCH
#define MACHREGS_arm arm_HOST_ARCH
#define MACHREGS_aarch64 aarch64_HOST_ARCH
#define MACHREGS_darwin darwin_HOST_OS
#ifdef i386_HOST_ARCH
#define MACHREGS_i386 1
#endif
#ifdef x86_64_HOST_ARCH
#define MACHREGS_x86_64 1
#endif
#if defined(powerpc_HOST_ARCH) || defined(powerpc64_HOST_ARCH) \
|| defined(powerpc64le_HOST_ARCH) || defined(rs6000_HOST_ARCH)
#define MACHREGS_powerpc 1
#endif
#ifdef sparc_HOST_ARCH
#define MACHREGS_sparc 1
#endif
#ifdef arm_HOST_ARCH
#define MACHREGS_arm 1
#endif
#ifdef aarch64_HOST_ARCH
#define MACHREGS_aarch64 1
#endif
#ifdef darwin_HOST_OS
#define MACHREGS_darwin 1
#endif
#endif
......
......@@ -14,7 +14,7 @@
#ifndef SMP_H
#define SMP_H
#if arm_HOST_ARCH && defined(arm_HOST_ARCH_PRE_ARMv6)
#if defined(arm_HOST_ARCH) && defined(arm_HOST_ARCH_PRE_ARMv6)
void arm_atomic_spin_lock(void);
void arm_atomic_spin_unlock(void);
#endif
......@@ -187,14 +187,15 @@ EXTERN_INLINE void
write_barrier(void) {
#if defined(NOSMP)
return;
#elif i386_HOST_ARCH || x86_64_HOST_ARCH
#elif defined(i386_HOST_ARCH) || defined(x86_64_HOST_ARCH)
__asm__ __volatile__ ("" : : : "memory");
#elif powerpc_HOST_ARCH || powerpc64_HOST_ARCH || powerpc64le_HOST_ARCH
#elif defined(powerpc_HOST_ARCH) || defined(powerpc64_HOST_ARCH) \
|| defined(powerpc64le_HOST_ARCH)
__asm__ __volatile__ ("lwsync" : : : "memory");
#elif sparc_HOST_ARCH
#elif defined(sparc_HOST_ARCH)
/* Sparc in TSO mode does not require store/store barriers. */
__asm__ __volatile__ ("" : : : "memory");
#elif (arm_HOST_ARCH) || aarch64_HOST_ARCH
#elif defined(arm_HOST_ARCH) || defined(aarch64_HOST_ARCH)
__asm__ __volatile__ ("dmb st" : : : "memory");
#else
#error memory barriers unimplemented on this architecture
......@@ -205,17 +206,18 @@ EXTERN_INLINE void
store_load_barrier(void) {
#if defined(NOSMP)
return;
#elif i386_HOST_ARCH
#elif defined(i386_HOST_ARCH)
__asm__ __volatile__ ("lock; addl $0,0(%%esp)" : : : "memory");
#elif x86_64_HOST_ARCH
#elif defined(x86_64_HOST_ARCH)
__asm__ __volatile__ ("lock; addq $0,0(%%rsp)" : : : "memory");
#elif powerpc_HOST_ARCH || powerpc64_HOST_ARCH || powerpc64le_HOST_ARCH
#elif defined(powerpc_HOST_ARCH) || defined(powerpc64_HOST_ARCH) \
|| defined(powerpc64le_HOST_ARCH)
__asm__ __volatile__ ("sync" : : : "memory");
#elif sparc_HOST_ARCH
#elif defined(sparc_HOST_ARCH)
__asm__ __volatile__ ("membar #StoreLoad" : : : "memory");
#elif arm_HOST_ARCH
#elif defined(arm_HOST_ARCH)
__asm__ __volatile__ ("dmb" : : : "memory");
#elif aarch64_HOST_ARCH
#elif defined(aarch64_HOST_ARCH)
__asm__ __volatile__ ("dmb sy" : : : "memory");
#else
#error memory barriers unimplemented on this architecture
......@@ -226,18 +228,19 @@ EXTERN_INLINE void
load_load_barrier(void) {
#if defined(NOSMP)
return;
#elif i386_HOST_ARCH
#elif defined(i386_HOST_ARCH)
__asm__ __volatile__ ("" : : : "memory");
#elif x86_64_HOST_ARCH
#elif defined(x86_64_HOST_ARCH)
__asm__ __volatile__ ("" : : : "memory");
#elif powerpc_HOST_ARCH || powerpc64_HOST_ARCH || powerpc64le_HOST_ARCH
#elif defined(powerpc_HOST_ARCH) || defined(powerpc64_HOST_ARCH) \
|| defined(powerpc64le_HOST_ARCH)
__asm__ __volatile__ ("lwsync" : : : "memory");
#elif sparc_HOST_ARCH
#elif defined(sparc_HOST_ARCH)
/* Sparc in TSO mode does not require load/load barriers. */
__asm__ __volatile__ ("" : : : "memory");
#elif arm_HOST_ARCH
#elif defined(arm_HOST_ARCH)
__asm__ __volatile__ ("dmb" : : : "memory");
#elif aarch64_HOST_ARCH
#elif defined(aarch64_HOST_ARCH)
__asm__ __volatile__ ("dmb sy" : : : "memory");
#else
#error memory barriers unimplemented on this architecture
......
......@@ -187,7 +187,7 @@ cLeadingUnderscore = False
#endif
isWindowsHost :: Bool
#if mingw32_HOST_OS
#ifdef mingw32_HOST_OS
isWindowsHost = True
#else
isWindowsHost = False
......
......@@ -8,8 +8,8 @@ SRC_HC_OPTS += -Wall
# isn't supported yet (https://ghc.haskell.org/trac/ghc/wiki/Design/Warnings).
#
# See Note [Stage number in build variables] in mk/config.mk.in.
SRC_HC_OPTS_STAGE1 += $(WERROR)
SRC_HC_OPTS_STAGE2 += $(WERROR)
SRC_HC_OPTS_STAGE1 += $(WERROR) -Wcpp-undef
SRC_HC_OPTS_STAGE2 += $(WERROR) -Wcpp-undef
ifneq "$(GccIsClang)" "YES"
......
......@@ -91,7 +91,8 @@ typedef struct ForeignExportStablePtr_ {
struct ForeignExportStablePtr_ *next;
} ForeignExportStablePtr;
#if powerpc_HOST_ARCH || x86_64_HOST_ARCH || arm_HOST_ARCH
#if defined(powerpc_HOST_ARCH) || defined(x86_64_HOST_ARCH) \
|| defined(arm_HOST_ARCH)
/* ios currently uses adjacent got tables, and no symbol extras */
#if !defined(ios_HOST_OS)
#define NEED_SYMBOL_EXTRAS 1
......@@ -102,17 +103,17 @@ typedef struct ForeignExportStablePtr_ {
* address relocations on the PowerPC, x86_64 and ARM.
*/
typedef struct {
#ifdef powerpc_HOST_ARCH
#if defined(powerpc_HOST_ARCH)
struct {
short lis_r12, hi_addr;
short ori_r12_r12, lo_addr;
long mtctr_r12;
long bctr;
} jumpIsland;
#elif x86_64_HOST_ARCH
#elif defined(x86_64_HOST_ARCH)
uint64_t addr;
uint8_t jumpIsland[6];
#elif arm_HOST_ARCH
#elif defined(arm_HOST_ARCH)
uint8_t jumpIsland[16];
#endif
} SymbolExtra;
......@@ -283,7 +284,7 @@ ObjectCode* mkOc( pathchar *path, char *image, int imageSize,
int misalignment
);
#if defined (mingw32_HOST_OS)
#if defined(mingw32_HOST_OS)
/* We use myindex to calculate array addresses, rather than
simply doing the normal subscript thing. That's because
some of the above structs have sizes which are not
......
......@@ -20,7 +20,7 @@
#include <sched.h>
#endif
#if arm_HOST_ARCH && defined(arm_HOST_ARCH_PRE_ARMv6)
#if defined(arm_HOST_ARCH) && defined(arm_HOST_ARCH_PRE_ARMv6)
static volatile int atomic_spin = 0;
......
......@@ -561,7 +561,7 @@ stg_atomicModifyMutVarzh ( gcptr mv, gcptr f )
r = [stg_sel_1 z] (max (HS + 1) MIN_UPD_SIZE)
*/
#if MIN_UPD_SIZE > 1
#if defined(MIN_UPD_SIZE) && MIN_UPD_SIZE > 1
#define THUNK_1_SIZE (SIZEOF_StgThunkHeader + WDS(MIN_UPD_SIZE))
#define TICK_ALLOC_THUNK_1() TICK_ALLOC_UP_THK(WDS(1),WDS(MIN_UPD_SIZE-1))
#else
......@@ -569,7 +569,7 @@ stg_atomicModifyMutVarzh ( gcptr mv, gcptr f )
#define TICK_ALLOC_THUNK_1() TICK_ALLOC_UP_THK(WDS(1),0)
#endif
#if MIN_UPD_SIZE > 2
#if defined(MIN_UPD_SIZE) && MIN_UPD_SIZE > 2
#define THUNK_2_SIZE (SIZEOF_StgThunkHeader + WDS(MIN_UPD_SIZE))
#define TICK_ALLOC_THUNK_2() TICK_ALLOC_UP_THK(WDS(2),WDS(MIN_UPD_SIZE-2))
#else
......
......@@ -22,7 +22,7 @@
/* HACK: On Mac OS X 10.4 (at least), time.h doesn't declare ctime_r with
* _POSIX_C_SOURCE. If this is the case, we declare it ourselves.
*/
#if HAVE_CTIME_R && !HAVE_DECL_CTIME_R
#if defined(HAVE_CTIME_R) && !HAVE_DECL_CTIME_R
extern char *ctime_r(const time_t *, char *);
#endif
......@@ -164,7 +164,7 @@ time_str(void)
if (now == 0) {
time(&now);
#if HAVE_CTIME_R
#if defined(HAVE_CTIME_R)
ctime_r(&now, nowstr);
#else
strcpy(nowstr, ctime(&now));
......
......@@ -411,7 +411,7 @@ run_thread:
prev_what_next = t->what_next;
errno = t->saved_errno;
#if mingw32_HOST_OS
#ifdef mingw32_HOST_OS
SetLastError(t->saved_winerror);
#endif
......@@ -490,7 +490,7 @@ run_thread:
// XXX: possibly bogus for SMP because this thread might already
// be running again, see code below.
t->saved_errno = errno;
#if mingw32_HOST_OS
#ifdef mingw32_HOST_OS
// Similarly for Windows error code
t->saved_winerror = GetLastError();
#endif
......@@ -2374,12 +2374,12 @@ suspendThread (StgRegTable *reg, bool interruptible)
int saved_errno;
StgTSO *tso;
Task *task;
#if mingw32_HOST_OS
#ifdef mingw32_HOST_OS
StgWord32 saved_winerror;
#endif
saved_errno = errno;
#if mingw32_HOST_OS
#ifdef mingw32_HOST_OS
saved_winerror = GetLastError();
#endif
......@@ -2419,7 +2419,7 @@ suspendThread (StgRegTable *reg, bool interruptible)
RELEASE_LOCK(&cap->lock);
errno = saved_errno;
#if mingw32_HOST_OS
#ifdef mingw32_HOST_OS
SetLastError(saved_winerror);
#endif
return task;
...