GitLab

Erik de Castro Lopo authored Jul 31, 2012 and pcapriotti committed Aug 13, 2012

Slightly modified version of a patch from Ben Collins <bcollins@ubuntu.com>
who did the final debugging that showed the segfault was being caused the
memory protection mechanism.

Due to the requirement of "jump islands" to handle 24 bit relative jump
offsets, GHCi on PowerPC did not use mmap to load object files like the
other architectures. Instead, it allocated memory using malloc and fread
to load the object code. However there is a quirk in the GNU libc malloc
implementation. For memory regions over certain size (dynamic and
configurable), malloc will use mmap to obtain the required memory instead
of sbrk and malloc's call to mmap sets the memory readable and writable,
but not executable. That means when GHCi loads code into a memory region
that was mmapped instead of malloc-ed and tries to execute it we get a
segfault.

This solution drops the malloc/fread object loading in favour of using
mmap and then puts the jump island for each object code module at the
end of the mmaped region for that object.

This patch may also be a solution on other ELF based powerpc systems
but does not work on darwin-powerpc.

Patch by Patrick Palka <patrick@parcs.ath.cx>

Also, print that message on stdout.

Pick longest flag when more than one matches in findArg.

This fixes an issue where -ignore-dot-ghci wasn't honored, because the
flag was parsed as "-i gnore-dot-ghci".

mad.one@gmail.com authored Aug 05, 2012 and pcapriotti committed Aug 13, 2012

In particular, many of the restrictions on using unboxed tuples went
away thanks to Max Bolingbroke, and they can now be bound to variables
without pattern matching, and passed as arguments.

Also fix a little formatting in glasgow-exts.xml. Some other parts
of this section may be out of date.
Signed-off-by: Austin Seipp <mad.one@gmail.com>

mad.one@gmail.com authored Aug 05, 2012 and pcapriotti committed Aug 13, 2012

Supresses an ugly warning from gcc 4.6+ saying this is a C/ObjC flag
only.
Signed-off-by: Austin Seipp <mad.one@gmail.com>

This allows us to provide access to them in the base library.

Simon Marlow authored Aug 09, 2012 and chak@cse.unsw.edu.au. committed Aug 09, 2012

When refactoring this recently I accidentally put the
dead-strip-preventer symbol (only used on OS X) in the wrong section.

Now that it's included in settings, the bindist configure script needs
to know it.

The problem occurred when the idle GC was turned off with +RTS -I0.
Then the scheduler would go into the state ACTIVITY_DONE_GC directly
without doing a GC, and a subsequent GC would put it back to
ACTIVITY_YES but without turning the timer back on.  Instead if the GC
finds the state is ACTIVITY_DONE_GC it should leave it there.

See comments.

We weren't passing the arguments correctly to the GC functions, which
usually happened to work because the arguments were in the right
registers already.

After this fix the profiling tests go through with the new code
generator.

When calling newCAF, refer to the closure using its LocalReg rather
than R1.  Using R1 here was preventing the register allocator from
coalescing the assignment x=R1 at the beginning of the function.

aargh.

This saves compile time and can make a big difference in some
pathological cases (T4801)

This means that we now generate the same code whatever platform we are
on, which should help avoid changes on one platform breaking the build
on another.

It's also another step towards full cross-compilation.

To explicitly choose whether you want an unregisterised build you now
need to use the "--enable-unregisterised"/"--disable-unregisterised"
configure flags.

This is a bit odd by itself, but it's a stepping stone on the way to
putting "target unregisterised" into the settings file.

No functional differences yet