compiler/coreSyn/MkCore.hs · ghc-8.10.7-release · Tobias Haslop / GHC

Blame

Forked from Glasgow Haskell Compiler / GHC

Source project has a limited visibility.

6 years ago

3b9d4907

Note [Don't flatten tuples from HsSyn] in MkCore · 3b9d4907

Richard Eisenberg authored 6 years ago and

Marge Bot committed 5 years ago

Previously, we would sometimes flatten 1-tuples and sometimes
not. This didn't cause damage because there is no way to
generate HsSyn with 1-tuples. But, with the upcoming fix to #16881,
there will be. Without this patch, obscure lint errors would
have resulted.

No test case, as there is not yet a way to tickle this.

3b9d4907

History

Note [Don't flatten tuples from HsSyn] in MkCore

Richard Eisenberg authored 6 years ago and

Marge Bot committed 5 years ago

Previously, we would sometimes flatten 1-tuples and sometimes
not. This didn't cause damage because there is no way to
generate HsSyn with 1-tuples. But, with the upcoming fix to #16881,
there will be. Without this patch, obscure lint errors would
have resulted.

No test case, as there is not yet a way to tickle this.

Code owners

Assign users and groups as approvers for specific file changes. Learn more.