1. 02 Mar, 2015 11 commits
    • thomie's avatar
      Fix typecheck tests (--slow) · ca478acc
      thomie authored
      Summary:
      Fallout from AMP, recent addition of -fwarn-redundant-constraints and others.
      Some of these tests need `mtl` or `syb` to run.
      
      Reviewers: austin
      
      Reviewed By: austin
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D684
      ca478acc
    • thomie's avatar
      Fix detection of llvm-x.x · 1dfab7a8
      thomie authored
      Summary:
      Four bug fixes and a little refactoring.
      * `find -perm \mode` should be `find -perm /mode` (#9697)
      
      * `find -regex '$3' should be `find -regex "$3"` (#7661)
      
      From `man sh` on my system (Ubuntu 14.04):
      "Enclosing characters in single quotes preserves the literal meaning of all
      the characters ..."
      
      * LlcCmd and OptCmd should be passed to ghc, using `-pgmlo` and `-pgmlc`, for
        detection of #9439.
      
      * -pgmlo and -pgmlc were undocumented because of an xml tag misplacement.
      
      Test Plan:
      The aclocal.m4 macro has seen about 10 iterations since its inception. Without a
      testsuite, I can't guarantee this version is bug free either. It's all pretty
      frustrating.
      
      Reviewers: bgamari, austin
      
      Reviewed By: austin
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D683
      
      GHC Trac Issues: #9697, #7661, #9439
      1dfab7a8
    • Javran Cheng's avatar
      fix typos in coreSyn · 6cdccb46
      Javran Cheng authored
      Summary: fixed few typos in coreSyn, no trac number
      
      Test Plan: validate
      
      Reviewers: austin
      
      Reviewed By: austin
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D682
      6cdccb46
    • thomie's avatar
      Show record construction/update without parens · 5692643c
      thomie authored
      Summary:
      The 2010 report mentions:
      "The result of `show` is a syntactically correct Haskell expression ...
      Parenthesis are only added where needed, //ignoring associativity//".
      
      Reviewers: austin
      
      Reviewed By: austin
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D669
      
      GHC Trac Issues: #2530
      5692643c
    • Simon Peyton Jones's avatar
      Improve documentation of infinite inlining bug · d2e6a3b5
      Simon Peyton Jones authored
      This fixes the documentation suggestion in Trac #10105
      d2e6a3b5
    • Simon Peyton Jones's avatar
      Two kind-polymorphism fixes (Trac #10122) · cabe1748
      Simon Peyton Jones authored
      * The original fix was to improve the documentation, in
        line with the suggestions on Trac #10122
      
      * But in doing so I realised that the kind generalisation in
        TcRnDriver.tcRnType was completely wrong.  So I fixed that
        and updated Note [Kind-generalise in tcRnType] to explain.
      cabe1748
    • Simon Peyton Jones's avatar
      Comments only · 52dfa616
      Simon Peyton Jones authored
      52dfa616
    • Simon Peyton Jones's avatar
      Test Trac #10112 · 104c0ad5
      Simon Peyton Jones authored
      104c0ad5
    • Simon Peyton Jones's avatar
      Improve comments on coreView/tcView, and combine coreExpandTyCon/tcExpandTyCon · 9b3239f8
      Simon Peyton Jones authored
      This is minor stuff triggered by Trac #10103.
      
      * Fix outdated comments on tcView/coreView (we should really combine
        them with a new name, but I'll leave that slightly-disruptive change
        for now)
      
      * Combine tcExpandTyCon_maybe and coreExpandTyCon_maybe (which were identical)
        into expandSynTyCon_maybe
      
      * A few more comment fixups
      9b3239f8
    • Simon Peyton Jones's avatar
      Comments only · 77273719
      Simon Peyton Jones authored
      77273719
    • Joachim Breitner's avatar
      Extend the docs for Data.List.transpose · c5977c2e
      Joachim Breitner authored
      by giving a sufficient general example to explain what happens when the
      rows are not of the same lengths. Thanks to Doug McIlroy for the
      suggestoin. Fixes #10128.
      c5977c2e
  2. 27 Feb, 2015 1 commit
  3. 26 Feb, 2015 1 commit
  4. 24 Feb, 2015 4 commits
  5. 23 Feb, 2015 18 commits
    • Oleg Grenrus's avatar
      driver: split -fwarn-unused-binds into 3 flags (fixes #17) · aead0190
      Oleg Grenrus authored
      Summary: New flags:
      
       -fwarn-unused-top-binds
       -fwarn-unused-local-binds
       -fwarn-unused-pattern-binds
      
      Test Plan: `tests/rename/should_compile/T17` tests
      
      Correct other tests
      
      Reviewers: austin, rwbarton
      
      Reviewed By: austin, rwbarton
      
      Subscribers: rwbarton, carter, thomie
      
      Differential Revision: https://phabricator.haskell.org/D591
      
      GHC Trac Issues: #17
      aead0190
    • Joachim Breitner's avatar
      Comment typo · 26a85bd8
      Joachim Breitner authored
      and reference to long-removed note in CallArity.hs
      26a85bd8
    • Wieland Hoffmann's avatar
      System.IO.Error: Fix a documentation link to Control.Exception.Exception · bb3b71a0
      Wieland Hoffmann authored
      Instead of using double quotes (which are used to link to modules), use
      single quotes (that are used to link, among others, to link to types,
      which C.E.Exception is).
      Signed-off-by: default avatarAustin Seipp <austin@well-typed.com>
      bb3b71a0
    • Austin Seipp's avatar
      testsuite: update .gitignore · d1d02e80
      Austin Seipp authored
      Signed-off-by: default avatarAustin Seipp <austin@well-typed.com>
      d1d02e80
    • redneb's avatar
      Provide a faster implementation for the Read Integer instance · a5a4c256
      redneb authored
      Summary:
      The current implementation of the Read Integer instance has quadratic
      complexity and thus performs badly on large inputs. This patch provides a
      rather simple sub-quadratic algorithm. For small inputs, we use the old
      algorithm (there is a small penalty for that). The gains for large
      inputs can be dramatic: on my system, the time to perform
          read (take 1000000 $ cycle "1234567890") :: Integer
      drops from 65 seconds to less than a second.
      
      Note that we already provide an ad-hoc instance for Show Integer, so this
      patch essentially does the same thing for Read Integer.
      
      Test Plan: Check that read :: String -> Integer returns correct results for inputs of various sizes.
      
      Reviewers: austin, hvr
      
      Reviewed By: austin, hvr
      
      Subscribers: ekmett, thomie
      
      Differential Revision: https://phabricator.haskell.org/D645
      
      GHC Trac Issues: #10067
      a5a4c256
    • lukyanov's avatar
      base: Fix (**) implementation for Data.Complex · 4f467b2e
      lukyanov authored
      See the extensive discussion in #8539.
      Signed-off-by: default avatarAustin Seipp <austin@well-typed.com>
      4f467b2e
    • Austin Seipp's avatar
      9004f0d2
    • Austin Seipp's avatar
      base: fix broken link (#10088) · 266fa701
      Austin Seipp authored
      Signed-off-by: default avatarAustin Seipp <austin@well-typed.com>
      266fa701
    • Austin Seipp's avatar
      docs: Flatten MAKEHELP/SUBMAKEHELP · c3f9eb4d
      Austin Seipp authored
      There's no reason to have two files, and this is one step towards a
      cleaner root directory.
      Signed-off-by: default avatarAustin Seipp <austin@well-typed.com>
      c3f9eb4d
    • Austin Seipp's avatar
      docs: add INSTALL.md to root dir (#9926) · 9a1c8d96
      Austin Seipp authored
      This gives a very quick rundown on installation for end-users (HACKING
      etc is for developers/possible contributors).
      Signed-off-by: default avatarAustin Seipp <austin@well-typed.com>
      9a1c8d96
    • thomie's avatar
      Show '#' on unboxed literals · 47175e06
      thomie authored
      Test Plan: deriving/should_run/T10104
      
      Reviewers: austin, jstolarek
      
      Reviewed By: austin, jstolarek
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D672
      
      GHC Trac Issues: #10104
      47175e06
    • Tamar Christina's avatar
      rts/linker: ignore unknown PE sections · a293925d
      Tamar Christina authored
      Summary: Currently the linker tries to see if it understands/knows every section in the PE file before it continues. If it encounters a section it doesn't know about it errors out. Every time there's a change in MinGW compiler that adds a new section to the PE file this will break the ghc linker. The new sections don't need to be understood by `ghc` to continue so instead of erroring out the section is just ignored. When running with `-debug` the sections that are ignored will be printed.
      
      Test Plan:
      See the file `ghcilinkerbug.zip` in #9907.
      
       1) unzip file content.
       2) open examplecpp.cabal and change base <4.8 to <4.9.
       3) execute cabal file with cabal repl.
      
      Applying the patch makes `cabal repl` in step 3) work.
      
      Note that the file will fail on a `___mingw_vprintf` not being found. This is because of the `cc-options` specifying `-std=c++0x`, which will also require `libmingwex.a` to be linked in but wasn't specified in the cabal file. To fix this, remove the `cc-options` which defaults to c99.
      
      Reviewers: austin
      
      Reviewed By: austin
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D671
      
      GHC Trac Issues: #9907, #7103, #10051, #7056, #8546
      a293925d
    • thomie's avatar
      Declare some Makefile targets to be PHONY · a0ef626e
      thomie authored
      Summary:
      Given:
        a Makefile with a non-PHONY target called `target`
      If:
        after running `make target`, a file exists with the same name as `target`
        (it was either already there, or it was created by running `make target`)
      And:
        `target` has no dependencies, such as `clean`, that modify or delete that
        file
      Then:
        subsequent invocations of `make target` will not have any effect.
      
      Solution: make `target` PHONY.
      
      BAD:
        ```
        foo:
                ...
                ./foo
        ```
      
      BETTER:
        ```
        foo:
                ...
                ./foo
        .PHONY: foo
        ```
      
      Reviewers: austin
      
      Reviewed By: austin
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D670
      a0ef626e
    • thomie's avatar
      Always ignore user-package-db when running tests · 30dc59e8
      thomie authored
      Summary:
      The user package database was already ignored for systems that
      `have_subprocess`.
      
      To [wiki:Debugging/InstallingPackagesInplace install] a package inplace:
      `cabal install
        --with-compiler=<inplace-ghc>
        --with-package-db=<inplace-package-db>`
        <package>
      
      Reviewers: austin
      
      Reviewed By: austin
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D668
      30dc59e8
    • jbracker's avatar
      Fix for ticket #10078: ensure that tcPluginStop is called even in case of type errors · fd581a73
      jbracker authored
      Summary:
      Remove unused variable that appeared through the fix for ticket #10078
      
      Merge branch 'master' of git://git.haskell.org/ghc
      
      Added comment with bug ID.
      
      Reviewers: adamgundry, gridaphobe, austin
      
      Reviewed By: austin
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D667
      
      GHC Trac Issues: #10078
      fd581a73
    • PHO's avatar
      Make top-level "configure" accept and propagate --with-curses-{includes,libraries} to libraries · bbb57a6b
      PHO authored
      Summary:
      If curses is installed into some non-standard path, we currently have
      to say something like the following in mk/build.mk:
      
        libraries/terminfo_CONFIGURE_OPTS += \
            --configure-option=--with-curses-includes=/somewhere/include \
            --configure-option=--with-curses-libraries=/somewhere/lib
      
      This is because the top-level configure does not accept nor propagate
      --with-curses-{includes,libraries} to libraries while it does so for
      iconv, gmp and libffi. It would be nice if curses were handled in the
      same manner.
      
      Test Plan: Install curses into some non-standard path. Then run the top-level "configure" script with options "--with-curses-includes=/path/to/curses/include" and "--with-curses-libraries=/path/to/curses/lib".
      
      Reviewers: austin
      
      Reviewed By: austin
      
      Subscribers: thomie, PHO
      
      Differential Revision: https://phabricator.haskell.org/D665
      
      GHC Trac Issues: #10096
      bbb57a6b
    • thomie's avatar
      Error out on `Main` without `main` in GHCi (#7765) · 0fa20726
      thomie authored
      Summary:
      GHC does 2 validation checks for module `Main`:
      * does `main` exist
      * is `main` exported (#414)
      
      The second check is done in ghc as well as in ghci (and runghc and ghc -e).
      The first check however is currently not done in ghci, to prevent "'main' is
      not in scope" errors when loading simple scripts. See commit d28ba8c8 for
      more information.
      
      This commit tightens the special case for ghci. When the file does not contain
      a main function, but does contain an explicit module header (i.e. "module Main
      where"), then /do/ raise an error in ghci (and runghc and ghc -e) as well
      
      Test Plan:
      module/T7765: a module Main with an explicit module header but without a
      main function should be an error for all Ways.
      
      Additionaly: delete test module/mod174. It was added in commit 5a54c38e, but it
      is a duplicate of module/T414.
      
      Reviewers: austin
      
      Reviewed By: austin
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D649
      
      GHC Trac Issues: #7765
      0fa20726
    • kgardas's avatar
      fix bus errors on SPARC caused by unalignment access to alloc_limit (fixes #10043) · b2be772a
      kgardas authored
      Reviewers: austin, simonmar
      
      Subscribers: thomie
      
      Differential Revision: https://phabricator.haskell.org/D657
      b2be772a
  6. 22 Feb, 2015 1 commit
  7. 21 Feb, 2015 2 commits
  8. 20 Feb, 2015 2 commits