1. 03 Jun, 2019 3 commits
  2. 27 May, 2019 1 commit
  3. 03 May, 2019 1 commit
    • jberryman's avatar
      Rough LLVM/clang LTO WIP · 4facbfd8
      jberryman authored
      `StgReturn` and `StgRun` defined with inline ASM are not making it into archive
      built from `StgCRun.thr_o`, which is an LLVM bitcode LTO object.
      
      (see commented .ll file)
      
      After getting most of way through a build, did:
      
      - used `llc` to compile `rts/dist/build/StgCRun.thr_o` and inspected assembly file
      - copy-pasted code into textual IR (from `llvm-dis`) and removed wrapper function
         https://releases.llvm.org/6.0.0/docs/LangRef.html#moduleasm
      - convert back into bitcode IR using `llvm-as rts/dist/build/StgCRun.thr_o.ll`
      - re-run the `ar` command
      
      It took a lot of other tweaking and trial and error to complete a build
      though, so it's likely the state of repo here won't actually complete
      successfully.
      
      TODO for moar-LTO:
      - bypass mangler with -fast-llvm (which for some reason seems not to
      break things..?)
      - shim `llc` to be a simple `cp`
      - add flags to clang shim :  -O2 -mrelocation-model=static -msse -msse2
      
      This will hopefully allow cross-module optimization of fllvm haskell,
      e.g. more of our `libraries/*`
      4facbfd8
  4. 17 Apr, 2019 1 commit
  5. 21 Mar, 2019 1 commit
    • jberryman's avatar
      Rough working LTO · 6f369534
      jberryman authored
      Very rough and hacky, with some hacks unnecessary but which I haven't
      taken the time to sort out yet.
      
      you need to make sure you have the lto plugin set up correctly, e.g.:
      
        $ cd /usr/lib/bfd-plugins/
        $ sudo ln -s /usr/lib/gcc/x86_64-linux-gnu/6/liblto_plugin.so .
      
      then do:
      
         $ export PATH=SHIMS_PATH:$PATH
         $ LD=gold  CC_STAGE0=gcc CC=gcc ./configure
         $ make
      
      You should adjust your path in the same way when building with this GHC,
      and you can do e.g.
      
        $ cabal new-build --disable-profiling --disable-library-profiling --with-compiler=your-ghc-source-tree/inplace/bin/ghc-stage2 --package-db=your-ghc-source-tree/inplace/lib/package.conf.d all
      
      You can see `-time` log in gcc shim file, play with recompilation
      options there.
      6f369534
  6. 15 Dec, 2018 1 commit
  7. 06 Dec, 2018 6 commits
    • Ben Gamari's avatar
      Release 8.6.3 · 31cd867e
      Ben Gamari authored
      31cd867e
    • Ben Gamari's avatar
      users guide: Add release notes for 8.6.3 · d59812ce
      Ben Gamari authored
      d59812ce
    • Ben Gamari's avatar
      Windows: Use the "big" PE object format on amd64 · ed86e3b5
      Ben Gamari authored
      Test Plan: Do full build on Windows.
      
      Reviewers: AndreasK, Phyx
      
      Reviewed By: AndreasK
      
      Subscribers: rwbarton, erikd, carter
      
      GHC Trac Issues: #15934
      
      Differential Revision: https://phabricator.haskell.org/D5383
      
      (cherry picked from commit 1ef90f99)
      ed86e3b5
    • Tamar Christina's avatar
      linker: store entire link map and use it. · c64918c1
      Tamar Christina authored
      Summary:
      This fixes a corner case in which we have seen the symbol multiple times in
      different static libraries, but due to a depencency we end up loading the
      symbol from a library other than the first one.
      
      Previously the runtime linker would only track symbols from the first
      library and did not store the full link map.  In this case it was unable
      to find the address for the symbols in the second library during delay
      loading.
      
      This change stores the address of all symbols seen so a full link map
      is generated, such that when we make a different decision later than what
      was expected we're able to still correctly load the library.
      
      Test Plan: ./validate, new testcase T15894
      
      Reviewers: angerman, bgamari, erikd, simonmar
      
      Reviewed By: bgamari
      
      Subscribers: rwbarton, carter
      
      GHC Trac Issues: #15894
      
      Differential Revision: https://phabricator.haskell.org/D5353
      
      (cherry picked from commit a8b7cef4)
      c64918c1
    • Ben Gamari's avatar
      Bump iserv versions · bf074e3e
      Ben Gamari authored
      This fixes #15866, the original fix for which didn't merge cleanly to
      the stable branch.
      bf074e3e
    • Alexander Vershilov's avatar
      Remove explicit recursion in retainer profiling (fixes #14758) · 6db7d11e
      Alexander Vershilov authored
      Retainer profiling contained a recursion that under
      certain circumstances could lead to the stack overflow
      in C code.
      
      The idea of the improvement is to keep an explicit stack for the
      object, more precise to reuse existing stack, but allow new type of
      objects to be stored there.
      
      There is no reliable reproducer that is not a big program
      but in some cases foldr (+) 0 [1..10000000] can work.
      
      Reviewers: bgamari, simonmar, erikd, osa1
      
      Reviewed By: bgamari, osa1
      
      Subscribers: osa1, rwbarton, carter
      
      GHC Trac Issues: #14758
      
      Differential Revision: https://phabricator.haskell.org/D5351
      
      (cherry picked from commit 5f1d949a)
      6db7d11e
  8. 22 Nov, 2018 12 commits
    • Richard Eisenberg's avatar
      Fix #15859 by checking, not assuming, an ArgFlag · 2594ea25
      Richard Eisenberg authored
      We thought that visible dependent quantification was impossible
      in terms, but Iceland Jack discovered otherwise in #15859. This fixes an
      ASSERT failure that arose.
      
      test case: dependent/should_fail/T15859
      
      (cherry picked from commit 72b82343)
      
      (cherry picked from commit 5693ddd0)
      2594ea25
    • Ben Gamari's avatar
      base: Mention openFile throwing does-not-exist-errors on FIFOs · 64a50445
      Ben Gamari authored
      As discussed in #15715, the POSIX specification specifies that
      attempting to open a FIFO in write-only mode when the FIFO has no
      readers will fail with -ENOENT.
      
      [skip ci]
      
      Test Plan: Read it
      
      Reviewers: hvr
      
      Subscribers: rwbarton, carter
      
      GHC Trac Issues: #15715
      
      Differential Revision: https://phabricator.haskell.org/D5295
      
      (cherry picked from commit 4ba3fa31)
      64a50445
    • Ben Gamari's avatar
      Revert "libiserv: Generate cabal file with autoconf" · c2c6f498
      Ben Gamari authored
      This reverts commit cbde2726.
      c2c6f498
    • Dario Bertini's avatar
      rts/MachO: Iterate through N (all) symbols, not M external symbols · 11fd7df5
      Dario Bertini authored
      Fixes #15105
      
      (cherry picked from commit 25489085)
      11fd7df5
    • Dario Bertini's avatar
      rts/MachO: A bit of refactoring in ocGetNames · b44caa05
      Dario Bertini authored
      Eliminates a bit of repetition.
      
      (cherry picked from commit b2f6f896)
      b44caa05
    • Dario Bertini's avatar
      rts/MachO: Add a bit more debugging output to getNames · 65ced246
      Dario Bertini authored
      (cherry picked from commit 9e0a23b9)
      65ced246
    • Dario Bertini's avatar
      circleci: Actually build with in-tree GMP on Darwin · b6d2d837
      Dario Bertini authored
      Fixes #15404.
      
      (cherry picked from commit 3584bd42)
      b6d2d837
    • Simon Marlow's avatar
      Fix a bug in SRT generation (#15892) · 4519d98d
      Simon Marlow authored
      Summary:
      The logic in `Note [recursive SRTs]` was correct. However, my
      implementation of it wasn't: I got the associativity of
      `Set.difference` wrong, which led to an extremely subtle and difficult
      to find bug.
      
      Fortunately now we have a test case. I was able to cut down the code
      to something manageable, and I've added it to the test suite.
      
      Test Plan:
      Before (using my stage 1 compiler without the fix):
      
      ```
      ====> T15892(normal) 1 of 1 [0, 0, 0]
      cd "T15892.run" &&  "/home/smarlow/ghc/inplace/bin/ghc-stage1" -o T15892
      T15892.hs -dcore-lint -dcmm-lint -no-user-package-db -rtsopts
      -fno-warn-missed-specialisations -fshow-warning-groups
      -fdiagnostics-color=never -fno-diagnostics-show-caret -Werror=compat
      -dno-debug-output  -O
      cd "T15892.run" && ./T15892  +RTS -G1 -A32k -RTS
      Wrong exit code for T15892(normal)(expected 0 , actual 134 )
      Stderr ( T15892 ):
      T15892: internal error: evacuate: strange closure type 0
          (GHC version 8.7.20181113 for x86_64_unknown_linux)
          Please report this as a GHC bug:  http://www.haskell.org/ghc/reportabug
      Aborted (core dumped)
      *** unexpected failure for T15892(normal)
      =====> T15892(g1) 1 of 1 [0, 1, 0]
      cd "T15892.run" &&  "/home/smarlow/ghc/inplace/bin/ghc-stage1" -o T15892
      T15892.hs -dcore-lint -dcmm-lint -no-user-package-db -rtsopts
      -fno-warn-missed-specialisations -fshow-warning-groups
      -fdiagnostics-color=never -fno-diagnostics-show-caret -Werror=compat
      -dno-debug-output  -O
      cd "T15892.run" && ./T15892 +RTS -G1 -RTS +RTS -G1 -A32k -RTS
      Wrong exit code for T15892(g1)(expected 0 , actual 134 )
      Stderr ( T15892 ):
      T15892: internal error: evacuate: strange closure type 0
          (GHC version 8.7.20181113 for x86_64_unknown_linux)
          Please report this as a GHC bug:  http://www.haskell.org/ghc/reportabug
      Aborted (core dumped)
      ```
      
      After (using my stage 2 compiler with the fix):
      
      ```
      =====> T15892(normal) 1 of 1 [0, 0, 0]
      cd "T15892.run" &&  "/home/smarlow/ghc/inplace/test   spaces/ghc-stage2"
      -o T15892 T15892.hs -dcore-lint -dcmm-lint -no-user-package-db -rtsopts
      -fno-warn-missed-specialisations -fshow-warning-groups
      -fdiagnostics-color=never -fno-diagnostics-show-caret -Werror=compat
      -dno-debug-output
      cd "T15892.run" && ./T15892  +RTS -G1 -A32k -RTS
      =====> T15892(g1) 1 of 1 [0, 0, 0]
      cd "T15892.run" &&  "/home/smarlow/ghc/inplace/test   spaces/ghc-stage2"
      -o T15892 T15892.hs -dcore-lint -dcmm-lint -no-user-package-db -rtsopts
      -fno-warn-missed-specialisations -fshow-warning-groups
      -fdiagnostics-color=never -fno-diagnostics-show-caret -Werror=compat
      -dno-debug-output
      cd "T15892.run" && ./T15892 +RTS -G1 -RTS +RTS -G1 -A32k -RTS
      ```
      
      Reviewers: bgamari, osa1, erikd
      
      Reviewed By: osa1
      
      Subscribers: rwbarton, carter
      
      GHC Trac Issues: #15892
      
      Differential Revision: https://phabricator.haskell.org/D5334
      4519d98d
    • Christiaan Baaij's avatar
      Load plugins in interactive session · e67bebbf
      Christiaan Baaij authored
      Reviewers: bgamari, tdammers
      
      Reviewed By: tdammers
      
      Subscribers: monoidal, rwbarton, carter
      
      GHC Trac Issues: #15633
      
      Differential Revision: https://phabricator.haskell.org/D5348
      
      (cherry picked from commit 599eaada)
      e67bebbf
    • Ben Gamari's avatar
      rts/M32Alloc: Abort if m32 linker mmap fails · c8b24dce
      Ben Gamari authored
      Previously we should just blinding dereference a NULL pointer.
      
      (cherry picked from commit 86f6890e)
      c8b24dce
    • Ben Gamari's avatar
      users guide: We no longer build libraries with -split-objs · 14ae4ab6
      Ben Gamari authored
      We now generally use split-sections instead.
      
      (cherry picked from commit f5fbecc8)
      14ae4ab6
    • Ömer Sinan Ağacan's avatar
      Fix heap corruption during stable name allocation · 22cd729a
      Ömer Sinan Ağacan authored
      See #15906 for the problem. To fix we simply call `allocate()` instead of
      `ALLOC_PRIM()`. `allocate()` does not trigger GC when the nursery is full,
      instead it extends it.
      
      Test Plan:
      This validates. memo001 now passes with `-debug` compile parameter. I'll add
      another test that runs memo001 with `-debug` once I figure out how to use
      stdout files for multiple tests.
      
      Reviewers: simonmar, bgamari, erikd
      
      Reviewed By: simonmar
      
      Subscribers: rwbarton, carter
      
      GHC Trac Issues: #15906
      
      Differential Revision: https://phabricator.haskell.org/D5342
      
      (cherry picked from commit 691aa715)
      22cd729a
  9. 08 Nov, 2018 1 commit
  10. 06 Nov, 2018 1 commit
  11. 05 Nov, 2018 1 commit
  12. 02 Nov, 2018 3 commits
    • Ben Gamari's avatar
      integer-gmp: Fix TBA in changelog · 9448fdce
      Ben Gamari authored
      9448fdce
    • Richard Eisenberg's avatar
      Don't lint erroneous programs. · 41f0f6c2
      Richard Eisenberg authored
      newFamInst lints its types. This is good. But it's not so good
      when there have been errors and thus recovery tycons are about.
      So we now don't.
      
      Fixes #15796.
      
      Test case: typecheck/should_fail/T15796
      
      (cherry picked from commit 1f72a1c8)
      41f0f6c2
    • Richard Eisenberg's avatar
      Fix #15787 by squashing a coercion hole. · 7a439e7b
      Richard Eisenberg authored
      In type-incorrect code, we can sometimes let a coercion
      hole make it through the zonker. If this coercion hole then
      ends up in the environment (e.g., in the type of a data
      constructor), then it causes trouble later.
      
      This patch avoids trouble by substituting the coercion hole
      for its representative CoVar. Really, any coercion would do,
      but the CoVar was very handy.
      
      test case: polykinds/T15787
      
      (cherry picked from commit 4427315a)
      7a439e7b
  13. 31 Oct, 2018 1 commit
  14. 30 Oct, 2018 6 commits
    • Ben Gamari's avatar
      users-guide: Note existence of #14251 · a876edcb
      Ben Gamari authored
      a876edcb
    • Ryan Scott's avatar
      Fix #15815 by parenthesizing the arguments to infix ~ · 2567e8f3
      Ryan Scott authored
      An unfortunate consequence of commit
      b9483981 (`Remove HsEqTy and XEqTy`)
      is infix uses of `~` in TH quotes now desugar differently than
      before. In particular, we have that:
      
      ```haskell
      a ~ (Int -> Int)
      ```
      
      Now desugars to:
      
      ```haskell
      HsOpTy a (~) (HsOpTy Int (->) Int)
      ```
      
      Which GHC interprets as being:
      
      ```haskell
      a ~ Int -> Int
      ```
      
      Or, equivalently:
      
      ```haskell
      (a ~ Int) -> Int
      ```
      
      Which is different than what was intended! This is the cause
      of #15815.
      
      All of this has revealed that we likely need to renovate the way we
      desugar infix type operators to be more consistent with the treatment
      for infix expressions (see
      https://ghc.haskell.org/trac/ghc/ticket/15815#comment:5 for more on
      this.) Doing so would constitute a breaking change, however, so we
      will likely want to wait until another major GHC release to do this.
      
      In the meantime, this patch offers a non-invasive change to the way
      that infix uses of `~` are desugared. This makes the program
      in #15815 compile again by inserting extra `HsParTy`s around the
      arguments to `~` if they are lacking them.
      
      Test Plan: make test TEST=T15815
      
      Reviewers: int-index, goldfire, bgamari
      
      Reviewed By: int-index
      
      Subscribers: int-e, rwbarton, carter
      
      GHC Trac Issues: #15815
      
      Differential Revision: https://phabricator.haskell.org/D5274
      
      (cherry picked from commit b8a797ec)
      2567e8f3
    • Ben Gamari's avatar
      Revert "Multiple fixes / improvements for LLVM backend" · 377fe398
      Ben Gamari authored
      This reverts commit 73273be4.
      
      Unfortunately we were unable to come to a fix that didn't sacrifice the
      ability to bootstrap GHC using the LLVM backend. Reverting for 8.6.2.
      377fe398
    • Ben Gamari's avatar
      Revert "Fix for T14251 on ARM" · 9c4314ec
      Ben Gamari authored
      This reverts commit 2e23e1c7.
      9c4314ec
    • Ben Gamari's avatar
      users-guide: Fix typo · d67cbced
      Ben Gamari authored
      d67cbced
    • Simon Peyton Jones's avatar
      Report a Wanted error even if there are Given ones · a49f95c2
      Simon Peyton Jones authored
      We suppress some Given errors; see Note [Given errors]
      in TcErrors.  But we must be careful not to suppress
      Wanted errors because of the presence of these Given
      errors -- else we might allow compilation to bogusly
      proceed
      
      The rubber hits the road in TcRnTypes.insolubleCt,
      where we don't want to treat Givens as insoluble,
      nor (and this is the new bit) Deriveds that arise
      from Givens.  See Note [Given insolubles] in TcRnTypes.
      
      This fixes #15767.
      
      (cherry picked from commit 6b1102e2)
      
      Ben notes:
      
        I have folded some test output changes in `TEST="T12529 T12921 mc13
        mc14"` into this patch that were not in the original.
      a49f95c2
  15. 28 Oct, 2018 1 commit
    • Ningning Xie's avatar
      Fix TcType.anyRewritableTyVar · b391cae1
      Ningning Xie authored
      Summary:
      This patch fixes #15805, where we found that
      `TcType.anyRewritableTyVar` has one wrong case.
      
      Besides the fix, it also:
      - removed some unnecessary `ASSERT2(tcIsTcTyVar...)` in `TcType`, as now we have
           `tcIsTcTyVar = isTyVar`.
      - fixed some comments
      
      Test Plan: ./validate
      
      Reviewers: goldfire, simonpj, bgamari
      
      Reviewed By: simonpj
      
      Subscribers: rwbarton, carter
      
      GHC Trac Issues: #15805
      
      Differential Revision: https://phabricator.haskell.org/D5263
      
      (cherry picked from commit a7f64c6c)
      b391cae1