From 72c7380cb780933825bc84924908e01ce0495dc4 Mon Sep 17 00:00:00 2001 From: Sylvain Henry <sylvain@haskus.fr> Date: Fri, 6 Oct 2023 14:03:45 +0200 Subject: [PATCH] Hadrian: enable `-fcheck-prim-bounds` in validate flavour This allows T24066 to fail when the bug is present. Otherwise the out-of-bound access isn't detected as it happens in ghc-bignum which wasn't compiled with the bounds check. --- hadrian/doc/flavours.md | 2 +- hadrian/src/Settings/Flavours/Validate.hs | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hadrian/doc/flavours.md b/hadrian/doc/flavours.md index 50bce94a8772..24c2945995d0 100644 --- a/hadrian/doc/flavours.md +++ b/hadrian/doc/flavours.md @@ -157,7 +157,7 @@ when compiling the `compiler` library, and `hsGhc` when compiling/linking the GH <th>validate</td> <td></td> <td>-O0<br>-H64m</td> - <td>-fllvm-fill-undef-with-garbage</td> + <td>-fllvm-fill-undef-with-garbage<br>-fcheck-prim-bounds</td> <td></td> <td>-O<br>-dcore-lint<br>-dno-debug-output</td> <td>-O2<br>-DDEBUG</td> diff --git a/hadrian/src/Settings/Flavours/Validate.hs b/hadrian/src/Settings/Flavours/Validate.hs index b7c3d08d5f8f..b322e7663608 100644 --- a/hadrian/src/Settings/Flavours/Validate.hs +++ b/hadrian/src/Settings/Flavours/Validate.hs @@ -35,6 +35,7 @@ validateArgs = sourceArgs SourceArgs -- See #11487 , notStage0 ? arg "-fllvm-fill-undef-with-garbage" , notStage0 ? arg "-dno-debug-output" + , notStage0 ? arg "-fcheck-prim-bounds" ] , hsLibrary = pure ["-O"] , hsCompiler = mconcat [ stage0 ? pure ["-O2"] -- GitLab