From ed5fd5378dafb65bd12a16a4e02b6dae0639b83d Mon Sep 17 00:00:00 2001
From: Ben Gamari <ben@smart-cactus.org>
Date: Fri, 21 Apr 2017 12:27:51 -0400
Subject: [PATCH] linters/check-cpp: Demote #if lints to warnings

Errors trigger even for lines which the author didn't touch, which is undesired.
---
 .arc-linters/check-cpp.py | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/.arc-linters/check-cpp.py b/.arc-linters/check-cpp.py
index 1bbcbbdfb6b9..a442e261db79 100755
--- a/.arc-linters/check-cpp.py
+++ b/.arc-linters/check-cpp.py
@@ -69,11 +69,14 @@ linters = [
     RegexpLinter(br'ASSERT\s+\(',
                  message='CPP macros should not have a space between the macro name and their argument list'),
     RegexpLinter(br'#ifdef\s+',
-                 message='`#if defined(x)` is preferred to `#ifdef x`'),
+                 message='`#if defined(x)` is preferred to `#ifdef x`',
+                 severity='warning'),
     RegexpLinter(br'#if\s+defined\s+',
-                 message='`#if defined(x)` is preferred to `#if defined x`'),
+                 message='`#if defined(x)` is preferred to `#if defined x`',
+                 severity='warning'),
     RegexpLinter(br'#ifndef\s+',
-                 message='`#if !defined(x)` is preferred to `#ifndef x`'),
+                 message='`#if !defined(x)` is preferred to `#ifndef x`',
+                 severity='warning'),
 ]
 
 if __name__ == '__main__':
-- 
GitLab