Rufflewind authored 8 years ago and Ben Gamari committed 8 years ago

Summary:
Keep track of column numbers and inform GHC whenever the column number
could be potentially desynchronized from the original source code.  This
should fix GHC #13388 on Trac.

Test Plan: validate

Reviewers: O25 HSC2HS, hvr, bgamari

Reviewed By: bgamari

Differential Revision: https://phabricator.haskell.org/D3314

During C compiler feature testing, the `main` function was defined
with a parameter list of `(int argc, char *argv [])` but these
parameters were not used. This results in compiler warnings when
the generated file is compiled with the `-Wextra` warning flag
added to the `cc-options` of the cabal file.

Reviewers: hvr, RyanGlScott, bgamari, rwbarton

Reviewed By: rwbarton

Differential Revision: https://phabricator.haskell.org/D2677

Ryan Scott authored 9 years ago and Thomas Miedema committed 9 years ago

Previously, calculating alignment values was commonly done by defining a
custom macro via `#let`:

```
(y__); }, y__)
```

Not only is this tedious, but it also doesn't work in cross-compilation
mode (see #10272). It makes sense to define this in `hsc2hs` for symmetry
with `#size`, `#poke`, `#peek`, etc., as well as to make it easier to
cross-compile `.hsc` files.

Fixes #4340.

Reviewed By: thomie, erikd

Differential Revision: https://phabricator.haskell.org/D1436

GHC Trac Issues: #4340, #10272

* Fix GHC trac #2897: Generate a separate "utils" C file containing
  wrappers for functions like printf. This means template-hsc.h
  doesn't need to includes any headers, so we don't pollute the C
  environment.
  (actually, we still need to include stddef.h).

* Use runProcess rather than system. It used to try to conditionally
  use runProcess if it was available, but never actually did. Now it
  uses it unconditionally.

* Some tidying up

The conditional code was all for versions < 6.10, so old enough that
they can't be used to compile the HEAD.

Additionally, it didn't work properly. It relied on __GLASGOW_HASKELL__
being defined when compiling the C, rather than having the C print the
conditionals as part of the Haskell.

No code changes.

Should fix ticket #4115
Do the same for the compiler flags, mainly for consistency.

Should help slightly when tracking down problems, e.g. ticket 4110

Maybe strictly speaking it would be better to encode/decode UTF-8, but
it would be a fiddle and I don't think it really matters for hsc2hs.

This can still be overridden by adding a -I flag to the commandline,
but it means that hsc2hs will work if no flags are given.

The difference between #if !BUILD_NHC and #ifndef BUILD_NHC is subtle but real.

We now use Data.Version.showVersion rather than display