Document some benign nondeterminism
I've changed the functions to their nonDet equivalents and explained why they're OK there. This allowed me to remove foldNameSet, foldVarEnv, foldVarEnv_Directly, foldVarSet and foldUFM_Directly. Test Plan: ./validate, there should be no change in behavior Reviewers: simonpj, simonmar, austin, goldfire, bgamari Reviewed By: bgamari Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D2244 GHC Trac Issues: #4012
Showing
- compiler/basicTypes/DataCon.hs 2 additions, 3 deletionscompiler/basicTypes/DataCon.hs
- compiler/basicTypes/Demand.hs 11 additions, 3 deletionscompiler/basicTypes/Demand.hs
- compiler/basicTypes/NameEnv.hs 1 addition, 4 deletionscompiler/basicTypes/NameEnv.hs
- compiler/basicTypes/NameSet.hs 1 addition, 3 deletionscompiler/basicTypes/NameSet.hs
- compiler/basicTypes/VarEnv.hs 2 additions, 10 deletionscompiler/basicTypes/VarEnv.hs
- compiler/basicTypes/VarSet.hs 1 addition, 3 deletionscompiler/basicTypes/VarSet.hs
- compiler/codeGen/StgCmmEnv.hs 3 additions, 1 deletioncompiler/codeGen/StgCmmEnv.hs
- compiler/deSugar/Desugar.hs 3 additions, 1 deletioncompiler/deSugar/Desugar.hs
- compiler/main/HscMain.hs 3 additions, 1 deletioncompiler/main/HscMain.hs
- compiler/rename/RnSource.hs 3 additions, 1 deletioncompiler/rename/RnSource.hs
- compiler/simplCore/OccurAnal.hs 7 additions, 3 deletionscompiler/simplCore/OccurAnal.hs
- compiler/simplCore/SetLevels.hs 3 additions, 2 deletionscompiler/simplCore/SetLevels.hs
- compiler/specialise/Rules.hs 3 additions, 1 deletioncompiler/specialise/Rules.hs
- compiler/typecheck/TcSimplify.hs 4 additions, 1 deletioncompiler/typecheck/TcSimplify.hs
- compiler/types/Coercion.hs 5 additions, 1 deletioncompiler/types/Coercion.hs
- compiler/types/TyCoRep.hs 3 additions, 1 deletioncompiler/types/TyCoRep.hs
- compiler/types/Unify.hs 11 additions, 3 deletionscompiler/types/Unify.hs
- compiler/utils/FastStringEnv.hs 1 addition, 4 deletionscompiler/utils/FastStringEnv.hs
- compiler/utils/UniqFM.hs 26 additions, 25 deletionscompiler/utils/UniqFM.hs
Loading
Please register or sign in to comment