• Douglas Wilson's avatar
    Refactor temp files cleanup · 3ee3822c
    Douglas Wilson authored
    Remove filesToNotIntermediateClean from DynFlags, create a data type
    FilesToClean, and change filesToClean in DynFlags to be a FilesToClean.
    Modify SysTools.newTempName and the Temporary constructor of
    PipelineMonad.PipelineOutput to take a TempFileLifetime, which specifies
    whether a temp file should live until the end of GhcMonad.withSession,
    or until the next time cleanIntermediateTempFiles is called.
    These changes allow the cleaning of intermediate files in GhcMake to be
    much more efficient.
    HscTypes.hptObjs is removed as it is no longer used.
    A new performance test T13701 is added, which passes both with and
    without -keep-tmp-files.  The test fails by 25% without the patch, and
    passes when -keep-tmp-files is added.
    Note that there are still at two hotspots caused by
    algorithms quadratic in the number of modules, however neither of them
    allocate. They are:
    * DriverPipeline.compileOne'.needsLinker
    * GhcMake.getModLoop
    DriverPipeline.compileOne'.needsLinker is changed slightly to improve
    the situation.
    I don't like adding these Types to DynFlags, but they need to be seen by
    Dynflags, SysTools and PipelineMonad. The alternative seems to be to
    create a new module.
    Reviewers: austin, hvr, bgamari, dfeuer, niteria, simonmar, erikd
    Reviewed By: simonmar
    Subscribers: rwbarton, thomie
    GHC Trac Issues: #13701
    Differential Revision: https://phabricator.haskell.org/D3620
DynFlags.hs 220 KB