Fix wrong-kind-of-family error message (Trac #9896)

compiler/typecheck/TcTyClsDecls.hs

@@ -2223,8 +2223,8 @@ wrongKindOfFamily family
   = ptext (sLit "Wrong category of family instance; declaration was for a")
     <+> kindOfFamily
   where
-    kindOfFamily | isTypeSynonymTyCon family = text "type synonym"
-                 | isAlgTyCon         family = text "data type"
+    kindOfFamily | isTypeFamilyTyCon family = text "type family"
+                 | isDataFamilyTyCon family = text "data family"
                  | otherwise = pprPanic "wrongKindOfFamily" (ppr family)
 
 wrongNumberOfParmsErr :: Arity -> SDoc

testsuite/tests/indexed-types/should_fail/SimpleFail3a.stderr

 
 SimpleFail3a.hs:10:3:
-    Wrong category of family instance; declaration was for a data type
+    Wrong category of family instance; declaration was for a data family
     In the type instance declaration for ‘S1’
     In the instance declaration for ‘C1 Int’

testsuite/tests/indexed-types/should_fail/T9896.hs

+{-# LANGUAGE TypeFamilies #-}
+module T9896 where
+
+class Test a where
+  type TestT a :: *
+
+instance Test Bool where
+  newtype TestT Bool = Int

testsuite/tests/indexed-types/should_fail/T9896.stderr

+
+T9896.hs:8:3:
+    Wrong category of family instance; declaration was for a type family
+    In the newtype instance declaration for ‘TestT’
+    In the instance declaration for ‘Test Bool’

testsuite/tests/indexed-types/should_fail/all.T

@@ -131,3 +131,4 @@ test('BadSock', normal, compile_fail, [''])
 test('T9580', normal, multimod_compile_fail, ['T9580', ''])
 test('T9662', normal, compile_fail, [''])
 test('T7862', normal, compile_fail, [''])
+test('T9896', normal, compile_fail, [''])

testsuite/tests/typecheck/should_fail/AssocTyDef03.stderr

-
-AssocTyDef03.hs:6:5:
-    Wrong category of family instance; declaration was for a data type
-    In the default type instance declaration for ‘Typ’
-    In the class declaration for ‘Cls’
+
+AssocTyDef03.hs:6:5:
+    Wrong category of family instance; declaration was for a data family
+    In the default type instance declaration for ‘Typ’
+    In the class declaration for ‘Cls’