- Dec 30, 2020
-
-
Pepe Iborra authored
* Invert the dependency between ghcide and hls-plugin-api This PR includes changes both to ghcide and HLS to implement the reorg described in https://github.com/haskell/ghcide/issues/936#issuecomment-751437853 To summarise: - `hls-plugin-api` no longer depends on ghcide. - `ghcide` now depends on `hls-plugin-api` and exposes: - The ghcide HLS plugin - The `asGhcIdePlugin` adaptor The goals are: - to be able to break the `ghcide` HLS plugin down - to rewrite exe:ghcide on top of the HLS plugin model. The ghcide side is reviewed in https://github.com/haskell/ghcide/pull/963 If this change is accepted there are two further considerations: - This would be a good moment to merge the 2 repos, so that there is no history loss. - `hls-plugin-api` will need to be released to Hackage prior to merging https://github.com/haskell/ghcide/pull/963 * clean up * Fix the ghcide plugin to include the rules * clean up PartialHandlers definition The ghcide partial handlers for completions, code actions and hover are not really being used, since they get overriden by the `<> ps` append. This is due to the right-biased semantics of `PartialHandlers` * Move ghcide LspConfig into Ide.Plugin.Config * Use HLS plugins in ghcide For now there is only one, the main ghcide plugin. But this will allow us to break it down in more fine grained plugins with parallel semantics, both for execution and error handling * Fix hlints * Revert "Temporarily disable the upstream branch for benchmarks" This reverts commit 7bb3c6ef. * Disable the Windows 8.6.4 test * Fix unrelated hlints Not sure why these are triggering now. Linting should be restricted to the Diff ...
-
Pepe Iborra authored
Usage of these tools is described in https://github.com/haskell/haskell-language-server/blob/master/ghcide/docs/opentelemetry.md
-
Junyoung/Clare Jang authored
Move eval plugin to hls-eval-plugin
-
- Dec 29, 2020
-
-
Pasqualino Titto Assini authored
-
Pepe Iborra authored
-
Pepe Iborra authored
Error: Error: While constructing the build plan, the following exceptions were encountered: In the dependencies for diagrams-postscript-1.4.1: hashable-1.3.0.0 from stack configuration does not match >=1.1 && <1.3 (latest matching version is 1.2.7.0) lens-4.18 from stack configuration does not match >=4.0 && <4.18 (latest matching version is 4.17.1) needed due to shake-bench-0.1.0.0 -> diagrams-postscript-1.4.1
-
Pepe Iborra authored
``` Error: While constructing the build plan, the following exceptions were encountered: In the dependencies for shake-bench-0.1.0.0: Chart-diagrams needed, but the stack configuration has no specified version (latest matching version is 1.9.3) diagrams needed, but the stack configuration has no specified version (latest matching version is 1.4) diagrams-svg needed, but the stack configuration has no specified version (latest matching version is 1.4.3) needed since shake-bench is a build target. ```
-
Pepe Iborra authored
This is needed to build with Cabal v1 if ghc is built with DYNAMIC_GHC_PROGRAMS=NO which is the case e.g. in Windows
-
Pepe Iborra authored
-
Pepe Iborra authored
Reminder that ghcide requires at least 2 capabilities
-
Pepe Iborra authored
With so many github actions (>60) we cannot afford to run on every push
-
Pepe Iborra authored
The ghcide merge includes https://github.com/haskell/ghcide/pull/948 which removes the language extension code actions This makes the associated func-test fail, because the HLS plugin does not pass the test (only the ghcide code action did). This is because the HLS plugin uses commands, and the tests do not wait for the command edit to be applied. The fix is to change the HLS plugin to return a code action with edits and no commands
-
Pepe Iborra authored
These tests were underspecified and broke with the recent improvements to ghcide diagnostics in https://github.com/haskell/ghcide/pull/959 and included in this merge. Fixed by waiting specifically for the typecheck diagnostics and by being less prescriptive in the number and order of code actions
-
Pepe Iborra authored
-
Pepe Iborra authored
-
Pepe Iborra authored
-
Pepe Iborra authored
I missed these previously
-
Pepe Iborra authored
The benchmark script uses git worktree. The upstream branch contains a ghcide submodule, which is not well supported by worktree. Once this PR has been merged and the upstream branch no longer contains a git submodule, we can reenable it in the bench config
-
Pepe Iborra authored
-
Pepe Iborra authored
-
Pepe Iborra authored
-
Pepe Iborra authored
-
Pepe Iborra authored
-
Pepe Iborra authored
-
- Dec 27, 2020
-
-
Javier Neira authored
Fix and enable progress message tests.
-
Pepe Iborra authored
-
Junyoung/Clare Jang authored
Implement basic Class plugin
-
- Dec 26, 2020
-
-
Pepe Iborra authored
* Disable auto-extend of module imports * Prepare for v0.6.0.2 release
-
Junyoung/Clare Jang authored
-
Junyoung/Clare Jang authored
-
Junyoung/Clare Jang authored
-
Junyoung/Clare Jang authored
-
Junyoung/Clare Jang authored
-
Junyoung/Clare Jang authored
-
Junyoung/Clare Jang authored
-
Junyoung/Clare Jang authored
-
Junyoung/Clare Jang authored
-
Junyoung/Clare Jang authored
-
- Dec 25, 2020
-
-
Peter Wicks Stringfield authored
-
Peter Wicks Stringfield authored
-