This commit adapts to the changes in GHC MR !8686, which overhauls
the treatment of record fields in the renamer, adding separate record
field namespaces and entirely removing the GreName datatype.

The footnote is invalid with GHC 9.2.4 (and possibly earlier): the described behaviour in the main text works fine.

Simon Peyton Jones authored 2 years ago and Simon Peyton Jones committed 2 years ago

See #21623 and !8750

John Ericson authored 3 years ago and sheaf committed 2 years ago

Spooky, but I guess that is intended?

Sphinx was complaining about too-short title underlines.

Merge GHC 9.4 into `main`

Backport 9-4: Fix hyperlinks to external items and modules (#1482)

Jade Lovelace authored 3 years ago and Douglas Wilson committed 2 years ago

Fixes #1481.

There were two bugs in this:
* We were assuming that we were always getting a relative path to the
  module in question, while Nix gives us file:// URLs sometimes. This
  change checks for those and stops prepending `..` to them.
* We were not linking to the file under the module. This seems
  to have been a regression introduced by #977. That is, the URLs were
  going to something like
  file:///nix/store/3bwbsy0llxxn1pixx3ll02alln56ivxy-ghc-9.0.2-doc/share/doc/ghc/html/libraries/base-4.15.1.0/src
  which does not have the appropriate HTML file or fragment for the item
  in question at the end.

There is a remaining instance of the latter bug, but not in the
hyperlinker: the source links to items reexported from other modules are
also not including the correct file name. e.g. the reexport of Entity in
esqueleto, from persistent.

NOTE: This needs to get tested with relative-path located modules. It seems
correct for Nix based on my testing.

Testing strategy:

```
nix-shell '<nixpkgs>' --pure -A haskell.packages.ghc922.aeson
mkdir /tmp/aesonbuild && cd /tmp/aesonbuild
export out=/tmp/aesonbuild/out
genericBuild

ln -sf $HOME/co/haddock/haddock-api/resources .
./Setup haddock --with-haddock=$HOME/path/to/haddock/exec --hyperlink-source
```

(cherry picked from commit ab53ccf0)

* Follow hlint suggestion: redundant $.

* Remove $ and surplus blank lines in Operators.

* Follow hlint suggestion: unused LANGUAGE pragma.

* Ignore within modules to pass linting and pass tests.

Redo the counts available with the --default option.