Artem Pyanykh authored 6 years ago and Marge Bot committed 5 years ago

1. Place each section on a separate page to ensure required
alignment (wastes lots ot space, needs to be improved).
2. Unwire relocation logic from macho sections (the most fiddly part
is adjusting internal relocations).

Other todos:
0. Add a test for section alignment.
1. Investigate 32bit relocations!
2. Fix memory leak in ZEROPAGE section allocation.
3. Fix creating redundant jump islands for GOT.
4. Investigate more compact section placement.

Ben Gamari authored 6 years ago and Marge Bot committed 5 years ago

I believe removing __mingw_vsnwprintf from RtsSymbols fixed #16387.

Ben Gamari authored 6 years ago and Marge Bot committed 5 years ago

It doesn't fail reliably.

Ben Gamari authored 6 years ago and Marge Bot committed 5 years ago

As described in #16387, this is already defined by mingw and
consequently defining it in the RTS as well leads to multiple definition
errors from the RTS linker at runtime.

Ben Gamari authored 6 years ago and Marge Bot committed 5 years ago

I think the linker is routinely eating through the timeout,
leading to many spurious failures.

Ben Gamari authored 6 years ago and Marge Bot committed 5 years ago

This test, which is only run on Windows, seems to be reliably timing
out.

See #16390.

Ben Gamari authored 6 years ago and Marge Bot committed 5 years ago

A few tests previously failed with various failure modes. For instance,
  `plugin-recomp-change` fails with:

```
Wrong exit code for plugin-recomp-change()(expected 0 , actual 2 )
Stderr ( plugin-recomp-change ):
Simple Plugin Passes Queried
Got options:
Simple Plugin Pass Run
C://GitLabRunner//builds//8fc0e283//0//ghc//ghc//inplace//mingw//bin/ld.exe: cannot find -lHSplugin-recompilation-0.1-CPeObcGoBuvHdwBnpK9jQq
collect2.exe: error: ld returned 1 exit status
`gcc.exe' failed in phase `Linker'. (Exit code: 1)
make[2]: *** [Makefile:112: plugin-recomp-change] Error 1
*** unexpected failure for plugin-recomp-change(normal)
```

It's unclear whether the ghc-pkg concurrency issue mentioned in all.T is
the culprit but the set of tests that fail overlaps strongly with the
set of tests that lack the `multi_cpu_race` modifier. Let's see if
adding it fixes them.

Ben Gamari authored 6 years ago and Marge Bot committed 5 years ago

There seems to be some filepath funniness due to TH embedding going on
here. See #16389.

Ben Gamari authored 6 years ago and Marge Bot committed 5 years ago

It seems to look for some sort of manifest file. See #16388.

Ben Gamari authored 6 years ago and Marge Bot committed 5 years ago

See #16387.

Ben Gamari authored 6 years ago and Marge Bot committed 5 years ago

Broke as -Wimplicit-kind-vars no longer exists. Specifically ghci024,
ghci057 and T9293.

Ben Gamari authored 6 years ago and Marge Bot committed 5 years ago

See #16386.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

To install lndir and un-break the source distribution job.

Takenobu Tani authored 5 years ago and Marge Bot committed 5 years ago

The user's guide uses the `ghc-wiki` macro, and substitution rules
are complicated. So I manually edited `.rst` files without sed.

I changed `Commentary/Latedmd` only to a different page.
It is more appropriate as an example.

[ci skip]

Ben Gamari authored 6 years ago and Marge Bot committed 5 years ago

Metric Increase:
    haddock.Cabal

This ends up being much easier to use than Debian 9 under NixOS.

Michael Sloan authored 6 years ago and Marge Bot committed 6 years ago

See #13101 + #15454 for motivation.  This change reduces the number of
modules that need to be compiled to object code when loading GHC into
GHCi.

Ben Gamari authored 6 years ago and Marge Bot committed 6 years ago

This function allows the user to compute the (non-transitive) size of a
heap object in words. The "closure" in the name is admittedly confusing
but we are stuck with this nomenclature at this point.

As discussed in #16450, this feature regresses CI on Windows, causing
non-deterministic failures due to missing files.

Simon Peyton Jones authored 6 years ago and Marge Bot committed 6 years ago

The extra-constraints wildcard had lost its location
(issue #16431).

Happily this is easy to fix.  Lots of error improvements.