Ryan Scott authored 5 years ago and Marge Bot committed 5 years ago

See #16490.

[ci skip]

Takenobu Tani authored 5 years ago and Marge Bot committed 5 years ago

This moves all URL references to Trac Wiki to their corresponding
GitLab counterparts.

This substitution is classified as follows:

1. Automated substitution using sed with Ben's mapping rule [1]
    Old: ghc.haskell.org/trac/ghc/wiki/XxxYyy...
    New: gitlab.haskell.org/ghc/ghc/wikis/xxx-yyy...

2. Manual substitution for URLs containing `#` index
    Old: ghc.haskell.org/trac/ghc/wiki/XxxYyy...#Zzz
    New: gitlab.haskell.org/ghc/ghc/wikis/xxx-yyy...#zzz

3. Manual substitution for strings starting with `Commentary`
    Old: Commentary/XxxYyy...
    New: commentary/xxx-yyy...

See also !539

[1]: https://gitlab.haskell.org/bgamari/gitlab-migration/blob/master/wiki-mapping.json

Matthew Pickering authored 5 years ago and Marge Bot committed 5 years ago

By separating these two lines, if the first command fails then `ghci` is
not loaded. Before it would still load ghci but display lots of errors
about not being able to find modules.

Matthew Pickering authored 5 years ago and Marge Bot committed 5 years ago

ghci always exits with exit code 0 so you have to check the output
to see if the modules loaded succesfully.

Haskell-mouse authored 6 years ago and Marge Bot committed 5 years ago

Adds the mention that extensions "AllowAmbiguousTypes" and "RankNTypes"
are not always compatible with each other.
Specifies the conditions and causes of failing in resolving
of ambiguity.

They are broken and I don't have time to fix them at the moment.

`git fetch`, which we used previously, doesn't update the remote
tracking branches.

Previously we would use the local branch with the name
`$CI_MERGE_REQUEST_TARGET_BRANCH_NAME` to compute the merge base when
linting. However, this branch isn't necessarily up-to-date. We should
rather use `origin/$CI_MERGE_REQUEST_TARGET_BRANCH_NAME`.

I'm not sure why these steps were done but they seem counterproductive
and unnecessary.

Herbert Valerio Riedel authored 6 years ago and Ben Gamari committed 5 years ago

As per https://prime.haskell.org/wiki/Libraries/Proposals/MonadFail



Coauthored-by: Ben Gamari <ben@well-typed.com>

Matthew Pickering authored 5 years ago and Marge Bot committed 5 years ago

This depends on the windows build which is still allowed to fail. If
that job fails then the packaging job will also fail.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Due to https://github.com/haskell/cabal/issues/5953.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

Otherwise configure fails in the 32-bit case with
```
This GHC (c:/GitLabRunner/builds/8fc0e283/0/ghc/ghc/toolchain/bin/ghc) does not generate code for the build platform
   GHC target platform    : x86_64-unknown-mingw32
   Desired build platform : i386-unknown-mingw32
```

Matthew Pickering authored 6 years ago and Marge Bot committed 5 years ago

It seems that it has failed to execute at all since it was implemented.

We now run the linters on merge requests.

Ryan Scott authored 5 years ago and Marge Bot committed 5 years ago

!301 removed the `HsArrApp` and `HsArrForm` constructors, which
renders the corresponding extension points `XArrApp` and `XArrForm`
useless. This patch finally rips them out.

Ben Gamari authored 5 years ago and Marge Bot committed 5 years ago

As noted in #16466, `System.Environment.getExecutablePath` depends upon
`PathFileExistsW` which is defined by `shlwapi`.

Fixes #16466.

Ömer Sinan Ağacan authored 5 years ago and Marge Bot committed 5 years ago

Fixes #16425

Ryan Scott authored 5 years ago and Marge Bot committed 5 years ago

When GHC attempts to unify a metavariable with a type containing
foralls, it will be rejected as an occurrence of impredicativity.
GHC was /not/ extending the same treatment to predicate types, such
as in the following (erroneous) example from #11514:

```haskell
foo :: forall a. (Show a => a -> a) -> ()
foo = undefined
```

This will attempt to instantiate `undefined` at
`(Show a => a -> a) -> ()`, which is impredicative. This patch
catches impredicativity arising from predicates in this fashion.

Since GHC is pickier about impredicative instantiations, some test
cases needed to be updated to be updated so as not to fall afoul of
the new validity check. (There were a surprising number of
impredicative uses of `undefined`!) Moreover, the `T14828` test case
now has slightly less informative types shown with `:print`. This is
due to a a much deeper issue with the GHCi debugger (see #14828).

Fixes #11514.

Ben Gamari authored 6 years ago and Marge Bot committed 5 years ago

The `build` stage is meant to be a minimal smoke test to weed out broken
commits. The `validate-x86_64-linux-deb9` build will generally catch a
subset of issues caught by `validate-x86_64-linux-deb9-debug` so only
the latter should be in `build`.

Artem Pyanykh authored 6 years ago and Marge Bot committed 5 years ago

1. Place each section on a separate page to ensure required
alignment (wastes lots ot space, needs to be improved).
2. Unwire relocation logic from macho sections (the most fiddly part
is adjusting internal relocations).

Other todos:
0. Add a test for section alignment.
1. Investigate 32bit relocations!
2. Fix memory leak in ZEROPAGE section allocation.
3. Fix creating redundant jump islands for GOT.
4. Investigate more compact section placement.

Ben Gamari authored 6 years ago and Marge Bot committed 5 years ago

I believe removing __mingw_vsnwprintf from RtsSymbols fixed #16387.