Skip to content
Snippets Groups Projects

Some quality of life improvements

Merged Some quality of life improvements
wip/qol into master
2 unresolved threads
Merged Zubin requested to merge wip/qol into master
2 unresolved threads
  • Add current socket/snapshot name to title - this helps when you have multiple ghc-debug-brick sessions open
  • Allow setting the search limit in the UI
  • Show the current number of results as well as the search limit in the footer
  • Add a command to find ARR_WORDS closures over a given size
  • Only print the first 100 bytes of ARR_WORDS closures
  • Allow dumping ARR_WORDS closures to a file so that ARR_WORDS over 100 bytes can be inspected
Edited by Zubin

Merge request reports

Pipeline #87325 passed

Stage: test

    Pipeline passed for acb4f683 on wip/qol

    Merged by Matthew PickeringMatthew Pickering 1 year ago (Dec 5, 2023 4:21pm UTC)

    Loading

    Pipeline #87368 passed

    Stage: test

      Pipeline passed for acb4f683 on master

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
      ghc-debug-brick/src/Main.hs
      197 200 labelled lbl w =
      198 201 hLimit 17 (txtLabel lbl <+> vLimit 1 (fill ' ')) <+> w <+> vLimit 1 (fill ' ')
      199 202
      200 footer :: FooterMode -> Widget Name
      201 footer m = vLimit 1 $
      202 case m of
      203 footer :: Int -> Maybe Int -> FooterMode -> Widget Name
      204 footer n m mode = vLimit 1 $
    • Matthew Pickering
    • Matthew Pickering
      Matthew Pickering @mpickering started a thread on the diff
      • ghc-debug-brick/src/Main.hs
      625 630 (modify $ footerMode .~ footerInput FProfile)
      626 631 , Command "Find Retainers" (Vty.EvKey (KChar 'f') [Vty.MCtrl])
      627 632 (modify $ footerMode .~ footerInput FRetainer)
      628 , Command "Find Retainers (Exact)" (Vty.EvKey (KChar 'e') [Vty.MCtrl])
      633 , Command "Find Retainers (Exact)" (Vty.EvKey (KChar 'u') [Vty.MCtrl])
      629 634 (modify $ footerMode .~ footerInput FRetainerExact)
      635 , Command "Find Retainers of large ARR_WORDS" (Vty.EvKey (KChar 'g') [Vty.MCtrl])
    • Matthew Pickering
    • Matthew Pickering
    • Zubin added 4 commits

      added 4 commits

      • 4d350308 - Add mode for searching ArrWords over given size
      • da5e58bf - Allow setting result size
      • 604fdca6 - Show number of results
      • d82eff8e - Add current socket name to title

      Compare with previous version

      Toggle commit list
    • Zubin added 4 commits

      added 4 commits

      • fbf79b22 - Add mode for searching ArrWords over given size
      • 56d581f1 - Allow setting result size
      • b2e17bc1 - Show number of results
      • 8ccc2ebf - Add current socket name to title

      Compare with previous version

      Toggle commit list
    • Zubin added 4 commits

      added 4 commits

      • 4f195b98 - Add mode for searching ArrWords over given size
      • 9174d485 - Allow setting result size
      • e3e064bc - Show number of results
      • acb4f683 - Add current socket name to title

      Compare with previous version

      Toggle commit list
    • Matthew Pickering merged

      merged

      • Please register or sign in to reply