• Ryan Scott's avatar
    Fix the coverage checker's treatment of existential tyvars · a2d03c69
    Ryan Scott authored
    Previously, the pattern-match coverage checker was far too
    eager to freshen the names of existentially quantified type
    variables, which led to incorrect sets of type constraints that
    misled GHC into thinking that certain programs that involve nested
    GADT pattern matches were non-exhaustive (when in fact they were).
    Now, we generate extra equality constraints in the ConCon case of
    the coverage algorithm to ensure that these fresh tyvars align
    with existing existential tyvars. See
    `Note [Coverage checking and existential tyvars]` for the full story.
    
    Test Plan: make test TEST="T11984 T14098"
    
    Reviewers: gkaracha, bgamari, simonpj
    
    Reviewed By: simonpj
    
    Subscribers: simonpj, rwbarton, thomie, carter
    
    GHC Trac Issues: #11984, #14098
    
    Differential Revision: https://phabricator.haskell.org/D4434
    a2d03c69
Check.hs 89.4 KB