Skip to content
Snippets Groups Projects
Commit 2a942285 authored by Sebastian Graf's avatar Sebastian Graf Committed by Marge Bot
Browse files

PmCheck: Disattach COMPLETE pragma lookup from TyCons 

By not attaching COMPLETE pragmas with a particular TyCon and instead
assume that every COMPLETE pragma is applicable everywhere, we can
drastically simplify the logic that tries to initialise available
COMPLETE sets of a variable during the pattern-match checking process,
as well as fixing a few bugs.

Of course, we have to make sure not to report any of the
ill-typed/unrelated COMPLETE sets, which came up in a few regression
tests.

In doing so, we fix #17207, #18277 and #14422.

There was a metric decrease in #18478 by ~20%.

Metric Decrease:
    T18478
parent fb6e29e8
No related merge requests found
Pipeline #24569 passed with warnings
Stage: lint
    Stage: quick-build
      Stage: build
        Stage: full-build
          Stage: cleanup
            Stage: packaging
              Stage: testing
                Stage: deploy
                  Hide whitespace changes
                  Inline Side-by-side
                  Showing
                  with 366 additions and 462 deletions
                  0% or .
                  You are about to add 0 people to the discussion. Proceed with caution.
                  Finish editing this message first!
                  Please register or to comment