Fix untouchability test
This MR fixes #24938. The underlying problem was tha the test for "does this implication bring in scope any equalities" was plain wrong. See Note [Tracking Given equalities] and Note [Let-bound skolems] both in GHC.Tc.Solver.InertSet. Then * Test LocalGivenEqs succeeds for a different reason than before; see (LBS2) in Note [Let-bound skolems] * New test T24938a succeeds because of (LBS2), whereas it failed before. * Test LocalGivenEqs2 now fails, as it should. * Test T224938, the repro from the ticket, fails, as it should.
parent
842e119b
No related branches found
No related tags found
Pipeline #97088 passed
Stage: tool-lint
Stage: quick-build
Stage: full-build
Stage: packaging
Stage: testing
Showing
- compiler/GHC/Tc/Solver/InertSet.hs 81 additions, 66 deletionscompiler/GHC/Tc/Solver/InertSet.hs
- testsuite/tests/indexed-types/should_fail/T13784.stderr 7 additions, 2 deletionstestsuite/tests/indexed-types/should_fail/T13784.stderr
- testsuite/tests/linters/notes.stdout 0 additions, 2 deletionstestsuite/tests/linters/notes.stdout
- testsuite/tests/patsyn/should_fail/T11010.stderr 5 additions, 2 deletionstestsuite/tests/patsyn/should_fail/T11010.stderr
- testsuite/tests/typecheck/should_compile/LocalGivenEqs.hs 1 addition, 1 deletiontestsuite/tests/typecheck/should_compile/LocalGivenEqs.hs
- testsuite/tests/typecheck/should_compile/LocalGivenEqs2.hs 2 additions, 4 deletionstestsuite/tests/typecheck/should_compile/LocalGivenEqs2.hs
- testsuite/tests/typecheck/should_compile/LocalGivenEqs2.stderr 16 additions, 0 deletions...uite/tests/typecheck/should_compile/LocalGivenEqs2.stderr
- testsuite/tests/typecheck/should_compile/T24938a.hs 11 additions, 0 deletionstestsuite/tests/typecheck/should_compile/T24938a.hs
- testsuite/tests/typecheck/should_compile/all.T 3 additions, 1 deletiontestsuite/tests/typecheck/should_compile/all.T
- testsuite/tests/typecheck/should_fail/T22645.stderr 6 additions, 2 deletionstestsuite/tests/typecheck/should_fail/T22645.stderr
- testsuite/tests/typecheck/should_fail/T24938.hs 33 additions, 0 deletionstestsuite/tests/typecheck/should_fail/T24938.hs
- testsuite/tests/typecheck/should_fail/T24938.stderr 19 additions, 0 deletionstestsuite/tests/typecheck/should_fail/T24938.stderr
- testsuite/tests/typecheck/should_fail/all.T 1 addition, 0 deletionstestsuite/tests/typecheck/should_fail/all.T
Loading
Please register or sign in to comment