Key ModSummary cache by UnitId as well as FilePath
Multiple units can refer to the same files without any problem. Just another assumption which needs to be updated when we may have multiple home units. However, there is the invariant that within each unit each file only maps to one module, so as long as we also key the cache by UnitId then we are all good. This led to some confusing behaviour in GHCi when reloading, multipleHomeUnits_shared distils the essence of what can go wrong. Fixes #22679
Showing
- compiler/GHC/Driver/Make.hs 10 additions, 9 deletionscompiler/GHC/Driver/Make.hs
- testsuite/tests/driver/multipleHomeUnits/A.hs 1 addition, 0 deletionstestsuite/tests/driver/multipleHomeUnits/A.hs
- testsuite/tests/driver/multipleHomeUnits/all.T 5 additions, 0 deletionstestsuite/tests/driver/multipleHomeUnits/all.T
- testsuite/tests/driver/multipleHomeUnits/multipleHomeUnits_shared.stderr 2 additions, 0 deletions.../driver/multipleHomeUnits/multipleHomeUnits_shared.stderr
- testsuite/tests/driver/multipleHomeUnits/shared.script 1 addition, 0 deletionstestsuite/tests/driver/multipleHomeUnits/shared.script
- testsuite/tests/driver/multipleHomeUnits/unitShared1 1 addition, 0 deletionstestsuite/tests/driver/multipleHomeUnits/unitShared1
- testsuite/tests/driver/multipleHomeUnits/unitShared2 1 addition, 0 deletionstestsuite/tests/driver/multipleHomeUnits/unitShared2
Loading
Please register or sign in to comment