Commits on Source (5)
-
These are testing things which are sometimes out the control of a GHC developer. Therefore we shouldn't fail CI if something about these dependencies change because we can't do anything about it. It is still useful to have these statistics for visualisation in grafana though. Ticket #24759
c49493f2 -
It has already manifested large fluctuations and destabilising CI Fixes #24762
9562808d -
Unboxed sum constructors are now defined in the `GHC.Types` module, so if you manually quote an unboxed sum (e.g., `''Sum2#`), you will get a `Name` like: ```hs GHC.Types.Sum2# ``` The `unboxedSumTypeName` function in `template-haskell`, however, mistakenly believes that unboxed sum constructors are defined in `GHC.Prim`, so `unboxedSumTypeName 2` would return an entirely different `Name`: ```hs GHC.Prim.(#|#) ``` This is a problem for Template Haskell users, as it means that they can't be sure which `Name` is the correct one. (Similarly for `unboxedSumDataName`.) This patch fixes the implementations of `unboxedSum{Type,Data}Name` to use `GHC.Types` as the module. For consistency with `unboxedTupleTypeName`, the `unboxedSumTypeName` function now uses the non-punned syntax for unboxed sums (`Sum<N>#`) as the `OccName`. Fixes #24750.
fc24c5cf -
Alan Zimmerman authored
Closes #24754
7eab4e01 -
46b618dd
Showing
- compiler/GHC/Parser.y 1 addition, 1 deletioncompiler/GHC/Parser.y
- docs/users_guide/exts/ffi.rst 1 addition, 1 deletiondocs/users_guide/exts/ffi.rst
- libraries/template-haskell/Language/Haskell/TH/Lib/Syntax.hs 3 additions, 3 deletionslibraries/template-haskell/Language/Haskell/TH/Lib/Syntax.hs
- testsuite/tests/parser/should_compile/DumpSemis.stderr 1 addition, 1 deletiontestsuite/tests/parser/should_compile/DumpSemis.stderr
- testsuite/tests/perf/size/all.T 70 additions, 67 deletionstestsuite/tests/perf/size/all.T
- testsuite/tests/printer/Makefile 5 additions, 0 deletionstestsuite/tests/printer/Makefile
- testsuite/tests/printer/Test24754.hs 4 additions, 0 deletionstestsuite/tests/printer/Test24754.hs
- testsuite/tests/printer/all.T 1 addition, 0 deletionstestsuite/tests/printer/all.T
- testsuite/tests/quotes/T24750.hs 35 additions, 0 deletionstestsuite/tests/quotes/T24750.hs
- testsuite/tests/quotes/all.T 1 addition, 0 deletionstestsuite/tests/quotes/all.T
testsuite/tests/printer/Test24754.hs
0 → 100644
testsuite/tests/quotes/T24750.hs
0 → 100644