Commits on Source (6)
-
This patch simplifies the testsuite driver by removing the use_threads config field. It's just a degenerate case of threads=1.
633f2799 -
The testsuite driver used to create one thread per test case, and explicitly use semaphore and locks for rate limiting and synchronization. This is a bad practice in any language, and occasionally may result in livelock conditions (e.g. #22889). This patch uses concurrent.futures.ThreadPoolExecutor for scheduling test case runs, which is simpler and more robust.
ca6673e3 -
Do not apply the heuristic to associate a comment with a prior declaration for the first declaration in the file. Closes #22919
f22cce70 -
d69ecac2
-
Simon Peyton Jones authored
Following #22924 this patch narrows the test that stops us decomposing newtypes. The key change is the use of noGivenNewtypeReprEqs in GHC.Tc.Solver.Canonical.canTyConApp. We went to and fro on the solution, as you can see in #22924. The result is carefully documented in Note [Decomoposing newtype equalities] On the way I had revert most of commit 3e827c3f Author: Richard Eisenberg <rae@cs.brynmawr.edu> Date: Mon Dec 5 10:14:02 2022 -0500 Do newtype unwrapping in the canonicaliser and rewriter See Note [Unwrap newtypes first], which has the details. It turns out that (a) 3e827c3f makes GHC behave worse on some recursive newtypes (see one of the tests on this commit) (b) the finer-grained test (namely noGivenNewtypeReprEqs) renders 3e827c3f unnecessary
3bb8cc4d
Showing
- compiler/GHC/Core/TyCon.hs 1 addition, 1 deletioncompiler/GHC/Core/TyCon.hs
- compiler/GHC/Parser/Lexer.x 4 additions, 2 deletionscompiler/GHC/Parser/Lexer.x
- compiler/GHC/Tc/Solver/Canonical.hs 122 additions, 104 deletionscompiler/GHC/Tc/Solver/Canonical.hs
- compiler/GHC/Tc/Solver/InertSet.hs 17 additions, 4 deletionscompiler/GHC/Tc/Solver/InertSet.hs
- compiler/GHC/Tc/Solver/Rewrite.hs 13 additions, 57 deletionscompiler/GHC/Tc/Solver/Rewrite.hs
- libraries/transformers 1 addition, 1 deletionlibraries/transformers
- testsuite/driver/runtests.py 20 additions, 17 deletionstestsuite/driver/runtests.py
- testsuite/driver/testglobals.py 0 additions, 1 deletiontestsuite/driver/testglobals.py
- testsuite/driver/testlib.py 6 additions, 32 deletionstestsuite/driver/testlib.py
- testsuite/driver/testutil.py 0 additions, 20 deletionstestsuite/driver/testutil.py
- testsuite/tests/driver/T1959/test.T 1 addition, 1 deletiontestsuite/tests/driver/T1959/test.T
- testsuite/tests/ffi/should_run/all.T 2 additions, 2 deletionstestsuite/tests/ffi/should_run/all.T
- testsuite/tests/ghc-api/exactprint/T22919.hs 2 additions, 0 deletionstestsuite/tests/ghc-api/exactprint/T22919.hs
- testsuite/tests/ghc-api/exactprint/T22919.stderr 116 additions, 0 deletionstestsuite/tests/ghc-api/exactprint/T22919.stderr
- testsuite/tests/ghc-api/exactprint/Test20239.stderr 10 additions, 10 deletionstestsuite/tests/ghc-api/exactprint/Test20239.stderr
- testsuite/tests/ghc-api/exactprint/ZeroWidthSemi.stderr 10 additions, 9 deletionstestsuite/tests/ghc-api/exactprint/ZeroWidthSemi.stderr
- testsuite/tests/ghc-api/exactprint/all.T 1 addition, 0 deletionstestsuite/tests/ghc-api/exactprint/all.T
- testsuite/tests/parser/should_compile/DumpParsedAstComments.hs 3 additions, 0 deletions...uite/tests/parser/should_compile/DumpParsedAstComments.hs
- testsuite/tests/parser/should_compile/DumpParsedAstComments.stderr 141 additions, 49 deletions.../tests/parser/should_compile/DumpParsedAstComments.stderr
- testsuite/tests/rts/all.T 1 addition, 1 deletiontestsuite/tests/rts/all.T
testsuite/tests/ghc-api/exactprint/T22919.hs
0 → 100644