Skip to content

Atomic writes patch appears to be fragile on Windows

Since merging the atomic writes patch (!391 (merged), which starts fixing #14533) in !479 (closed) I have seen nearly all Windows builds in !79 (merged) fail with something along the lines of

C:\GitLabRunner\builds\28891e3c\0\ghc\ghc\tmp\ghcFD3.o.tmp: renameFile:renamePath:MoveFileEx "\\\\?\\C:\\GitLabRunner\\builds\\28891e3c\\0\\ghc\\ghc\\tmp\\ghcFD3.o.tmp" Just "\\\\?\\C:\\GitLabRunner\\builds\\28891e3c\\0\\ghc\\ghc\\tmp\\ghcFD3.o": does not exist (The system cannot find the file specified.)
make[1]: *** [utils/hsc2hs/ghc.mk:23: utils/hsc2hs/dist-install/package-data.mk] Error 1

I'm going to disable this behavior on Windows until we understand why this is happening.

Incidentally, it looks to me like above we are using the atomic rename functionality on a temporary file. It seems to me like ideally we would try avoiding this overhead.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information