Clean-up after separating AST from GhcPass !4778
The following discussions from !4778 (closed) should be addressed:
-
@rae started a discussion: (+1 comment) This one has a helpful comment. It makes me wonder whether all the
Outputable
instances should be inGHC.Hs.Extension.GhcPass
. I think they wouldn't be orphans there.But maybe that's better for another commit, as orphans really aren't too terrible.
-
@rae started a discussion: (+7 comments) Ew. I know why you want to do this. But it shouldn't be too hard to fix the problem first before doing this mega patch. For example,
HsBracketOut
should be implemented with extension points.I suppose you could convince me to let this patch in first and then remove these type families very soon thereafter, just because of the practical annoyance of keeping this patch alive.
-
@rae started a discussion: (+1 comment) Another small abomination, like
HsDoRn
. -
@rae started a discussion: (+2 comments) I'm surprised this file has no further changes. Isn't this stuff part of the general Haskell AST?
Ditto
Doc
. -
@rae started a discussion: (+1 comment) There are no references to this Note. I'm not quite sure where they should be, but there should be references somewhere. Maybe at the top of every list of
import
s withinLanguage.Haskell.Syntax
? -
@rae started a discussion: (+1 comment) I suppose this should go away, too.
-
@rae started a discussion: This Note is both in the old file and this new one.
-
@rae started a discussion: This Note is duplicated.
-
@rae started a discussion: This Note is duplicated.
-
@rae started a discussion: This Note is duplicated.
-
@rae started a discussion: This Note is duplicated.
-
@Ericson2314 started a discussion: (+1 comment) @rae Thanks for the thorough review, and also thanks for pointing out
--color-moved
.I've done the easy fixes, but I am a bit unsure where the duplicated notes ought to go --- that's party why they were duplicated in the first place. Notes having a habit of sometimes accumulating in one place or otherwise being non-local makes this feel less than straightforward to me.
If anyone has an opinion on a few cases or a guiding principle, I'd be happy to follow it.
-
@alanz started a discussion: (+1 comment) As discussed on IRC, I suggest merging this so the rebase burden is gone, then deciding at leisure where the notes go in a follow up