./validate results in many (>400) spurious failed tests on windows locally.
Most (all?) failures seem to be from makefile tests. I assume we don't quote something quite right.
The errors are something like:
=====> concio001(normal) 8036 of 8039 [0, 483, 0]
cd "C:/Users/andi/AppData/Local/Temp/ghctest-6b8pfckv/test spaces/libraries/base/tests/IO/concio001.run" && $MAKE -s --no-print-directory test.concio001 <
Actual stderr output differs from expected:
diff -uw "/dev/null" "C:/Users/andi/AppData/Local/Temp/ghctest-6b8pfckv/test spaces/libraries/base/tests/IO/concio001.run/concio001.run.stderr.normalised"<
--- /dev/null 2021-03-08 14:42:58.000000000 +0100
+++ "C:/Users/andi/AppData/Local/Temp/ghctest-6b8pfckv/test spaces/libraries/base/tests/IO/concio001.run/concio001.run.stderr.normalised" 2021-03-08 14:42:58.529778900 +0100
@@ -0,0 +1,3 @@
+/bin/sh: line 1: [: C://ghc//msys64//home//andi//ghc_strictDicts//bindisttest//install: binary operator expected
+/bin/sh: line 1: [: C://ghc//msys64//home//andi//ghc_strictDicts//bindisttest//install: binary operator expected
+/bin/sh: line 1: [: C://ghc//msys64//home//andi//ghc_strictDicts//bindisttest//install: binary operator expected
And in the list of unexpected failures:
Unexpected failures:
C:/Users/andi/AppData/Local/Temp/ghctest-6b8pfckv/test spaces/testsuite/tests/ghc-api/apirecomp001/apirecomp001.run apirecomp001 [bad stderr] (normal)
C:/Users/andi/AppData/Local/Temp/ghctest-6b8pfckv/test spaces/testsuite/tests/module/base01/base01.run base01 [bad stderr] (normal)
C:/Users/andi/AppData/Local/Temp/ghctest-6b8pfckv/test spaces/testsuite/tests/ghci/linking/dyn/big-obj.run big-obj [bad stderr] (normal)
C:/Users/andi/AppData/Local/Temp/ghctest-6b8pfckv/test spaces/testsuite/tests/backpack/cabal/bkpcabal01/bkpcabal01.run bkpcabal01 [bad stderr] (normal)
the spaces
prefix seems suspicious. Maybe the way hadrian invokes the testsuite somehow breaks make tests? Not sure.